diff mbox series

[bug#61797] teams: Don't generate multiple X-Debbugs-Cc: headers.

Message ID 20230219000008.23343-1-me@tobias.gr
State New
Headers show
Series [bug#61797] teams: Don't generate multiple X-Debbugs-Cc: headers. | expand

Commit Message

Tobias Geerinckx-Rice Feb. 19, 2023, midnight UTC
Debbugs has never supported this: the documented way to CC multiple
people is to comma-separate their addresses in one single header line.

See <https://www.debian.org/Bugs/Reporting>, ‘Sending copies of bug
reports to other addresses’.

* etc/teams.scm.in (cc): Generate a single X-Debbugs-Cc header.

Reported by Ludovic Courtès <ludo@gnu.org>
---
 etc/teams.scm.in | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)


base-commit: 54bcdaa3b13650c6ed2478707f02b82175d1ea27

Comments

Tobias Geerinckx-Rice Feb. 26, 2023, 1:10 p.m. UTC | #1
Wait.

As apteryx notes in bug #58813, using this to ‘guix send-mail … 
$(etc/teams.scm cc TEAM)’ is never going to work.

If that's the proposed use case, this is not worth fixing.

Closing.

T G-R
diff mbox series

Patch

diff --git a/etc/teams.scm.in b/etc/teams.scm.in
index ff913673e8..7dfe321ed9 100644
--- a/etc/teams.scm.in
+++ b/etc/teams.scm.in
@@ -569,7 +569,7 @@  (define (cc . teams)
   "Return arguments for `git send-email' to notify the members of the given
 TEAMS when a patch is received by Debbugs."
   (format #true
-          "~{--add-header=\"X-Debbugs-Cc: ~a\"~^ ~}"
+          "--add-header=\"X-Debbugs-Cc: ~{~a~^,~}\""
           (map person-email
                (delete-duplicates (append-map team-members teams) equal?))))