diff mbox series

[bug#61477] gnu: python-pygraphviz: Update to 1.10

Message ID 20230213130331.37045-1-swartvagher@par.tuwien.ac.at
State New
Headers show
Series [bug#61477] gnu: python-pygraphviz: Update to 1.10 | expand

Commit Message

Philippe SWARTVAGHER Feb. 13, 2023, 1:03 p.m. UTC 
* gnu/packages/graphviz.scm (python-pygraphviz): Update to 1.10
---
 gnu/packages/graphviz.scm | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)


base-commit: 5b1eab43f011983d9ee560d6935409b6b39706ff

Comments

Simon Tournier Feb. 15, 2023, 11:50 a.m. UTC | #1 
Hi Philippe, Chris,

On Mon, 13 Feb 2023 at 14:03, Philippe SWARTVAGHER <swartvagher@par.tuwien.ac.at> wrote:
> * gnu/packages/graphviz.scm (python-pygraphviz): Update to 1.10
                                                               --^
                                                            Missing dot

Missing two ending dot: one commit headline and one ChangeLog.

Well, QA says red:

    https://qa.guix.gnu.org/issue/61477

but it appears to me unrelated.  Chris, an idea?


Cheers,
simon
Philippe SWARTVAGHER Feb. 15, 2023, 4:19 p.m. UTC | #2 
> Missing two ending dot: one commit headline and one ChangeLog.
Fixed in attached revised patch (but it appears to me as a
nitpicking...).

> Well, QA says red:
I don't really understand why the QA is complaining...

Philippe.
Christopher Baines Feb. 15, 2023, 4:24 p.m. UTC | #3 
zimoun <zimon.toutoune@gmail.com> writes:

> On Mon, 13 Feb 2023 at 14:03, Philippe SWARTVAGHER <swartvagher@par.tuwien.ac.at> wrote:
>> * gnu/packages/graphviz.scm (python-pygraphviz): Update to 1.10
>                                                                --^
>                                                             Missing dot
>
> Missing two ending dot: one commit headline and one ChangeLog.
>
> Well, QA says red:
>
>     https://qa.guix.gnu.org/issue/61477
>
> but it appears to me unrelated.  Chris, an idea?

Appears grey (unknown) to me currently, but it could have been red
previously.

I see one odd and unrelated thing here, the derivation for
openmv-openscenegraph is flapping around as there's a #<gexp in the
builder script. I've fixed that in
https://git.savannah.gnu.org/cgit/guix.git/commit/?id=12127395dc55d9ea389a6dc619207c406725237e
Simon Tournier Feb. 16, 2023, 9:49 a.m. UTC | #4 
Hi Philippe,

On Wed, 15 Feb 2023 at 17:19, Philippe SWARTVAGHER <swartvagher@par.tuwien.ac.at> wrote:

> Fixed in attached revised patch (but it appears to me as a
> nitpicking...).

Yes, it is nitpicking! :-)  I mentioned it in case committer would have
missed it – to fix it before pushing.

Cheers,
simon

PS: If I understand correctly, after Bordeaux you are now in
Vienna.  Nice! :-)
Simon Tournier Feb. 16, 2023, 11:31 a.m. UTC | #5 
Hi Chris,

On Wed, 15 Feb 2023 at 16:24, Christopher Baines <mail@cbaines.net> wrote:

>>     https://qa.guix.gnu.org/issue/61477
>>
>> but it appears to me unrelated.  Chris, an idea?
>
> Appears grey (unknown) to me currently, but it could have been red
> previously.

As a wish :-), would it be possible to report somewhere when the QA
pushes the issue in the queue?


> I see one odd and unrelated thing here, the derivation for
> openmv-openscenegraph is flapping around as there's a #<gexp in the
> builder script. I've fixed that in
> https://git.savannah.gnu.org/cgit/guix.git/commit/?id=12127395dc55d9ea389a6dc619207c406725237e

Ah, thanks.  Well, the ’inherit’ thing bites us at so many places now
that I am starting to be doubtful if it is a good pattern at scale.
Anyway. :-)

Cheers,
simon

PS: BTW, the new version [1] LGTM. ;-)

1: https://issues.guix.gnu.org/msgid/20230215161951.37438-2-swartvagher@par.tuwien.ac.at
Christopher Baines Feb. 17, 2023, 4:47 p.m. UTC | #6 
zimoun <zimon.toutoune@gmail.com> writes:

> On Wed, 15 Feb 2023 at 16:24, Christopher Baines <mail@cbaines.net> wrote:
>
>>>     https://qa.guix.gnu.org/issue/61477
>>>
>>> but it appears to me unrelated.  Chris, an idea?
>>
>> Appears grey (unknown) to me currently, but it could have been red
>> previously.
>
> As a wish :-), would it be possible to report somewhere when the QA
> pushes the issue in the queue?

I don't follow what you mean, but I'd suggest filing a wishlist bug
against the guix package for qa-frontpage feature requests.

Thanks,

Chris
Simon Tournier Feb. 17, 2023, 5:05 p.m. UTC | #7 
Hi,

On Fri, 17 Feb 2023 at 17:48, Christopher Baines <mail@cbaines.net> wrote:

> > As a wish :-), would it be possible to report somewhere when the QA
> > pushes the issue in the queue?
>
> I don't follow what you mean, but I'd suggest filing a wishlist bug
> against the guix package for qa-frontpage feature requests.

Today, it is not possible to know the status: when the patch is
scheduled, I do not know when it was.

I will do my best for filling wishlist bug report.

Cheers,
simon
diff mbox series

Patch

diff --git a/gnu/packages/graphviz.scm b/gnu/packages/graphviz.scm
index 7c2cb1eae0..1691658576 100644
--- a/gnu/packages/graphviz.scm
+++ b/gnu/packages/graphviz.scm
@@ -213,7 +213,7 @@  (define-public python-graphviz
 (define-public python-pygraphviz
   (package
     (name "python-pygraphviz")
-    (version "1.7")
+    (version "1.10")
     (source
      (origin
        (method git-fetch)
@@ -223,7 +223,7 @@  (define-public python-pygraphviz
        (file-name (string-append "pygraphviz-" version "-checkout"))
        (sha256
         (base32
-         "0jqc3dzy9n0hn3b99zq8jp53901zpjzvvi5ns5mbaxg8kdrb1lfx"))))
+         "1yrzjp5n86ynlj32p5dj1aj67md6bzkk8hac74j5y3mbl94m259g"))))
     (build-system python-build-system)
     (inputs
      (list graphviz))