diff mbox series

[bug#61437] doc: contributing: Cover push frequency in the Commit Policy.

Message ID 20230211211505.7779-1-mail@cbaines.net
State New
Headers show
Series [bug#61437] doc: contributing: Cover push frequency in the Commit Policy. | expand

Commit Message

Christopher Baines Feb. 11, 2023, 9:15 p.m. UTC
* doc/contributing.texi (Commit Access): Add paragraph about push frequency.
---
 doc/contributing.texi | 6 ++++++
 1 file changed, 6 insertions(+)

Comments

Simon Tournier Feb. 14, 2023, 1:03 p.m. UTC | #1
Hi,

On sam., 11 févr. 2023 at 21:15, Christopher Baines <mail@cbaines.net> wrote:

> +Try to plan ahead and avoid pushing several times in a short time
> +window.  This reduces the likelyhood that others working on the same
> +branch will encounter problems when pushing.  It also reduces the load
> +on services like @url{https://data.guix.gnu.org,data.guix.gnu.org} that
> +process each revision that is pushed.

The point is to push by batch instead of pushing several times in a row,
right?


Cheers,
simon
Christopher Baines Feb. 17, 2023, 6:36 p.m. UTC | #2
Simon Tournier <zimon.toutoune@gmail.com> writes:

> Hi,
>
> On sam., 11 févr. 2023 at 21:15, Christopher Baines <mail@cbaines.net> wrote:
>
>> +Try to plan ahead and avoid pushing several times in a short time
>> +window.  This reduces the likelyhood that others working on the same
>> +branch will encounter problems when pushing.  It also reduces the load
>> +on services like @url{https://data.guix.gnu.org,data.guix.gnu.org} that
>> +process each revision that is pushed.
>
> The point is to push by batch instead of pushing several times in a row,
> right?

Pretty much, it's a balance of course as sometimes it'll be worth
pushing without much time between, but as I say there's advantages in
trying to plan ahead to reduce that.
Simon Tournier Feb. 20, 2023, 11:30 a.m. UTC | #3
Hi Chris,

On ven., 17 févr. 2023 at 18:36, Christopher Baines <mail@cbaines.net> wrote:

>>> +Try to plan ahead and avoid pushing several times in a short time
>>> +window.  This reduces the likelyhood that others working on the same
>>> +branch will encounter problems when pushing.  It also reduces the load
>>> +on services like @url{https://data.guix.gnu.org,data.guix.gnu.org} that
>>> +process each revision that is pushed.
>>
>> The point is to push by batch instead of pushing several times in a row,
>> right?
>
> Pretty much, it's a balance of course as sometimes it'll be worth
> pushing without much time between, but as I say there's advantages in
> trying to plan ahead to reduce that.

Well, maybe it is only me but I have difficulties to understand what you
mean by “plan ahead”.  Instead I would use “Try to push by batch and …”
or something like that.

Note the typo: s/likelyhood/likelihood

Well, LGTM.

Cheers,
simon
diff mbox series

Patch

diff --git a/doc/contributing.texi b/doc/contributing.texi
index c436bc4a31..09b9da3e89 100644
--- a/doc/contributing.texi
+++ b/doc/contributing.texi
@@ -1852,6 +1852,12 @@  commits that caused immediate problems.  This is subject to being
 adjusted, allowing individuals to commit directly on non-controversial
 changes on parts they’re familiar with.
 
+Try to plan ahead and avoid pushing several times in a short time
+window.  This reduces the likelyhood that others working on the same
+branch will encounter problems when pushing.  It also reduces the load
+on services like @url{https://data.guix.gnu.org,data.guix.gnu.org} that
+process each revision that is pushed.
+
 When pushing a commit on behalf of somebody else, please add a
 @code{Signed-off-by} line at the end of the commit log message---e.g.,
 with @command{git am --signoff}.  This improves tracking of who did