diff mbox series

[bug#61059] gnu: asymptote: Update to 2.84.

Message ID 20230125164855.1587305-1-mail@nicolasgoaziou.fr
State New
Headers show
Series [bug#61059] gnu: asymptote: Update to 2.84. | expand

Commit Message

Nicolas Goaziou Jan. 25, 2023, 4:48 p.m. UTC 
* gnu/packages/plotutils.scm (asymptote): Update to 2.84.
[native-inputs]: Add BISON and FLEX.
---
 gnu/packages/plotutils.scm | 10 +++++++---
 1 file changed, 7 insertions(+), 3 deletions(-)


base-commit: bd55412fc297b07b5cbe4e22abdec0419ef23010

Comments

Simon Tournier Jan. 26, 2023, 12:25 p.m. UTC | #1 
Hi,

Well, QA fails [1] for unrelated reasons [2], IIUC.

1: <https://qa.guix.gnu.org/issue/61059>
2: <https://data.qa.guix.gnu.org/job/43364>


On Wed, 25 Jan 2023 at 17:48, Nicolas Goaziou <mail@nicolasgoaziou.fr> wrote:
> * gnu/packages/plotutils.scm (asymptote): Update to 2.84.
> [native-inputs]: Add BISON and FLEX.
> ---
>  gnu/packages/plotutils.scm | 10 +++++++---
>  1 file changed, 7 insertions(+), 3 deletions(-)

LGTM.  “guix lint” reports:

"bash-minimal" should be in 'inputs' when 'wrap-program' is used
permanent redirect from http://asymptote.sourceforge.net to  https://asymptote.sourceforge.io/

And the package does not build reproductibly but that’s not blocker,
IMHO.


Cheers,
simon
Nicolas Goaziou Jan. 27, 2023, 9:03 a.m. UTC | #2 
Hello,

zimoun <zimon.toutoune@gmail.com> writes:

> LGTM.  “guix lint” reports:
>
> "bash-minimal" should be in 'inputs' when 'wrap-program' is used
> permanent redirect from http://asymptote.sourceforge.net to  https://asymptote.sourceforge.io/

Thank you for the feedback. I fixed those and applied the patch.

> And the package does not build reproductibly but that’s not blocker,

OK. I don't know how to deal with it, tho.

Regards,
diff mbox series

Patch

diff --git a/gnu/packages/plotutils.scm b/gnu/packages/plotutils.scm
index 678963575e..3244d861c3 100644
--- a/gnu/packages/plotutils.scm
+++ b/gnu/packages/plotutils.scm
@@ -1,7 +1,7 @@ 
 ;;; GNU Guix --- Functional package management for GNU
 ;;; Copyright © 2013, 2014, 2015, 2016, 2017, 2018, 2019, 2020, 2021 Ludovic Courtès <ludo@gnu.org>
 ;;; Copyright © 2015 Eric Bavier <bavier@member.fsf.org>
-;;; Copyright © 2016-2022 Nicolas Goaziou <mail@nicolasgoaziou.fr>
+;;; Copyright © 2016-2023 Nicolas Goaziou <mail@nicolasgoaziou.fr>
 ;;; Copyright © 2018 Tobias Geerinckx-Rice <me@tobias.gr>
 ;;; Copyright © 2020 Maxim Cournoyer <maxim.cournoyer@gmail.com>
 ;;;
@@ -30,10 +30,12 @@  (define-module (gnu packages plotutils)
   #:use-module (guix build-system gnu)
   #:use-module (gnu packages algebra)
   #:use-module (gnu packages autotools)
+  #:use-module (gnu packages bison)
   #:use-module (gnu packages bdw-gc)
   #:use-module (gnu packages boost)
   #:use-module (gnu packages cmake)
   #:use-module (gnu packages emacs)
+  #:use-module (gnu packages flex)
   #:use-module (gnu packages xorg)
   #:use-module (gnu packages image)
   #:use-module (gnu packages ghostscript)
@@ -269,14 +271,14 @@  (define-public ploticus
 (define-public asymptote
   (package
     (name "asymptote")
-    (version "2.83")
+    (version "2.84")
     (source
      (origin
        (method url-fetch)
        (uri (string-append "mirror://sourceforge/asymptote/"
                            version "/asymptote-" version ".src.tgz"))
        (sha256
-        (base32 "18w8nf0p1b3h74sk1b7w96kq5gcaq09idi4771ini7p594gsfg7y"))
+        (base32 "1nycdmlhs3r1qj5miww19683qqjf4hihsjwzwjj1q4mq0hnp0rb7"))
        (modules '((guix build utils)))
        (snippet
         ;; Remove bundled RapidJSON.
@@ -289,9 +291,11 @@  (define-public asymptote
     (native-inputs
      (list autoconf
            automake
+           bison
            boost
            cmake
            emacs-minimal
+           flex
            ghostscript                  ;for tests
            perl
            rapidjson