Message ID | 20230122162913.25140-1-ngraves@ngraves.fr |
---|---|
State | New |
Headers |
Return-Path: <guix-patches-bounces+patchwork=mira.cbaines.net@gnu.org> X-Original-To: patchwork@mira.cbaines.net Delivered-To: patchwork@mira.cbaines.net Received: by mira.cbaines.net (Postfix, from userid 113) id D7F9627BBEB; Sun, 22 Jan 2023 16:30:28 +0000 (GMT) X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on mira.cbaines.net X-Spam-Level: X-Spam-Status: No, score=-3.9 required=5.0 tests=BAYES_00,MAILING_LIST_MULTI, RCVD_IN_MSPIKE_H2,SPF_HELO_PASS autolearn=unavailable autolearn_force=no version=3.4.6 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mira.cbaines.net (Postfix) with ESMTPS id 52D8627BBE9 for <patchwork@mira.cbaines.net>; Sun, 22 Jan 2023 16:30:26 +0000 (GMT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from <guix-patches-bounces@gnu.org>) id 1pJdEK-0001jx-GS; Sun, 22 Jan 2023 11:30:04 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1pJdEJ-0001jm-2S for guix-patches@gnu.org; Sun, 22 Jan 2023 11:30:03 -0500 Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1pJdEI-0002Z4-Nh for guix-patches@gnu.org; Sun, 22 Jan 2023 11:30:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1pJdEI-0004K6-IJ for guix-patches@gnu.org; Sun, 22 Jan 2023 11:30:02 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#61008] [PATCH] gnu: emacs-smartparens: Fix package cl deprecation. Resent-From: Nicolas Graves <ngraves@ngraves.fr> Original-Sender: "Debbugs-submit" <debbugs-submit-bounces@debbugs.gnu.org> Resent-CC: guix-patches@gnu.org Resent-Date: Sun, 22 Jan 2023 16:30:02 +0000 Resent-Message-ID: <handler.61008.B.167440497116558@debbugs.gnu.org> Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 61008 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 61008@debbugs.gnu.org Cc: ngraves@ngraves.fr X-Debbugs-Original-To: guix-patches@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.167440497116558 (code B ref -1); Sun, 22 Jan 2023 16:30:02 +0000 Received: (at submit) by debbugs.gnu.org; 22 Jan 2023 16:29:31 +0000 Received: from localhost ([127.0.0.1]:52509 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces@debbugs.gnu.org>) id 1pJdDn-0004J0-Dw for submit@debbugs.gnu.org; Sun, 22 Jan 2023 11:29:31 -0500 Received: from lists.gnu.org ([209.51.188.17]:58584) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <ngraves@ngraves.fr>) id 1pJdDl-0004Is-Ej for submit@debbugs.gnu.org; Sun, 22 Jan 2023 11:29:31 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <ngraves@ngraves.fr>) id 1pJdDl-0001hT-51 for guix-patches@gnu.org; Sun, 22 Jan 2023 11:29:29 -0500 Received: from 3.mo561.mail-out.ovh.net ([46.105.44.175]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <ngraves@ngraves.fr>) id 1pJdDj-0002Mw-4I for guix-patches@gnu.org; Sun, 22 Jan 2023 11:29:28 -0500 Received: from director9.ghost.mail-out.ovh.net (unknown [10.109.156.6]) by mo561.mail-out.ovh.net (Postfix) with ESMTP id AD06B20D0C for <guix-patches@gnu.org>; Sun, 22 Jan 2023 16:29:22 +0000 (UTC) Received: from ghost-submission-6684bf9d7b-jzfhg (unknown [10.110.171.34]) by director9.ghost.mail-out.ovh.net (Postfix) with ESMTPS id 108561FD1C; Sun, 22 Jan 2023 16:29:21 +0000 (UTC) Received: from ngraves.fr ([37.59.142.108]) by ghost-submission-6684bf9d7b-jzfhg with ESMTPSA id XrszB2FkzWMhKRwA0aacxA (envelope-from <ngraves@ngraves.fr>); Sun, 22 Jan 2023 16:29:21 +0000 Authentication-Results: garm.ovh; auth=pass (GARM-108S002a1ad3a6c-7a37-4210-8511-9ef69fe15d03, 4BDE4A2AFA052C6C336BDE8B4000982C8C9A5CC0) smtp.auth=ngraves@ngraves.fr X-OVh-ClientIp: 81.67.140.142 Date: Sun, 22 Jan 2023 17:29:13 +0100 Message-Id: <20230122162913.25140-1-ngraves@ngraves.fr> X-Mailer: git-send-email 2.39.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Ovh-Tracer-Id: 7233343953479525090 X-VR-SPAMSTATE: OK X-VR-SPAMSCORE: 0 X-VR-SPAMCAUSE: gggruggvucftvghtrhhoucdtuddrgedvhedrudduiedgleduucetufdoteggodetrfdotffvucfrrhhofhhilhgvmecuqfggjfdpvefjgfevmfevgfenuceurghilhhouhhtmecuhedttdenucenucfjughrpefhvfevufffkffoggfgsedtkeertdertddtnecuhfhrohhmpefpihgtohhlrghsucfirhgrvhgvshcuoehnghhrrghvvghssehnghhrrghvvghsrdhfrheqnecuggftrfgrthhtvghrnhepteeffefhfffhjeevleeuvdehgffgveekheeuhfekhfehuefgheffhedugfegleeinecuffhomhgrihhnpehgihhthhhusgdrtghomhenucfkphepuddvjedrtddrtddruddpfeejrdehledrudegvddruddtkeenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepihhnvghtpeduvdejrddtrddtrddupdhmrghilhhfrhhomhepoehnghhrrghvvghssehnghhrrghvvghsrdhfrheqpdhnsggprhgtphhtthhopedupdhrtghpthhtohepghhuihigqdhprghttghhvghssehgnhhurdhorhhgpdfovfetjfhoshhtpehmohehiedupdhmohguvgepshhmthhpohhuth Received-SPF: pass client-ip=46.105.44.175; envelope-from=ngraves@ngraves.fr; helo=3.mo561.mail-out.ovh.net X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: <guix-patches.gnu.org> List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-patches>, <mailto:guix-patches-request@gnu.org?subject=unsubscribe> List-Archive: <https://lists.gnu.org/archive/html/guix-patches> List-Post: <mailto:guix-patches@gnu.org> List-Help: <mailto:guix-patches-request@gnu.org?subject=help> List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-patches>, <mailto:guix-patches-request@gnu.org?subject=subscribe> Reply-to: Nicolas Graves <ngraves@ngraves.fr> X-ACL-Warn: , Nicolas Graves via Guix-patches <guix-patches@gnu.org> From: Nicolas Graves via Guix-patches via <guix-patches@gnu.org> Errors-To: guix-patches-bounces+patchwork=mira.cbaines.net@gnu.org Sender: guix-patches-bounces+patchwork=mira.cbaines.net@gnu.org X-getmail-retrieved-from-mailbox: Patches |
Series |
[bug#61008] gnu: emacs-smartparens: Fix package cl deprecation.
|
|
Commit Message
Nicolas Graves
Jan. 22, 2023, 4:29 p.m. UTC
* gnu/packages/emacs-xyz.scm (emacs-smartparens): [arguments] Fix package cl deprecation. --- gnu/packages/emacs-xyz.scm | 11 +++++++++++ 1 file changed, 11 insertions(+)
Comments
Hello, Nicolas Graves via Guix-patches via <guix-patches@gnu.org> writes: > * gnu/packages/emacs-xyz.scm (emacs-smartparens): > [arguments] Fix package cl deprecation. > --- > gnu/packages/emacs-xyz.scm | 11 +++++++++++ > 1 file changed, 11 insertions(+) > > diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm > index ed5c3bd71d..8bde2825f1 100644 > --- a/gnu/packages/emacs-xyz.scm > +++ b/gnu/packages/emacs-xyz.scm > @@ -10575,6 +10575,17 @@ (define-public emacs-smartparens > (sha256 > (base32 "0zij2f2rjjym98w68jkp10n1ckpfprlkk217c3fg16hz5nq4vnm6")))) > (build-system emacs-build-system) > + (arguments > + (list > + #:phases > + #~(modify-phases %standard-phases > + (add-after 'unpack 'fix-deprecated-cl-warning > + (lambda _ > + (substitute* "smartparens.el" > + ((string-append > + "\\(eval-when-compile \\(require 'cl\\)\\) " > + " ; for `lexical-let'") > + ""))))))) AFAIU, we're fixing a mere warning. Why do you think it is worth a patch? Regards,
> AFAIU, we're fixing a mere warning. Indeed, it's the case for both patches. > Why do you think it is worth a patch? I was just curious about the warning and looked for packages trigerring it in my config, which are the two packages I sent. Smartparens is regularly updated but doesn't make new releases, I hesitated upadting it based on a commit, or use this patch. Origami's original repo hasn't changed in 5 years, but it had a pull request waiting for it. Both are quite used, but still trigger the warning since their codebase age. Their guix users have the warning and might enquire "for nothing serious". But all-in-all, it is neither urgent nor important, you can close both patches if you feel it's better without ;)
Nicolas Graves via Guix-patches via <guix-patches@gnu.org> writes: > Smartparens is regularly updated but doesn't make new releases, I > hesitated upadting it based on a commit, or use this patch. Note that emacs-smartparens doesn't build with your patch <https://qa.guix.gnu.org/issue/61008>. It may be worth updating it to latest commit in that case.
diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm index ed5c3bd71d..8bde2825f1 100644 --- a/gnu/packages/emacs-xyz.scm +++ b/gnu/packages/emacs-xyz.scm @@ -10575,6 +10575,17 @@ (define-public emacs-smartparens (sha256 (base32 "0zij2f2rjjym98w68jkp10n1ckpfprlkk217c3fg16hz5nq4vnm6")))) (build-system emacs-build-system) + (arguments + (list + #:phases + #~(modify-phases %standard-phases + (add-after 'unpack 'fix-deprecated-cl-warning + (lambda _ + (substitute* "smartparens.el" + ((string-append + "\\(eval-when-compile \\(require 'cl\\)\\) " + " ; for `lexical-let'") + ""))))))) (propagated-inputs (list emacs-dash emacs-markdown-mode)) (home-page "https://github.com/Fuco1/smartparens")