diff mbox series

[bug#60564] scripts: refresh: Add -T option.

Message ID 20230105011032.18623-1-jgart@dismail.de
State New
Headers show
Series [bug#60564] scripts: refresh: Add -T option. | expand

Commit Message

jgart Jan. 5, 2023, 1:10 a.m. UTC
* doc/guix.texi (Invoking guix refresh): Document the -T option.
* guix/scripts/refresh.scm (%options): Add the -T flag.
---
 doc/guix.texi            | 1 +
 guix/scripts/refresh.scm | 4 ++--
 2 files changed, 3 insertions(+), 2 deletions(-)

Comments

Felix Lechner Jan. 5, 2023, 1:35 a.m. UTC | #1
Hi,

Would the meaning of that option be more accessible to people without a
mathematics background, if it were called

  --list-prerequisites   ?

Kind regards,
Felix Lechner
Maxim Cournoyer Jan. 11, 2023, 7:43 p.m. UTC | #2
Hi,

jgart <jgart@dismail.de> writes:

> * doc/guix.texi (Invoking guix refresh): Document the -T option.
> * guix/scripts/refresh.scm (%options): Add the -T flag.
> ---
>  doc/guix.texi            | 1 +
>  guix/scripts/refresh.scm | 4 ++--
>  2 files changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/doc/guix.texi b/doc/guix.texi
> index 96b4675a01..e3ecf1f148 100644
> --- a/doc/guix.texi
> +++ b/doc/guix.texi
> @@ -14197,6 +14197,7 @@ for compatibility with an upgraded @code{flex} package.
>  @table @code
>  
>  @item --list-transitive
> +@item --T

The above should be -T, right?

I wonder if this option is common enough to need a dedicated short
switch?  I use it sparingly myself; typically I use '-l' to know which
packages I'd impact.

The rest looks OK.
Josselin Poiret March 3, 2023, 8:56 a.m. UTC | #3
Hi everyone,

Maxim Cournoyer <maxim.cournoyer@gmail.com> writes:

> The above should be -T, right?
>
> I wonder if this option is common enough to need a dedicated short
> switch?  I use it sparingly myself; typically I use '-l' to know which
> packages I'd impact.
>
> The rest looks OK.

There hasn't been any activity on this: is this still interesting to you
jgart?  If not, we can probably close this.

Best,
jgart March 3, 2023, 4:43 p.m. UTC | #4
I forgot to mention that the last patch I sent is v2 fixing the typo that Maxim pointed out.

all best,

jgart
Maxim Cournoyer March 21, 2023, 6:56 p.m. UTC | #5
Hi,

jgart <jgart@dismail.de> writes:

> * doc/guix.texi (Invoking guix refresh): Document the -T option.
> * guix/scripts/refresh.scm (%options): Add the -T flag.
> ---
>  doc/guix.texi            | 1 +
>  guix/scripts/refresh.scm | 4 ++--
>  2 files changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/doc/guix.texi b/doc/guix.texi
> index 96b4675a01..e3ecf1f148 100644
> --- a/doc/guix.texi
> +++ b/doc/guix.texi
> @@ -14197,6 +14197,7 @@ for compatibility with an upgraded @code{flex} package.
>  @table @code
>  
>  @item --list-transitive
> +@item --T
>  List all the packages which one or more packages depend upon.

Fixed to use itemx:

--8<---------------cut here---------------start------------->8---
modified   doc/guix.texi
@@ -14324,7 +14324,7 @@ for compatibility with an upgraded @code{flex} package.
 @table @code
 
 @item --list-transitive
-@item --T
+@itemx --T
 List all the packages which one or more packages depend upon.
 
 @example
--8<---------------cut here---------------end--------------->8---

>  @example
> diff --git a/guix/scripts/refresh.scm b/guix/scripts/refresh.scm
> index 6498d73c2b..6b633840e0 100644
> --- a/guix/scripts/refresh.scm
> +++ b/guix/scripts/refresh.scm
> @@ -101,7 +101,7 @@ (define %options
>          (option '(#\r "recursive") #f #f
>                  (lambda (opt name arg result)
>                    (alist-cons 'recursive? #t result)))
> -        (option '("list-transitive") #f #f
> +        (option '(#\T "list-transitive") #f #f
>                  (lambda (opt name arg result)
>                    (alist-cons 'list-transitive? #t result)))
>  
> @@ -159,7 +159,7 @@ (define (show-help)
>    (display (G_ "
>    -r, --recursive        check the PACKAGE and its inputs for upgrades"))
>    (display (G_ "
> -      --list-transitive  list all the packages that PACKAGE depends on"))
> +  -T, --list-transitive  list all the packages that PACKAGE depends on"))
>    (newline)
>    (display (G_ "
>        --keyring=FILE     use FILE as the keyring of upstream OpenPGP keys"))

And installed it.
diff mbox series

Patch

diff --git a/doc/guix.texi b/doc/guix.texi
index 96b4675a01..e3ecf1f148 100644
--- a/doc/guix.texi
+++ b/doc/guix.texi
@@ -14197,6 +14197,7 @@  for compatibility with an upgraded @code{flex} package.
 @table @code
 
 @item --list-transitive
+@item --T
 List all the packages which one or more packages depend upon.
 
 @example
diff --git a/guix/scripts/refresh.scm b/guix/scripts/refresh.scm
index 6498d73c2b..6b633840e0 100644
--- a/guix/scripts/refresh.scm
+++ b/guix/scripts/refresh.scm
@@ -101,7 +101,7 @@  (define %options
         (option '(#\r "recursive") #f #f
                 (lambda (opt name arg result)
                   (alist-cons 'recursive? #t result)))
-        (option '("list-transitive") #f #f
+        (option '(#\T "list-transitive") #f #f
                 (lambda (opt name arg result)
                   (alist-cons 'list-transitive? #t result)))
 
@@ -159,7 +159,7 @@  (define (show-help)
   (display (G_ "
   -r, --recursive        check the PACKAGE and its inputs for upgrades"))
   (display (G_ "
-      --list-transitive  list all the packages that PACKAGE depends on"))
+  -T, --list-transitive  list all the packages that PACKAGE depends on"))
   (newline)
   (display (G_ "
       --keyring=FILE     use FILE as the keyring of upstream OpenPGP keys"))