diff mbox series

[bug#60380] gnu: Add emacs-eat.

Message ID 20221228151728.17015-1-all_but_last@163.com
State New
Headers show
Series [bug#60380] gnu: Add emacs-eat. | expand

Commit Message

Zhu Zihao Dec. 28, 2022, 3:17 p.m. UTC 
* gnu/packages/emacs-xyz.scm (emacs-eat): New variable.
---
 gnu/packages/emacs-xyz.scm | 48 +++++++++++++++++++++++++++++++++++++-
 1 file changed, 47 insertions(+), 1 deletion(-)

Comments

Akib Azmain Turja Dec. 28, 2022, 5:04 p.m. UTC | #1 
Thanks for submitting this.

> * gnu/packages/emacs-xyz.scm (emacs-eat): New variable.
> ---
>  gnu/packages/emacs-xyz.scm | 48 +++++++++++++++++++++++++++++++++++++-
>  1 file changed, 47 insertions(+), 1 deletion(-)
> 
> diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
> index 8b0bb58275..9765ca2bbf 100644
> --- a/gnu/packages/emacs-xyz.scm
> +++ b/gnu/packages/emacs-xyz.scm
> @@ -81,7 +81,7 @@
>  ;;; Copyright © 2020, 2021, 2022 Niklas Eklund <niklas.eklund@posteo.net>
>  ;;; Copyright © 2020 Marco Grassi <marco.au.grassi98@protonmail.com>
>  ;;; Copyright © 2020 Tomás Ortín Fernández <tomasortin@mailbox.org>
> -;;; Copyright © 2020, 2021 Zhu Zihao <all_but_last@163.com>
> +;;; Copyright © 2020, 2021, 2022 Zhu Zihao <all_but_last@163.com>
>  ;;; Copyright © 2020 Adam Kandur <rndd@tuta.io>
>  ;;; Copyright © 2020 Tim Howes <timhowes@lavabit.com>
>  ;;; Copyright © 2020 Noah Landis <noahlandis@posteo.net>
> @@ -26592,6 +26592,52 @@ (define-public emacs-navigel
>  tabulated-lists).")
>      (license license:gpl3+)))
>  
> +(define-public emacs-eat
> +  (package
> +    (name "emacs-eat")
> +    (version "0.3.1")

Version 0.4, maybe?  (Just released now.  ;))

> +    (source
> +     (origin
> +       (method git-fetch)
> +       (uri (git-reference
> +             (url "https://codeberg.org/akib/emacs-eat")
> +             (commit (string-append "v" version))))
> +       (file-name (git-file-name name version))
> +       (sha256
> +        (base32
> +         "1ha9qc8ll41bc187vzpnnwb06jywvfzh7kxy4rfcdj6dc21wvb87"))
> +       (modules '((guix build utils)))
> +       (snippet
> +        #~(begin
> +            ;; Remove generated terminfo database.
> +            (delete-file-recursively "terminfo")
> +            #t))))

To build these files with Guix, I guess?

> +    (build-system emacs-build-system)
> +    (arguments
> +     (list
> +      #:tests? #t
> +      #:include #~(cons* "^term/"
> +                         "^terminfo/"
> +                         "^integration/"
> +                         "\\.ti$"
> +                         %default-include)
> +      #:phases
> +      #~(modify-phases %standard-phases
> +          (add-before 'install 'build-info
> +            (lambda _
> +              (invoke "make" "info")))
> +          (add-before 'install 'build-terminfo-database
> +            (lambda _
> +              (invoke "make" "terminfo"))))))
> +    (native-inputs
> +     (list ncurses texinfo))
> +    (home-page "https://codeberg.org/akib/emacs-eat")
> +    (synopsis "Terminal emulator in Emacs")

I guess it'd be better to use the string "Emulate A Terminal in Emacs"
as the synopsis.

> +    (description
> +     "This package provides a terminal emulator in Emacs, written in pure
> +Elisp.  It has features like complete mouse support and shell integration.")
> +    (license license:gpl3+)))
> +

Great description in a few words.

>  (define-public emacs-vterm
>    (let ((version "0.0.1")
>          (revision "1")
> -- 
> 2.38.1
Nicolas Goaziou Dec. 30, 2022, 10:33 a.m. UTC | #2 
Hello,

Zhu Zihao <all_but_last@163.com> writes:

> * gnu/packages/emacs-xyz.scm (emacs-eat): New variable.

I updated the package to 0.4 and applied your patch. Thank you.

> +       (snippet
> +        #~(begin
> +            ;; Remove generated terminfo database.
> +            (delete-file-recursively "terminfo")
> +            #t))))

This trailing #t is not necessary. I removed it.

Regards,
diff mbox series

Patch

diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index 8b0bb58275..9765ca2bbf 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -81,7 +81,7 @@ 
 ;;; Copyright © 2020, 2021, 2022 Niklas Eklund <niklas.eklund@posteo.net>
 ;;; Copyright © 2020 Marco Grassi <marco.au.grassi98@protonmail.com>
 ;;; Copyright © 2020 Tomás Ortín Fernández <tomasortin@mailbox.org>
-;;; Copyright © 2020, 2021 Zhu Zihao <all_but_last@163.com>
+;;; Copyright © 2020, 2021, 2022 Zhu Zihao <all_but_last@163.com>
 ;;; Copyright © 2020 Adam Kandur <rndd@tuta.io>
 ;;; Copyright © 2020 Tim Howes <timhowes@lavabit.com>
 ;;; Copyright © 2020 Noah Landis <noahlandis@posteo.net>
@@ -26592,6 +26592,52 @@  (define-public emacs-navigel
 tabulated-lists).")
     (license license:gpl3+)))
 
+(define-public emacs-eat
+  (package
+    (name "emacs-eat")
+    (version "0.3.1")
+    (source
+     (origin
+       (method git-fetch)
+       (uri (git-reference
+             (url "https://codeberg.org/akib/emacs-eat")
+             (commit (string-append "v" version))))
+       (file-name (git-file-name name version))
+       (sha256
+        (base32
+         "1ha9qc8ll41bc187vzpnnwb06jywvfzh7kxy4rfcdj6dc21wvb87"))
+       (modules '((guix build utils)))
+       (snippet
+        #~(begin
+            ;; Remove generated terminfo database.
+            (delete-file-recursively "terminfo")
+            #t))))
+    (build-system emacs-build-system)
+    (arguments
+     (list
+      #:tests? #t
+      #:include #~(cons* "^term/"
+                         "^terminfo/"
+                         "^integration/"
+                         "\\.ti$"
+                         %default-include)
+      #:phases
+      #~(modify-phases %standard-phases
+          (add-before 'install 'build-info
+            (lambda _
+              (invoke "make" "info")))
+          (add-before 'install 'build-terminfo-database
+            (lambda _
+              (invoke "make" "terminfo"))))))
+    (native-inputs
+     (list ncurses texinfo))
+    (home-page "https://codeberg.org/akib/emacs-eat")
+    (synopsis "Terminal emulator in Emacs")
+    (description
+     "This package provides a terminal emulator in Emacs, written in pure
+Elisp.  It has features like complete mouse support and shell integration.")
+    (license license:gpl3+)))
+
 (define-public emacs-vterm
   (let ((version "0.0.1")
         (revision "1")