diff mbox series

[bug#60079] guix: gexp: Clarify what output can be in gexp module commentary.

Message ID 20221215002600.13838-1-jgart@dismail.de
State New
Headers show
Series [bug#60079] guix: gexp: Clarify what output can be in gexp module commentary. | expand

Commit Message

jgart Dec. 15, 2022, 12:26 a.m. UTC 
* guix/gexp.scm (Commentary): Clarify comment.

Hi Ludo et al,

WDYT

all best,

jgart
---
 guix/gexp.scm | 9 +++++----
 1 file changed, 5 insertions(+), 4 deletions(-)

Comments

Ludovic Courtès Dec. 21, 2022, 1:31 p.m. UTC | #1 
Hi jgart,

jgart <jgart@dismail.de> skribis:

> --- a/guix/gexp.scm
> +++ b/guix/gexp.scm
> @@ -139,10 +139,11 @@ (define-module (guix gexp)
>  ;;; This module implements "G-expressions", or "gexps".  Gexps are like
>  ;;; S-expressions (sexps), with two differences:
>  ;;;
> -;;;   1. References (un-quotations) to derivations or packages in a gexp are
> -;;;      replaced by the corresponding output file name; in addition, the
> -;;;      'ungexp-native' unquote-like form allows code to explicitly refer to
> -;;;      the native code of a given package, in case of cross-compilation;
> +;;;   1. References (un-quotations) to derivations or packages in a gexp
> +;;;   are replaced by the corresponding output store path or file name;
> +;;;   in addition, the 'ungexp-native' unquote-like form allows code to
> +;;;   explicitly refer to the native code of a given package, in case
> +;;;   of cross-compilation;

I prefer not to apply this patch: it worsens indentation and adds the
words “store path”, which AFAICS bring nothing.

Thanks anyway for taking a look,
Ludo’.
Simon Tournier Jan. 6, 2023, 5:31 p.m. UTC | #2 
Hi,

On Wed, 21 Dec 2022 at 14:31, Ludovic Courtès <ludo@gnu.org> wrote:

>> --- a/guix/gexp.scm
>> +++ b/guix/gexp.scm
>> @@ -139,10 +139,11 @@ (define-module (guix gexp)
>>  ;;; This module implements "G-expressions", or "gexps".  Gexps are like
>>  ;;; S-expressions (sexps), with two differences:
>>  ;;;
>> -;;;   1. References (un-quotations) to derivations or packages in a gexp are
>> -;;;      replaced by the corresponding output file name; in addition, the
>> -;;;      'ungexp-native' unquote-like form allows code to explicitly refer to
>> -;;;      the native code of a given package, in case of cross-compilation;
>> +;;;   1. References (un-quotations) to derivations or packages in a gexp
>> +;;;   are replaced by the corresponding output store path or file name;
>> +;;;   in addition, the 'ungexp-native' unquote-like form allows code to
>> +;;;   explicitly refer to the native code of a given package, in case
>> +;;;   of cross-compilation;
>
> I prefer not to apply this patch: it worsens indentation and adds the
> words “store path”, which AFAICS bring nothing.

I agree.  Closing?

> Thanks anyway for taking a look,

Thanks.

Cheers,
simon
jgart Jan. 6, 2023, 10:58 p.m. UTC | #3 
Sure, feel free to close this one. Thanks for the review.

all best,

jgart
diff mbox series

Patch

diff --git a/guix/gexp.scm b/guix/gexp.scm
index 5f92174a2c..33d0d8487d 100644
--- a/guix/gexp.scm
+++ b/guix/gexp.scm
@@ -139,10 +139,11 @@  (define-module (guix gexp)
 ;;; This module implements "G-expressions", or "gexps".  Gexps are like
 ;;; S-expressions (sexps), with two differences:
 ;;;
-;;;   1. References (un-quotations) to derivations or packages in a gexp are
-;;;      replaced by the corresponding output file name; in addition, the
-;;;      'ungexp-native' unquote-like form allows code to explicitly refer to
-;;;      the native code of a given package, in case of cross-compilation;
+;;;   1. References (un-quotations) to derivations or packages in a gexp
+;;;   are replaced by the corresponding output store path or file name;
+;;;   in addition, the 'ungexp-native' unquote-like form allows code to
+;;;   explicitly refer to the native code of a given package, in case
+;;;   of cross-compilation;
 ;;;
 ;;;   2. Gexps embed information about the derivations they refer to.
 ;;;