From patchwork Wed Dec 14 20:46:40 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Maxim Cournoyer X-Patchwork-Id: 45327 Return-Path: X-Original-To: patchwork@mira.cbaines.net Delivered-To: patchwork@mira.cbaines.net Received: by mira.cbaines.net (Postfix, from userid 113) id 99D6527BBED; Wed, 14 Dec 2022 20:48:16 +0000 (GMT) X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on mira.cbaines.net X-Spam-Level: X-Spam-Status: No, score=-3.7 required=5.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FROM,MAILING_LIST_MULTI, RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mira.cbaines.net (Postfix) with ESMTPS id 0F83A27BBE9 for ; Wed, 14 Dec 2022 20:48:16 +0000 (GMT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1p5Yfc-0005ZT-Ta; Wed, 14 Dec 2022 15:48:04 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p5Yfa-0005YZ-2Z for guix-patches@gnu.org; Wed, 14 Dec 2022 15:48:02 -0500 Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1p5YfZ-0001Cl-Qp for guix-patches@gnu.org; Wed, 14 Dec 2022 15:48:01 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1p5YfZ-0004Ea-MT for guix-patches@gnu.org; Wed, 14 Dec 2022 15:48:01 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#60068] [PATCH v2 3/3] guix-install.sh: Directly exit in case of errors in chk_require. Resent-From: Maxim Cournoyer Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Wed, 14 Dec 2022 20:48:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 60068 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 60068@debbugs.gnu.org Cc: me@tobias.gr, Maxim Cournoyer Received: via spool by 60068-submit@debbugs.gnu.org id=B60068.167105082516230 (code B ref 60068); Wed, 14 Dec 2022 20:48:01 +0000 Received: (at 60068) by debbugs.gnu.org; 14 Dec 2022 20:47:05 +0000 Received: from localhost ([127.0.0.1]:41792 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p5Yef-0004Di-HT for submit@debbugs.gnu.org; Wed, 14 Dec 2022 15:47:05 -0500 Received: from mail-vk1-f175.google.com ([209.85.221.175]:43844) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p5Yec-0004Co-0I for 60068@debbugs.gnu.org; Wed, 14 Dec 2022 15:47:02 -0500 Received: by mail-vk1-f175.google.com with SMTP id g137so3743227vke.10 for <60068@debbugs.gnu.org>; Wed, 14 Dec 2022 12:47:01 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=45V4zygLPUbUUHmAG3m2+7+BRyv6ncJsMrXYIl7BXM4=; b=PZs+djoCMCmLZZb3IUHAwrIOdXIJ90y+uAWFfuuALzg3u6cwMORIY+pZIljB+Sid1q X9iN50cFHM6uWr84xtAOvGoQ8yynfGAIMHwvVDqNCC7Xwnu2ntgd+MAqJCPVMdrZ4dHR rMI3IJJHSEJbIYrb3V9IDdFTcV7rvcWNV/OhVFeyp/+nhWte1Q37jNz0L93QylxuFiIo IENN457vX3ppzv7aXTnc1AXpnlTnvC9pVFg+Lpzj5naH7JIQxcEPBbVv/M1KW2v1P5d3 RuhKy+SVmtDhFoDuKm+hs8Vw5H1ekz2lqgr7HWfqD7XpRoWXMMmIMp2CSjXZbFmRFJOy XcJw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=45V4zygLPUbUUHmAG3m2+7+BRyv6ncJsMrXYIl7BXM4=; b=SGGRiTIUfhv2dNkaoGKG98EN63MfvCDlGwJJKdUPu4OnY/rX0q6nMEaRfcQfDAJOSJ EWe0WfS6kpyV5ugKoTv41vni/Sxr8c4opmMrtxj7hpENpVEJe+w1Ze62jWgMFZsMy6Wt 9fDWjDjav9fbRGXcJno6n2awZbUL6VQmdE1QhBWhvUhMwyORN1xXa2lWzlOZG1wGXGcZ jVNI/Qo0K1/SaS3rPCua3q6NKDgMWDx0uPOArAjMXog+InCnxbtARHMOFSSF+mMSESRw /vpchpo3sdxbmry35T9BiV2YMD4vKb2kg3ysy/3JuK7jYfhLfb6s9cJjrTk4j3ytTgn2 XkWA== X-Gm-Message-State: ANoB5pkO9zJgb3pp6EAEhMr0hR5OV1/l77futnIGBRxsNHY9QDDUlaYe OosSL8g8hxbX83azM6BtRFdCLBRsK+33XQ== X-Google-Smtp-Source: AA0mqf5GCbN7rsc4OPyW9+4Pj/cv8X8B8CyDk/CyDy5K2+CP5gQ/D0Q+OdF5+K9/wOgs9V/5qgnXfg== X-Received: by 2002:a1f:9f42:0:b0:3bc:d00d:82e6 with SMTP id i63-20020a1f9f42000000b003bcd00d82e6mr15732643vke.2.1671050816393; Wed, 14 Dec 2022 12:46:56 -0800 (PST) Received: from localhost.localdomain ([2607:fad8:4:3::1006]) by smtp.gmail.com with ESMTPSA id p13-20020a05620a112d00b006f87d28ea3asm10192676qkk.54.2022.12.14.12.46.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 14 Dec 2022 12:46:56 -0800 (PST) From: Maxim Cournoyer Date: Wed, 14 Dec 2022 15:46:40 -0500 Message-Id: <20221214204640.16879-3-maxim.cournoyer@gmail.com> X-Mailer: git-send-email 2.38.1 In-Reply-To: <20221214204640.16879-1-maxim.cournoyer@gmail.com> References: <20221214204640.16879-1-maxim.cournoyer@gmail.com> MIME-Version: 1.0 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+patchwork=mira.cbaines.net@gnu.org Sender: guix-patches-bounces+patchwork=mira.cbaines.net@gnu.org X-getmail-retrieved-from-mailbox: Patches * etc/guix-install.sh (chk_require): Directly exit in case of errors in chk_require, instead of relying on 'set -e'. --- etc/guix-install.sh | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/etc/guix-install.sh b/etc/guix-install.sh index 62d85e765a..ea10f35250 100755 --- a/etc/guix-install.sh +++ b/etc/guix-install.sh @@ -137,10 +137,8 @@ chk_require() command -v "$c" &>/dev/null || warn+=("$c") done - [ "${#warn}" -ne 0 ] && - { _err "${ERR}Missing commands: ${warn[*]}."; - return 1; } - + [ "${#warn}" -ne 0 ] && die "Missing commands: ${warn[*]}." + _msg "${PAS}verification of required commands completed" }