| Message ID | 20221204195007.20997-1-paren@disroot.org |
|---|---|
| State | New |
| Headers | show |
| Series | [bug#59822,guix-artwork] website: base: home: Add 'DOWNLOAD LATEST' button. | expand |
Hello ( "( via Guix-patches" via <guix-patches@gnu.org> writes: > * website/apps/base/templates/home.scm (home-t)[#:content]: Add a > 'DOWNLOAD LATEST' button. Good idea. Would you add a copyright line or copyright disclaimer line and send an updated patch? > #:label (apply string-append > (C_ "button" `("DOWNLOAD v" ,(latest-guix-version) ""))) > […] > " " ; A space for readability in non-CSS browsers. > + ,(button-big > + #:label (apply string-append > + (C_ "button" `("DOWNLOAD LATEST"))) In the DOWNLOAD LATEST button, could you remove the (apply string-append and its now unmatched parenthesis? It is a trick to concatenate the translations for "DOWNLOAD v", the latest-guix-version and the translation for "". But for "DOWNLOAD LATEST", it is unneeded. And maybe untabify the lines you change. Other than that, LGTM, thank you! Regards, Florian
"pelzflorian (Florian Pelz)" <pelzflorian@pelzflorian.de> writes: > Would you add a copyright line or copyright disclaimer line and send an > updated patch? P.S. I am unsure if a copyright line is already warranted, but in doubt, I ask for one. Regards, Florian
"pelzflorian (Florian Pelz)" <pelzflorian@pelzflorian.de> writes: > "pelzflorian (Florian Pelz)" <pelzflorian@pelzflorian.de> writes: >> Would you add a copyright line or copyright disclaimer line and send an >> updated patch? > P.S. I am unsure if a copyright line is already warranted, but in doubt, > I ask for one. Excuse my bad judgment. No updated patch needed. I will apply as is.
Heya, On Sun Dec 4, 2022 at 9:50 PM GMT, pelzflorian (Florian Pelz) wrote: > Would you add a copyright line or copyright disclaimer line and send an > updated patch? Oops :) > In the DOWNLOAD LATEST button, could you remove the (apply string-append > and its now unmatched parenthesis? > > It is a trick to concatenate the translations for "DOWNLOAD v", the > latest-guix-version and the translation for "". But for "DOWNLOAD > LATEST", it is unneeded. Ah. I'll do that, yeah :) -- (
On Sun Dec 4, 2022 at 10:03 PM GMT, pelzflorian (Florian Pelz) wrote:
> Excuse my bad judgment. No updated patch needed. I will apply as is.
Oh, okay, never mind :)
-- (
Hi ( Sorry for my mails yesternight. After some sleep, I have second thoughts. With prominent links to 1.3.0 and to the latest version, users might think, of course they want latest. The 1.3.0 version got QA testing and is more likely to not get broken, even though latest might work on newer hardware. So maybe better not lead users to the untested version. Agreed? Can I close the bug without applying the patch? Regards, Florian
Hi, On Mon, 05 Dec 2022 at 09:00, "pelzflorian (Florian Pelz)" <pelzflorian@pelzflorian.de> wrote: > So maybe better not lead users to the untested version. > > Agreed? Can I close the bug without applying the patch? Well, maybe the « latest » could be more discoverable. For instance, when an user is here: https://guix.gnu.org/ then they click to the button « DOWNLOAD v1.3.0 ». Moreover nothing mention upfront the latest version. The user has to click on top right Download and select «Latest» – probably not done when they have already seen the button. I agree that another «Download latest» on the frontpage could be confusing. Instead, I propose, on the webpage, https://guix.gnu.org/en/download/ and in the header, As of version 1.3.0, the standalone Guix System can be installed on an i686, x86_64, ARMv7, or AArch64 machine. It uses the Linux-Libre kernel and the GNU Shepherd init system. Alternately, GNU Guix can be installed as an additional package manager on top of an installed Linux-based system. this sentence could be added, --8<---------------cut here---------------start------------->8--- These images are well-tested released images, and since Guix follows rolling release model, you might prefer to use [latest images](https://guix.gnu.org/en/download/latest/) --8<---------------cut here---------------end--------------->8--- WDYT? Cheers, simon
On Mon Dec 5, 2022 at 8:00 AM GMT, pelzflorian (Florian Pelz) wrote: > With prominent links to 1.3.0 and to the latest version, users might > think, of course they want latest. The 1.3.0 version got QA testing and > is more likely to not get broken, even though latest might work on newer > hardware. Yes, I thought of this possibility. How about "Download nightly" instead? -- (
Hi all. My reluctance is because there isn’t an advantage to using the latest image. zimoun <zimon.toutoune@gmail.com> writes: > this sentence could be added, > > These images are well-tested released images, and since Guix follows > rolling release model, you might prefer to use [latest images](https://guix.gnu.org/en/download/latest/) This is not a reason. On the contrary, users of 1.3.0 will get the current software once they upgrade. I can think of one consequence of using the 1.3.0 image: Users might have to adapt the generated config.scm once they pull and reconfigure. For example, because of changes in the swap-space definition. But this isn’t really a downside, since the OS configuration is the reason to use Guix on Guix System instead of a foreign distro. There maybe is hardware that is not yet supported on standard installer images. But it doesn’t need to be mentioned. There are no cutting edge hardware users on a libre distro, are there? Except those using tainted versions of the installer, not offered here. Lastly, I’m reluctant to change existing sentences, because they will not be translated soon enough. Am I mistaken? Regards, Florian
"pelzflorian (Florian Pelz)" <pelzflorian@pelzflorian.de> writes: > My reluctance is because there isn’t an advantage to using the latest image. > […] > Am I mistaken? Granted, there were bugs in the installer like <https://issues.guix.gnu.org/58377>.
Hi, On Mon, 05 Dec 2022 at 18:06, "pelzflorian (Florian Pelz)" <pelzflorian@pelzflorian.de> wrote: > zimoun <zimon.toutoune@gmail.com> writes: >> this sentence could be added, >> >> These images are well-tested released images, and since Guix follows >> rolling release model, you might prefer to use [latest images](https://guix.gnu.org/en/download/latest/) > > This is not a reason. On the contrary, users of 1.3.0 will get the > current software once they upgrade. It appears to me that this choice is up to the user. :-) BTW, since the release are less frequent than we would all like, some bugs in the v1.3 installer had been fixed. I do not have examples at hand (because I am too lazy to dig the bug tracker ;-)) but some reports have been closed with “already fixed, give a try to the new installer”. > I can think of one consequence of using the 1.3.0 image: Users might > have to adapt the generated config.scm once they pull and reconfigure. > For example, because of changes in the swap-space definition. But this > isn’t really a downside, since the OS configuration is the reason to use > Guix on Guix System instead of a foreign distro. > > There maybe is hardware that is not yet supported on standard installer > images. But it doesn’t need to be mentioned. There are no cutting edge > hardware users on a libre distro, are there? Except those using tainted > versions of the installer, not offered here. Well, I think it is worth to mention from this webpage https://guix.gnu.org/en/download/ the latest development webpage https://guix.gnu.org/en/download/latest/ Therefore, I still propose on the webpage <https://guix.gnu.org/en/download/> to add this sentence: --8<---------------cut here---------------start------------->8--- These images are well-tested released images, and since Guix follows rolling release model, the [latest development images are here](https://guix.gnu.org/en/download/latest/). --8<---------------cut here---------------end--------------->8--- WDYT? > Lastly, I’m reluctant to change existing sentences, because they will > not be translated soon enough. To me, this patch is orthogonal to release 1.4. Well, if you think it is better to apply after the publication of the release, that’s fine. :-) Cheers, simon
"(" <paren@disroot.org> writes:
> On Mon Dec 5, 2022 at 8:00 AM GMT, pelzflorian (Florian Pelz) wrote:
>> With prominent links to 1.3.0 and to the latest version, users might
>> think, of course they want latest. The 1.3.0 version got QA testing and
>> is more likely to not get broken, even though latest might work on newer
>> hardware.
>
> Yes, I thought of this possibility. How about "Download nightly" instead?
> -- (
Reopen. Dust hasn’t set yet on the issue.
Sorry I have read but not responded directly. In my view, the word
nightly would be less understandable than latest, for better or worse.
But recommending CI images still collides a good user experience.
CI images are for developers and testers. The standard installer did
not get bug fixes in the 1.3.0 period, but it can and should. It is
possible to put up a new installer without a new Guix release.
Regards,
Florian
On Thu Dec 8, 2022 at 4:44 PM GMT, pelzflorian (Florian Pelz) wrote: > CI images are for developers and testers. The standard installer did > not get bug fixes in the 1.3.0 period, but it can and should. It is > possible to put up a new installer without a new Guix release. Oh, that's a fair point. -- (
Hi Florian, all, On Thu, 08 Dec 2022 at 17:44, "pelzflorian (Florian Pelz)" <pelzflorian@pelzflorian.de> wrote: > CI images are for developers and testers. The standard installer did > not get bug fixes in the 1.3.0 period, but it can and should. It is > possible to put up a new installer without a new Guix release. I do not want to bother more but this paragraph suggests an other direction. :-) The front page <https://guix.gnu.org/> contains the explicit version number with the button «Download v1.3.0». Why not, just remove this version label and just have the button «Download»? This button «Download» leads to «https://guix.gnu.org/en/download/». Here, we could do the same as we do for the package guix, for instance use the version label 1.3.0-8.abc123 for some images. However, it means that we need to update <https://ftp.gnu.org/gnu/guix/> each time the recommended standard installer or other receives important fixes. It does not happen that much often. :-) Well, I mean being able to update independently some images of «GNU Guix binary» and «GNU Guix System» without going to the big dance of a complete release. Obviously, we could have more frequent releases; which would fix most of the issue. :-) But, we do not have. Somehow being able to update the standard downloadable installer without creating a new release appears to me a good solution. In addition to Ludo, who has the power to upload (and sign) the images to <https://ftp.gnu.org/gnu/guix/>? Cheers, simon
Hello, zimoun <zimon.toutoune@gmail.com> writes: > Well, I mean being able to update independently some images of «GNU Guix > binary» and «GNU Guix System» without going to the big dance of a > complete release. Why update the binary? guix pull will work. The only important changes are to the installer program and its dependencies (cryptsetup, parted, etc). > In addition to Ludo, who has the power to upload (and sign) the images > to <https://ftp.gnu.org/gnu/guix/>? Admittedly I do not know the process of uploading to gnu.org. My thought was that cherrypicking installer fixes back to, say, 1.4.0 is easy. Manual install would work like the manual says. The initial install would be more polished. Maybe I’m wrong though and cherrypicking fixes isn’t worth it compared to the CI image, and testing the installer really is about getting bugs squashed and not so much about polish. Regards, Florian
Hi, zimoun <zimon.toutoune@gmail.com> skribis: > The front page <https://guix.gnu.org/> contains the explicit version > number with the button «Download v1.3.0». Why not, just remove this > version label and just have the button «Download»? Because people would be downloading the snapshot of the day, for which we haven’t done as much testing as during a regular release process. The release process is not just ceremonial; over the last couple of months, we’ve put a lot of effort actually fixing things, in particular in the installer. Releases make sense IMO. [...] > In addition to Ludo, who has the power to upload (and sign) the images > to <https://ftp.gnu.org/gnu/guix/>? The process to be authorized to upload files to ftp.gnu.org and alpha.gnu.org is described in the GNU Maintainers Guide (info "(maintain) Automated FTP Uploads"). Maintainers can ask GNU sysadmins to add specific people to the list of authorized uploaders. Currently, I believe Ricardo, Maxim, Mathieu, and myself are authorized. We’ll make sure the next release team is authorized too! Ludo’.
diff --git a/website/apps/base/templates/home.scm b/website/apps/base/templates/home.scm index 7b72da8..db1707b 100644 --- a/website/apps/base/templates/home.scm +++ b/website/apps/base/templates/home.scm @@ -106,13 +106,19 @@ languages (EDSLs) to " ,(button-big #:label (apply string-append (C_ "button" `("DOWNLOAD v" ,(latest-guix-version) ""))) - #:url (guix-url "download/") - #:light #true) + #:url (guix-url "download/") + #:light #true) " " ; A space for readability in non-CSS browsers. + ,(button-big + #:label (apply string-append + (C_ "button" `("DOWNLOAD LATEST"))) + #:url (guix-url "download/latest/") + #:light #true) + " " ,(button-big #:label (C_ "button" "CONTRIBUTE") - #:url (guix-url "contribute/") - #:light #true))) + #:url (guix-url "contribute/") + #:light #true))) ;; Discover Guix. (section