| Message ID | 20221126115426.7385-1-paren@disroot.org |
|---|---|
| State | New |
| Headers | show |
| Series | [bug#59523,v2,1/3] doc: contributing: Note '-v REVISION' bug in 'git send-email'. | expand |
Hi, On Sat, 26 Nov 2022 at 11:54, "\( via Guix-patches" via <guix-patches@gnu.org> wrote: > * doc/contributing.texi ("Submitting Patches")["Sending a Patch Series"]: > Note that a bug in 'git send-email' means '-v REVISION' (with a > space) will not work. This patch and all the 2 others LGTM. Cheers, simon
"( via Guix-patches" via <guix-patches@gnu.org> writes: > * doc/contributing.texi ("Submitting Patches")["Sending a Patch Series"]: > Note that a bug in 'git send-email' means '-v REVISION' (with a > space) will not work. > --- > doc/contributing.texi | 8 +++++++- > 1 file changed, 7 insertions(+), 1 deletion(-) I've pushed this to master now as 09cd488c973c2ea27cfa2224489aca317f596341. Thanks, Chris
Hi, Christopher Baines <mail@cbaines.net> writes: > "( via Guix-patches" via <guix-patches@gnu.org> writes: > >> * doc/contributing.texi ("Submitting Patches")["Sending a Patch Series"]: >> Note that a bug in 'git send-email' means '-v REVISION' (with a >> space) will not work. >> --- >> doc/contributing.texi | 8 +++++++- >> 1 file changed, 7 insertions(+), 1 deletion(-) > > I've pushed this to master now as > 09cd488c973c2ea27cfa2224489aca317f596341. OK! Don't forget to revert when git 2.40 lands in master, as it includes a fix.
diff --git a/doc/contributing.texi b/doc/contributing.texi index 40ae33ecac..913c7cf436 100644 --- a/doc/contributing.texi +++ b/doc/contributing.texi @@ -1462,10 +1462,16 @@ address and the @option{-v} flag with @command{git send-email}. @example $ git commit -a -$ git send-email -1 -a --base=auto -v @var{REVISION} \ +$ git send-email -1 -a --base=auto -v@var{REVISION} \ --to=@var{ISSUE_NUMBER}@@debbugs.gnu.org @end example +@quotation Note +Due to an apparent bug in @command{git send-email}, +@option{-v @var{REVISION}} (with the space) will not work; you +@emph{must} use @option{-v@var{REVISION}}. +@end quotation + You can find out @var{ISSUE_NUMBER} either by searching on the mumi interface at @url{issues.guix.gnu.org} for the name of your patch or reading the acknowledgement email sent automatically by Debbugs in
* doc/contributing.texi ("Submitting Patches")["Sending a Patch Series"]: Note that a bug in 'git send-email' means '-v REVISION' (with a space) will not work. --- doc/contributing.texi | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) base-commit: d33ed58169edc027cfb6c256ecabde87e59918ed