Message ID | 20221123190710.26517-1-paren@disroot.org |
---|---|
State | New |
Headers |
Return-Path: <guix-patches-bounces+patchwork=mira.cbaines.net@gnu.org> X-Original-To: patchwork@mira.cbaines.net Delivered-To: patchwork@mira.cbaines.net Received: by mira.cbaines.net (Postfix, from userid 113) id DD3B727BBEC; Wed, 23 Nov 2022 19:08:31 +0000 (GMT) X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on mira.cbaines.net X-Spam-Level: X-Spam-Status: No, score=-3.7 required=5.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,MAILING_LIST_MULTI,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS, URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.6 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mira.cbaines.net (Postfix) with ESMTPS id 9CBEC27BBE9 for <patchwork@mira.cbaines.net>; Wed, 23 Nov 2022 19:08:29 +0000 (GMT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from <guix-patches-bounces@gnu.org>) id 1oxv6O-0005pq-AF; Wed, 23 Nov 2022 14:08:08 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1oxv6I-0005pD-RX for guix-patches@gnu.org; Wed, 23 Nov 2022 14:08:02 -0500 Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1oxv6I-0000SS-HS for guix-patches@gnu.org; Wed, 23 Nov 2022 14:08:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1oxv6I-000547-DL for guix-patches@gnu.org; Wed, 23 Nov 2022 14:08:02 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#59523] [PATCH] doc: contributing: Note '-v REVISION' bug in 'git send-email'. Resent-From: "(" <paren@disroot.org> Original-Sender: "Debbugs-submit" <debbugs-submit-bounces@debbugs.gnu.org> Resent-CC: guix-patches@gnu.org Resent-Date: Wed, 23 Nov 2022 19:08:02 +0000 Resent-Message-ID: <handler.59523.B.166923044519426@debbugs.gnu.org> Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 59523 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 59523@debbugs.gnu.org Cc: "\(" <paren@disroot.org> X-Debbugs-Original-To: guix-patches@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.166923044519426 (code B ref -1); Wed, 23 Nov 2022 19:08:02 +0000 Received: (at submit) by debbugs.gnu.org; 23 Nov 2022 19:07:25 +0000 Received: from localhost ([127.0.0.1]:56260 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces@debbugs.gnu.org>) id 1oxv5g-00053F-Jv for submit@debbugs.gnu.org; Wed, 23 Nov 2022 14:07:24 -0500 Received: from lists.gnu.org ([209.51.188.17]:42972) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <paren@disroot.org>) id 1oxv5e-000536-SL for submit@debbugs.gnu.org; Wed, 23 Nov 2022 14:07:23 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <paren@disroot.org>) id 1oxv5e-0005kN-NE for guix-patches@gnu.org; Wed, 23 Nov 2022 14:07:22 -0500 Received: from knopi.disroot.org ([178.21.23.139]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <paren@disroot.org>) id 1oxv5b-0000LN-Ef for guix-patches@gnu.org; Wed, 23 Nov 2022 14:07:21 -0500 Received: from localhost (localhost [127.0.0.1]) by disroot.org (Postfix) with ESMTP id C390040794; Wed, 23 Nov 2022 20:07:17 +0100 (CET) X-Virus-Scanned: SPAM Filter at disroot.org Received: from knopi.disroot.org ([127.0.0.1]) by localhost (disroot.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id eZ4LwkH0FxYC; Wed, 23 Nov 2022 20:07:16 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=disroot.org; s=mail; t=1669230436; bh=WzaNiOk5Ib/E7XLk0F0OmJqcRPapBf4Vt37IwwezI4k=; h=From:To:Cc:Subject:Date:From; b=Mgzi0AT25FEQnVTxBWgnOprwzqyijWdT/8ICUZWRCNhWl1bQ4I+gQyFcLyt4E5oQ5 FH8ERQyPWQzDioyP64AMgjl26f10d/8YCGBERhOGyIqVHZGyMSVo/80be0HuKsGkKQ 9IBxVS8+tEqPvfLBliOm/rKJ7MFMX9fWJKa960+4WP9LZPwIy/JLlrjF+2YqQl8bR6 Uyc7orS8CELrc0wp0NnOCD0qUlwevLYyRtv38/T3U/hJokRZISK+AnDI17KgQ7zUiM B4Ubl5NYiKP6Jqgxy4jRpidYBYe8m1CpPXZ5QL4b5owFt3htaEQtGOxU/RhMogOVqO M9vggxJ5r9HTg== Date: Wed, 23 Nov 2022 19:07:10 +0000 Message-Id: <20221123190710.26517-1-paren@disroot.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=178.21.23.139; envelope-from=paren@disroot.org; helo=knopi.disroot.org X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: <guix-patches.gnu.org> List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-patches>, <mailto:guix-patches-request@gnu.org?subject=unsubscribe> List-Archive: <https://lists.gnu.org/archive/html/guix-patches> List-Post: <mailto:guix-patches@gnu.org> List-Help: <mailto:guix-patches-request@gnu.org?subject=help> List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-patches>, <mailto:guix-patches-request@gnu.org?subject=subscribe> Reply-to: "\(" <paren@disroot.org> X-ACL-Warn: , "\( via Guix-patches" <guix-patches@gnu.org> From: "\( via Guix-patches" via <guix-patches@gnu.org> Errors-To: guix-patches-bounces+patchwork=mira.cbaines.net@gnu.org Sender: guix-patches-bounces+patchwork=mira.cbaines.net@gnu.org X-getmail-retrieved-from-mailbox: Patches |
Series |
[bug#59523] doc: contributing: Note '-v REVISION' bug in 'git send-email'.
|
|
Commit Message
\(
Nov. 23, 2022, 7:07 p.m. UTC
* doc/contributing.texi ("Submitting Patches")["Sending a Patch Series"]: Note that a bug in 'git send-email' means '-v REVISION' (with a space) will not work. --- Heya Guix, Turns out that due to a bug in ``git send-email'', using ``-v 2'' with a space between the flag and the argument won't work. If you try it, it'll print a confusing error message, so this patch updates the manual to note this and remove the space in an example that uses it. -- ( doc/contributing.texi | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) base-commit: d33ed58169edc027cfb6c256ecabde87e59918ed
Comments
"( via Guix-patches" via 写道: > Turns out that due to a bug in ``git send-email'', using ``-v > 2'' Has this been reported upstream? Kind regards, T G-R
Hi, On Wed, 23 Nov 2022 at 19:07, "\( via Guix-patches" via <guix-patches@gnu.org> wrote: > Turns out that due to a bug in ``git send-email'', using ``-v 2'' with > a space between the flag and the argument won't work. If you try it, it'll > print a confusing error message, so this patch updates the manual to note > this and remove the space in an example that uses it. Arf clunky Git CLI. :-) The git-format-patch manual says: -v <n>, --reroll-count=<n> so the space is allowed and it seems to work. The git-send-email manual says, git send-email [<options>] <format-patch options> and indeed, --8<---------------cut here---------------start------------->8--- $ git send-email -1 -v 2 --to=trash@trash.com fatal: ambiguous argument '2': unknown revision or path not in the working tree. Use '--' to separate paths from revisions, like this: 'git <command> [<revision>...] -- [<file>...]' format-patch -o /tmp/bin67IOTaX -1 2: command returned error: 128 --8<---------------cut here---------------end--------------->8--- But it works without the space. Arf, Git CLI… Cheers, simon
On Wed Nov 23, 2022 at 7:30 PM GMT, Tobias Geerinckx-Rice wrote:
> Has this been reported upstream?
Not afaik. The person who originally noticed this said they had
considered reporting it but it looked like a pain to report. I'll
have a look myself in a moment.
-- (
"\( via Guix-patches" via writes: > On Wed Nov 23, 2022 at 7:30 PM GMT, Tobias Geerinckx-Rice wrote: >> Has this been reported upstream? > > Not afaik. The person who originally noticed this said they had > considered reporting it but it looked like a pain to report. I'll > have a look myself in a moment. I've just sent a patch: https://lore.kernel.org/git/20221124020056.242185-1-kyle@kyleam.com
Kyle Meyer writes: > I've just sent a patch: > > https://lore.kernel.org/git/20221124020056.242185-1-kyle@kyleam.com Just to close the loop here: that landed in Git v2.40.0.
Hi, Kyle Meyer <kyle@kyleam.com> writes: > Kyle Meyer writes: > >> I've just sent a patch: >> >> https://lore.kernel.org/git/20221124020056.242185-1-kyle@kyleam.com > > Just to close the loop here: that landed in Git v2.40.0. Awesome. We're now at 2.39, so it seems we can just wait a bit to get 2.40 and then close this issue.
diff --git a/doc/contributing.texi b/doc/contributing.texi index 40ae33ecac..913c7cf436 100644 --- a/doc/contributing.texi +++ b/doc/contributing.texi @@ -1462,10 +1462,16 @@ address and the @option{-v} flag with @command{git send-email}. @example $ git commit -a -$ git send-email -1 -a --base=auto -v @var{REVISION} \ +$ git send-email -1 -a --base=auto -v@var{REVISION} \ --to=@var{ISSUE_NUMBER}@@debbugs.gnu.org @end example +@quotation Note +Due to an apparent bug in @command{git send-email}, +@option{-v @var{REVISION}} (with the space) will not work; you +@emph{must} use @option{-v@var{REVISION}}. +@end quotation + You can find out @var{ISSUE_NUMBER} either by searching on the mumi interface at @url{issues.guix.gnu.org} for the name of your patch or reading the acknowledgement email sent automatically by Debbugs in