diff mbox series

[bug#58381,3/3] gnu: Add yubikey-agent.

Message ID 20221008163932.15808-3-ngraves@ngraves.fr
State New
Headers show
Series [bug#58381,1/3] gnu: Add go-github-com-go-piv-piv-go. | expand

Checks

Context Check Description
cbaines/comparison success View comparision
cbaines/git-branch success View Git branch
cbaines/applying patch success View Laminar job
cbaines/issue success View issue

Commit Message

Nicolas Graves Oct. 8, 2022, 4:39 p.m. UTC 
* gnu/packages/security-token.scm (yubikey-agent): New variable.
---
 gnu/packages/security-token.scm | 32 ++++++++++++++++++++++++++++++++
 1 file changed, 32 insertions(+)

Comments

Christopher Baines Oct. 11, 2022, 10:50 a.m. UTC | #1 
Nicolas Graves via Guix-patches via <guix-patches@gnu.org> writes:

> +      (propagated-inputs
> +       (list go-golang-org-x-term
> +             go-golang-org-x-sys
> +             go-golang-org-x-crypto
> +             go-github-com-twpayne-go-pinentry-minimal
> +             go-github-com-go-piv-piv-go
> +             pcsc-lite))

Similar comment here regarding the propagated inputs.

This looks excessive, I'm guessing yubikey-agent includes binaries, so
why are these go things required in the profile at runtime?

Thanks,

Chris
diff mbox series

Patch

diff --git a/gnu/packages/security-token.scm b/gnu/packages/security-token.scm
index af7325ee79..306d0b86e6 100644
--- a/gnu/packages/security-token.scm
+++ b/gnu/packages/security-token.scm
@@ -62,6 +62,7 @@  (define-module (gnu packages security-token)
   #:use-module (gnu packages graphviz)
   #:use-module (gnu packages gnome)
   #:use-module (gnu packages gnupg)
+  #:use-module (gnu packages golang)
   #:use-module (gnu packages gtk)
   #:use-module (gnu packages libusb)
   #:use-module (gnu packages linux)
@@ -1021,3 +1022,34 @@  (define-public go-github-com-twpayne-go-pinentry-minimal
 which only depends on Go's standard library.  It is a fork of
 @url{https://github.com/twpayne/go-pinentry}.")
     (license license:expat)))
+
+(define-public yubikey-agent
+  (let* ((commit "6d9db9c29100daacbe83e74653c79c94acc5958d")
+         (revision "1"))
+    (package
+      (name "yubikey-agent")
+      (version (git-version "0" revision commit))
+      (source
+       (origin
+         (method git-fetch)
+         (uri (git-reference
+               (url "https://github.com/FiloSottile/yubikey-agent")
+               (commit commit)))
+         (file-name (git-file-name name version))
+         (sha256
+          (base32 "06y2qjq0m365sdl6inxzfnqyd346i5sgfis5crw2zmgsl1q5kdws"))))
+      (build-system go-build-system)
+      (arguments
+       '(#:import-path "filippo.io/yubikey-agent"))
+      (propagated-inputs
+       (list go-golang-org-x-term
+             go-golang-org-x-sys
+             go-golang-org-x-crypto
+             go-github-com-twpayne-go-pinentry-minimal
+             go-github-com-go-piv-piv-go
+             pcsc-lite))
+      (native-inputs (list pkg-config))
+      (home-page "https://filippo.io/yubikey-agent")
+      (synopsis "yubikey-agent")
+      (description "yubikey-agent is a seamless ssh-agent for YubiKeys.")
+      (license license:bsd-3))))