From patchwork Fri Sep 16 01:33:01 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: jgart X-Patchwork-Id: 5716 Return-Path: X-Original-To: patchwork@mira.cbaines.net Delivered-To: patchwork@mira.cbaines.net Received: by mira.cbaines.net (Postfix, from userid 113) id 0FCEC27BBEA; Fri, 16 Sep 2022 02:35:11 +0100 (BST) X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on mira.cbaines.net X-Spam-Level: X-Spam-Status: No, score=-2.7 required=5.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,MAILING_LIST_MULTI,SPF_HELO_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.6 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mira.cbaines.net (Postfix) with ESMTPS id BF69927BBE9 for ; Fri, 16 Sep 2022 02:35:10 +0100 (BST) Received: from localhost ([::1]:39080 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oZ0G5-00069O-Ux for patchwork@mira.cbaines.net; Thu, 15 Sep 2022 21:35:09 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:34756) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oZ0Fz-00069D-8S for guix-patches@gnu.org; Thu, 15 Sep 2022 21:35:03 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:41969) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oZ0Fy-0003yr-Nt for guix-patches@gnu.org; Thu, 15 Sep 2022 21:35:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1oZ0Fy-0000Uh-9l for guix-patches@gnu.org; Thu, 15 Sep 2022 21:35:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#57845] [PATCH v2] guix: Clarify what CRC is. References: <20220916012919.9558-1-jgart@dismail.de> In-Reply-To: <20220916012919.9558-1-jgart@dismail.de> Resent-From: jgart Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Fri, 16 Sep 2022 01:35:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 57845 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 57845@debbugs.gnu.org Cc: Ludovic Court s , jgart Received: via spool by 57845-submit@debbugs.gnu.org id=B57845.16632920951883 (code B ref 57845); Fri, 16 Sep 2022 01:35:02 +0000 Received: (at 57845) by debbugs.gnu.org; 16 Sep 2022 01:34:55 +0000 Received: from localhost ([127.0.0.1]:41047 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oZ0Fq-0000UJ-Ni for submit@debbugs.gnu.org; Thu, 15 Sep 2022 21:34:55 -0400 Received: from mx1.dismail.de ([78.46.223.134]:11188) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oZ0Fm-0000U4-5v for 57845@debbugs.gnu.org; Thu, 15 Sep 2022 21:34:52 -0400 Received: from mx1.dismail.de (localhost [127.0.0.1]) by mx1.dismail.de (OpenSMTPD) with ESMTP id 0d69f966; Fri, 16 Sep 2022 03:34:44 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed; d=dismail.de; h=from:to:cc :subject:date:message-id:mime-version:content-type :content-transfer-encoding; s=20190914; bh=f4T3Z6tblavOJCitMz28+ 2628ICVR3moIYpoAlNB05U=; b=L4HFleoekBtbSlMW0lnzBxrSnANAhuaLraiva 1MXRlTgkiYSmTq3Yob6+XALekiRDtFynq9AbUkywBPCWiQ8LhQM/wXbEpv936BG/ PtNj/6u/zGBU1lwuQW2kAK9Syr6oIkW320R0dwqj6NJG3kJ0+z2hEK3N5/YWvTh+ bOyFoGP6pA7nxZFk4yRRbPbvAxa9Y0C9mt6B6WIJ4/n2KC3NSvW4NuJLDWkJ5HJn LHb3nCoZgK0pfBH1P6+z1q/Y7H7DEpG+CrivfMeIvfmHPu4WFdDTpe2pQDG67vQk I1LMYKSxFvNAmI9zqqdBOoUnwklRVhhPBFrjSN/je2ikfERRQ== Received: from smtp2.dismail.de ( [10.240.26.12]) by mx1.dismail.de (OpenSMTPD) with ESMTP id 66328d4f; Fri, 16 Sep 2022 03:34:44 +0200 (CEST) Received: from smtp2.dismail.de (localhost [127.0.0.1]) by smtp2.dismail.de (OpenSMTPD) with ESMTP id 7316da20; Fri, 16 Sep 2022 03:34:44 +0200 (CEST) Received: by dismail.de (OpenSMTPD) with ESMTPSA id b1f2b84f (TLSv1.3:TLS_AES_256_GCM_SHA384:256:NO); Fri, 16 Sep 2022 03:34:43 +0200 (CEST) Date: Thu, 15 Sep 2022 20:33:01 -0500 Message-Id: <20220916013259.9803-1-jgart@dismail.de> X-Mailer: git-send-email 2.37.3 MIME-Version: 1.0 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+patchwork=mira.cbaines.net@gnu.org Sender: "Guix-patches" Reply-to: jgart X-ACL-Warn: , jgart via Guix-patches X-Patchwork-Original-From: jgart via Guix-patches via From: jgart X-getmail-retrieved-from-mailbox: Patches * guix/build-debug-link (Commentary): Clarify that CRC refers to cyclic redundancy check and fix broken link to issue. [define-module]: Remove empty line. Forgot to mention in the commit message that I also fixed the broken link to the issue. all best, jgart --- guix/build/debug-link.scm | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/guix/build/debug-link.scm b/guix/build/debug-link.scm index 9167737fb3..8fd90d951d 100644 --- a/guix/build/debug-link.scm +++ b/guix/build/debug-link.scm @@ -1,5 +1,6 @@ ;;; GNU Guix --- Functional package management for GNU ;;; Copyright © 2018 Ludovic Courtès +;;; Copyright © 2022 jgart ;;; ;;; This file is part of GNU Guix. ;;; @@ -28,7 +29,6 @@ (define-module (guix build debug-link) #:export (debuglink-crc32 elf-debuglink set-debuglink-crc - graft-debug-links)) ;;; Commentary: @@ -38,10 +38,10 @@ (define-module (guix build debug-link) ;;; create separate debug files (info "(gdb) Separate Debug Files"). ;;; ;;; The main facility of this module is 'graft-debug-links', which allows us -;;; to update the CRC that appears in '.gnu_debuglink' sections when grafting, -;;; such that separate debug files remain usable after grafting. Failing to -;;; do that, GDB would complain about CRC mismatch---see -;;; . +;;; to update the cyclic redundancy check (CRC) that appears in +;;; '.gnu_debuglink' sections when grafting, such that separate debug files +;;; remain usable after grafting. Failing to do that, GDB would complain +;;; about CRC mismatch---see . ;;; ;;; Code: