diff mbox series

[bug#57845,v2] guix: Clarify what CRC is.

Message ID 20220916013259.9803-1-jgart@dismail.de
State Accepted
Headers show
Series [bug#57845,v2] guix: Clarify what CRC is. | expand

Checks

Context Check Description
cbaines/comparison success View comparision
cbaines/git-branch success View Git branch
cbaines/applying patch success View Laminar job
cbaines/issue success View issue

Commit Message

jgart Sept. 16, 2022, 1:33 a.m. UTC 
* guix/build-debug-link (Commentary): Clarify that CRC refers to cyclic
redundancy check and fix broken link to issue.
[define-module]: Remove empty line.

Forgot to mention in the commit message that I also fixed the broken
link to the issue.

all best,

jgart
---
 guix/build/debug-link.scm | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

Comments

Ludovic Courtès Sept. 26, 2022, 9:11 p.m. UTC | #1 
Hi,

jgart <jgart@dismail.de> skribis:

> * guix/build-debug-link (Commentary): Clarify that CRC refers to cyclic
> redundancy check and fix broken link to issue.
> [define-module]: Remove empty line.
>
> Forgot to mention in the commit message that I also fixed the broken
> link to the issue.
>
> all best,
>
> jgart

Applied, but without the copyright line (expanding those three letters
is not copyrightable) and without the blank line removal (it’s here on
purpose to separate different levels of the interface).

BTW, the original bug URL is not “broken”: the page is just less
pleasant to the eye.  :-)

Thanks,
Ludo’.
jgart Sept. 27, 2022, 4:02 p.m. UTC | #2 
On Mon, 26 Sep 2022 23:11:35 +0200 Ludovic Courtès <ludo@gnu.org> wrote:

Thanks! No worries

all best,

jgart
diff mbox series

Patch

diff --git a/guix/build/debug-link.scm b/guix/build/debug-link.scm
index 9167737fb3..8fd90d951d 100644
--- a/guix/build/debug-link.scm
+++ b/guix/build/debug-link.scm
@@ -1,5 +1,6 @@ 
 ;;; GNU Guix --- Functional package management for GNU
 ;;; Copyright © 2018 Ludovic Courtès <ludo@gnu.org>
+;;; Copyright © 2022 jgart <jgart@dismail.de>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -28,7 +29,6 @@  (define-module (guix build debug-link)
   #:export (debuglink-crc32
             elf-debuglink
             set-debuglink-crc
-
             graft-debug-links))
 
 ;;; Commentary:
@@ -38,10 +38,10 @@  (define-module (guix build debug-link)
 ;;; create separate debug files (info "(gdb) Separate Debug Files").
 ;;;
 ;;; The main facility of this module is 'graft-debug-links', which allows us
-;;; to update the CRC that appears in '.gnu_debuglink' sections when grafting,
-;;; such that separate debug files remain usable after grafting.  Failing to
-;;; do that, GDB would complain about CRC mismatch---see
-;;; <https://bugs.gnu.org/19973>.
+;;; to update the cyclic redundancy check (CRC) that appears in
+;;; '.gnu_debuglink' sections when grafting, such that separate debug files
+;;; remain usable after grafting.  Failing to do that, GDB would complain
+;;; about CRC mismatch---see <https://issues.guix.gnu.org/19973>.
 ;;;
 ;;; Code: