[bug#57060,v2,2/2] gnu: pcc: Respect --without-tests.

Message ID 20220808190839.20727-2-paren@disroot.org
State New
Headers
Series [bug#57060,v2,1/2] gnu: pcc: Fix build. |

Commit Message

\( Aug. 8, 2022, 7:08 p.m. UTC
* gnu/packages/c.scm (pcc)[arguments]<#:phases>{check}: Respect the
  `tests?` argument.
---
 gnu/packages/c.scm | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)
  

Comments

Mathieu Othacehe Aug. 11, 2022, 8:29 a.m. UTC | #1
> * gnu/packages/c.scm (pcc)[arguments]<#:phases>{check}: Respect the
>   `tests?` argument.

Pushed both patches, thanks Maxime for reviewing.

Mathieu
  

Patch

diff --git a/gnu/packages/c.scm b/gnu/packages/c.scm
index 113a331070..39f048e993 100644
--- a/gnu/packages/c.scm
+++ b/gnu/packages/c.scm
@@ -197,8 +197,9 @@  (define-public pcc
                    (substitute* (list "cc/ccom/scan.l" "cc/cxxcom/scan.l")
                      (("lineno, ") ""))))
                (replace 'check
-                 (lambda _
-                   (invoke "make" "-C" "cc/cpp" "test"))))))
+                 (lambda* (#:key tests? #:allow-other-keys)
+                   (when tests?
+                     (invoke "make" "-C" "cc/cpp" "test")))))))
     (native-inputs (list bison flex))
     (synopsis "Portable C compiler")
     (description