| Message ID | 20220704200228.17157-1-jgart@dismail.de |
|---|---|
| State | Accepted |
| Headers | show |
| Series | [bug#56387] computed-file: Clarify comment about guile record field. | expand |
| Context | Check | Description |
|---|---|---|
| cbaines/comparison | success | View comparision |
| cbaines/git branch | success | View Git branch |
| cbaines/applying patch | success | View Laminar job |
| cbaines/issue | success | View issue |
Hi jgart, jgart <jgart@dismail.de> writes: > * guix/gexp.scm (<computed-file>): Clarify that what goes in the guile > record field is any variant of a guile package record instance. > --- > guix/gexp.scm | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/guix/gexp.scm b/guix/gexp.scm > index ef92223048..eba65e92cf 100644 > --- a/guix/gexp.scm > +++ b/guix/gexp.scm > @@ -581,7 +581,7 @@ (define-record-type <computed-file> > computed-file? > (name computed-file-name) ;string > (gexp computed-file-gexp) ;gexp > - (guile computed-file-guile) ;<package> > + (guile computed-file-guile) ;<package guile-*> > (options computed-file-options)) ;list of arguments If this was a statically typed language, the proper type of the argument accepted would be <package>, not <package guile-*>, so I'm inclined to leave it the way it is (also, we'd have to survey the whole code base to adjust for our current convention, which is to use <package>). Closing, Thanks, Maxim
diff --git a/guix/gexp.scm b/guix/gexp.scm index ef92223048..eba65e92cf 100644 --- a/guix/gexp.scm +++ b/guix/gexp.scm @@ -581,7 +581,7 @@ (define-record-type <computed-file> computed-file? (name computed-file-name) ;string (gexp computed-file-gexp) ;gexp - (guile computed-file-guile) ;<package> + (guile computed-file-guile) ;<package guile-*> (options computed-file-options)) ;list of arguments (define* (computed-file name gexp