[bug#56094,v2] gnu: wm: Switch sway from elogind to basu.
Commit Message
* gnu/packages/wm.scm (basu): Switch sway from elogind to basu.
[inputs]: Replace elogind with basu for sd-bus library dependency.
[arguments]: Use G-expressions.
<#:configure-flags>: Request building against basu.
---
gnu/packages/wm.scm | 7 ++++---
1 file changed, 4 insertions(+), 3 deletions(-)
Comments
block 56094 by 56136
thanks
Am Mittwoch, dem 22.06.2022 um 12:27 +0300 schrieb muradm:
> * gnu/packages/wm.scm (basu): Switch sway from elogind to basu.
Should be sway.
> [inputs]: Replace elogind with basu for sd-bus library dependency.
This can be simplified to "Replace ‘elogind’ with ‘basu’."
> [arguments]: Use G-expressions.
Actually, you don't, and even if, that ought to be a separate commit.
> <#:configure-flags>: Request building against basu.
Is this necessary? Doesn't sway have autodetection for basu?
Cheers
Next one reflecting changes.
Yes, necessary to state basu explicitly, meson.build detects
like systemd -> elogind -> basu. While removed from sway
dependencies, elogind still comes from dependencies of
dependencies.
--
muradm
Liliana Marie Prikler <liliana.prikler@ist.tugraz.at> writes:
> block 56094 by 56136
> thanks
>
> Am Mittwoch, dem 22.06.2022 um 12:27 +0300 schrieb muradm:
>> * gnu/packages/wm.scm (basu): Switch sway from elogind to basu.
> Should be sway.
>> [inputs]: Replace elogind with basu for sd-bus library
>> dependency.
> This can be simplified to "Replace ‘elogind’ with ‘basu’."
>> [arguments]: Use G-expressions.
> Actually, you don't, and even if, that ought to be a separate
> commit.
>> <#:configure-flags>: Request building against basu.
> Is this necessary? Doesn't sway have autodetection for basu?
>
>
> Cheers
Am Mittwoch, dem 22.06.2022 um 12:38 +0300 schrieb muradm:
> Next one reflecting changes.
>
> Yes, necessary to state basu explicitly, meson.build detects
> like systemd -> elogind -> basu. While removed from sway
> dependencies, elogind still comes from dependencies of
> dependencies.
We call that a transitive propagated input. You should probably add a
comment that elogind "still exists" and justify your defensive
programming in there.
Cheers
@@ -1572,7 +1572,8 @@ (define-public sway
(base32 "0j4sdbsrlvky1agacc0pcz9bwmaxjmrapjnzscbd2i0cria2fc5j"))))
(build-system meson-build-system)
(arguments
- `(#:phases
+ `(#:configure-flags '("-Dsd-bus-provider=basu")
+ #:phases
(modify-phases %standard-phases
(add-before 'configure 'hardcode-paths
(lambda* (#:key inputs #:allow-other-keys)
@@ -1587,8 +1588,8 @@ (define-public sway
(string-append "'" (assoc-ref inputs "scdoc")
"/bin/scdoc'")))
#t)))))
- (inputs (list cairo
- elogind
+ (inputs (list basu
+ cairo
gdk-pixbuf
json-c
libevdev