Message ID | 20220619143905.29089-1-mail@muradm.net |
---|---|
State | New |
Headers |
Return-Path: <guix-patches-bounces+patchwork=mira.cbaines.net@gnu.org> X-Original-To: patchwork@mira.cbaines.net Delivered-To: patchwork@mira.cbaines.net Received: by mira.cbaines.net (Postfix, from userid 113) id 7CD5527BBEA; Sun, 19 Jun 2022 15:40:25 +0100 (BST) X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on mira.cbaines.net X-Spam-Level: X-Spam-Status: No, score=-3.7 required=5.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,MAILING_LIST_MULTI,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS, URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.6 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mira.cbaines.net (Postfix) with ESMTPS id 4568127BBE9 for <patchwork@mira.cbaines.net>; Sun, 19 Jun 2022 15:40:25 +0100 (BST) Received: from localhost ([::1]:42262 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from <guix-patches-bounces+patchwork=mira.cbaines.net@gnu.org>) id 1o2w6C-00044h-Eb for patchwork@mira.cbaines.net; Sun, 19 Jun 2022 10:40:24 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:40216) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1o2w5s-00044V-2j for guix-patches@gnu.org; Sun, 19 Jun 2022 10:40:05 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:58913) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1o2w5r-0003C9-5z for guix-patches@gnu.org; Sun, 19 Jun 2022 10:40:03 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1o2w5q-00069M-O1 for guix-patches@gnu.org; Sun, 19 Jun 2022 10:40:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#56094] [PATCH] gnu: Remove unnecessary sway dependency on elogind. Resent-From: muradm <mail@muradm.net> Original-Sender: "Debbugs-submit" <debbugs-submit-bounces@debbugs.gnu.org> Resent-CC: guix-patches@gnu.org Resent-Date: Sun, 19 Jun 2022 14:40:02 +0000 Resent-Message-ID: <handler.56094.B.165564955523569@debbugs.gnu.org> Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 56094 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 56094@debbugs.gnu.org X-Debbugs-Original-To: guix-patches@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.165564955523569 (code B ref -1); Sun, 19 Jun 2022 14:40:02 +0000 Received: (at submit) by debbugs.gnu.org; 19 Jun 2022 14:39:15 +0000 Received: from localhost ([127.0.0.1]:52810 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces@debbugs.gnu.org>) id 1o2w55-000685-D6 for submit@debbugs.gnu.org; Sun, 19 Jun 2022 10:39:15 -0400 Received: from lists.gnu.org ([209.51.188.17]:49756) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <mail@muradm.net>) id 1o2w4z-00067s-PV for submit@debbugs.gnu.org; Sun, 19 Jun 2022 10:39:14 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:39232) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <mail@muradm.net>) id 1o2w4z-00042B-4I for guix-patches@gnu.org; Sun, 19 Jun 2022 10:39:09 -0400 Received: from nomad-cl1.staging.muradm.net ([139.162.159.157]:60374 helo=nomad-cl1.muradm.net) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <mail@muradm.net>) id 1o2w4x-0002rB-Ma for guix-patches@gnu.org; Sun, 19 Jun 2022 10:39:08 -0400 Received: from localhost ([127.0.0.1]:35112) by nomad-cl1.muradm.net with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from <mail@muradm.net>) id 1o2w2g-0004cB-VF for guix-patches@gnu.org; Sun, 19 Jun 2022 14:36:47 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=muradm.net; s=mail; h=Content-Transfer-Encoding:MIME-Version:Message-Id:Date:Subject:To: From:Sender:Reply-To:Cc:Content-Type:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: In-Reply-To:References:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=KJOE8WuR7kvm9N5El4H+CvmJEjCI8wycNxV+v/r8sCw=; b=krp7wcmEOAJjYc38wuSQJ28D8q ruvSI9prJEuxCbWxYKDtjr3PvLMZgKP1OSKDTAPkp2JXxCwTIj/V9EePnYdAO3qeCCpLAXISmRDO/ 6MOfsCYWxnrwQyXD42eN9JfpEmLOvbU7CbgqlcvTSOPTSJWq7kxMmJGOpZBXO16k2zugXUX+MMUEt 52NpI2/qASI3+MeQB48eUeR9voqlBZhLN7sZBjkLnLpn1/Yy3gU6rBA9qM0faJx0scQpqpg5bUeBN NVMNRm7qeyTymdQ5Zgos1knr7HZLQJpBPTtxwII4ytogIrAJPa9YMvDwQjDfoGWjBLF8SjqN5b1gT h8v5rXlzSLc5FIPLUkgtuA8FxzmIY6HbG1kl26DXinjhNJ+ePgZ9MHj0aieFauo+F0HNiRQunGnFl +rk2vdam31mxK6bbqwBBfj+LzEny3mUuvGgXLK06+naJxrSHGZUUYDSS+t6ID+UeLa/StX6NPRhRT +/2jffp4rKvjQ45OsuSsA7Ns; Received: from muradm by localhost with local (Exim 4.95) (envelope-from <mail@muradm.net>) id 1o2w4v-0007ZJ-9A for guix-patches@gnu.org; Sun, 19 Jun 2022 17:39:05 +0300 From: muradm <mail@muradm.net> Date: Sun, 19 Jun 2022 17:39:05 +0300 Message-Id: <20220619143905.29089-1-mail@muradm.net> X-Mailer: git-send-email 2.36.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=139.162.159.157; envelope-from=mail@muradm.net; helo=nomad-cl1.muradm.net X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: <guix-patches.gnu.org> List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-patches>, <mailto:guix-patches-request@gnu.org?subject=unsubscribe> List-Archive: <https://lists.gnu.org/archive/html/guix-patches> List-Post: <mailto:guix-patches@gnu.org> List-Help: <mailto:guix-patches-request@gnu.org?subject=help> List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-patches>, <mailto:guix-patches-request@gnu.org?subject=subscribe> Errors-To: guix-patches-bounces+patchwork=mira.cbaines.net@gnu.org Sender: "Guix-patches" <guix-patches-bounces+patchwork=mira.cbaines.net@gnu.org> X-getmail-retrieved-from-mailbox: Patches |
Series |
[bug#56094] gnu: Remove unnecessary sway dependency on elogind.
|
|
Commit Message
muradm
June 19, 2022, 2:39 p.m. UTC
* gnu/packages/wm.scm (sway): Cleanup dependencies. --- gnu/packages/wm.scm | 1 - 1 file changed, 1 deletion(-)
Comments
Hi,
note that "unnecessary" is quite judgmental. Why is it unnecessary?
By default, guix tends to include "optional" inputs such as elogind.
Am Sonntag, dem 19.06.2022 um 17:39 +0300 schrieb muradm:
> * gnu/packages/wm.scm (sway): Cleanup dependencies.
The ChangeLog should explicitly say what is done, i.e. (sway)[inputs]:
Remove elogind.
What exactly is the goal here? As far as I'm aware sway works either
with *logind or seatd or by having itself be setuid. If the aim is to
support seatd-based services, I think having a sway-with-seatd variant
would be better.
WDYT?
Hi, elogind/systemd was used via wlroots actually. wlroots dropped elogind/system in favour of libseat. libseat can talk to either systemd, elogind or seatd. this is already reflected in wlroots package. setuid thing you point is reflected as warning in meson.build. there is no functionality behind it as far as I know. and in 1.7 meson does not look at them directly, but via wlroots. basically informative from sway point of view. the only thing left behind is swaybar which relays on either systemd, elogind or basu for system tray functionality. this could be used as argument for keeping elogind as dependency. you may look at #49969 which added the other day seatd-service-type and greetd stuff. -- muradm Liliana Marie Prikler <liliana.prikler@ist.tugraz.at> writes: > Hi, > > note that "unnecessary" is quite judgmental. Why is it > unnecessary? > By default, guix tends to include "optional" inputs such as > elogind. > > Am Sonntag, dem 19.06.2022 um 17:39 +0300 schrieb muradm: >> * gnu/packages/wm.scm (sway): Cleanup dependencies. > The ChangeLog should explicitly say what is done, i.e. > (sway)[inputs]: > Remove elogind. > > > What exactly is the goal here? As far as I'm aware sway works > either > with *logind or seatd or by having itself be setuid. If the aim > is to > support seatd-based services, I think having a sway-with-seatd > variant > would be better. > > WDYT?
Am Montag, dem 20.06.2022 um 13:51 +0300 schrieb muradm: > the only thing left behind is swaybar which relays on > either systemd, elogind or basu for system tray functionality. > this could be used as argument for keeping elogind > as dependency. I think the way forward would be to package basu and replace elogind with it, rather than drop it and breaking swaybar. WDYT?
diff --git a/gnu/packages/wm.scm b/gnu/packages/wm.scm index d816bad871..875f73bfe2 100644 --- a/gnu/packages/wm.scm +++ b/gnu/packages/wm.scm @@ -1588,7 +1588,6 @@ (define-public sway "/bin/scdoc'"))) #t))))) (inputs (list cairo - elogind gdk-pixbuf json-c libevdev