diff mbox series

[bug#56004] gnu: Add snafu.

Message ID 20220616021931.19816-1-jgart@dismail.de
State Accepted
Headers show
Series [bug#56004] gnu: Add snafu. | expand

Checks

Context Check Description
cbaines/comparison success View comparision
cbaines/git branch success View Git branch
cbaines/applying patch success View Laminar job
cbaines/issue success View issue

Commit Message

jgart June 16, 2022, 2:19 a.m. UTC
* gnu/packages/suckless.scm (snafu): New variable.
---
 gnu/packages/suckless.scm | 32 ++++++++++++++++++++++++++++++++
 1 file changed, 32 insertions(+)

Comments

Maxim Cournoyer July 7, 2022, 8:52 p.m. UTC | #1
Hello,

jgart <jgart@dismail.de> writes:

> * gnu/packages/suckless.scm (snafu): New variable.
> ---
>  gnu/packages/suckless.scm | 32 ++++++++++++++++++++++++++++++++
>  1 file changed, 32 insertions(+)
>
> diff --git a/gnu/packages/suckless.scm b/gnu/packages/suckless.scm
> index 5aa37657b9..e05ae022df 100644
> --- a/gnu/packages/suckless.scm
> +++ b/gnu/packages/suckless.scm
> @@ -12,6 +12,7 @@
>  ;;; Copyright © 2021 Alexandru-Sergiu Marton <brown121407@posteo.ro>
>  ;;; Copyright © 2021 Nikolay Korotkiy <sikmir@disroot.org>
>  ;;; Copyright © 2022 Jai Vetrivelan <jaivetrivelan@gmail.com>
> +;;; Copyright © 2022 jgart <jgart@dismail.de>
>  ;;;
>  ;;; This file is part of GNU Guix.
>  ;;;
> @@ -32,6 +33,7 @@ (define-module (gnu packages suckless)
>    #:use-module (gnu packages)
>    #:use-module (gnu packages base)
>    #:use-module (gnu packages compression)
> +  #:use-module (gnu packages crates-io)
>    #:use-module (gnu packages cups)
>    #:use-module (gnu packages fonts)
>    #:use-module (gnu packages fontutils)
> @@ -46,6 +48,7 @@ (define-module (gnu packages suckless)
>    #:use-module (gnu packages pkg-config)
>    #:use-module (gnu packages webkit)
>    #:use-module (gnu packages xorg)
> +  #:use-module (guix build-system cargo)
>    #:use-module (guix build-system glib-or-gtk)
>    #:use-module (guix build-system gnu)
>    #:use-module (guix download)
> @@ -189,6 +192,35 @@ (define-public slstatus
>  @end itemize")
>        (license license:isc))))
>  
> +(define-public snafu
> +  (let ((commit "da0a5eea31e35aef75c698d1c01f559858c17b0d")
> +        (revision "0"))
> +    (package
> +      (name "snafu")
> +      (version commit)

You'd need write a proper monotonically increasing version via
'git-version', as hinted in info '(guix) Version Numbers'.

> +      (source
> +       (origin
> +         (method git-fetch)
> +         (uri
> +          (git-reference
> +           (url "https://github.com/jsbmg/snafu")
> +           (commit commit)))
> +         (file-name (git-file-name name version))
> +         (sha256
> +          (base32 "1wi857rdqmg4731wzgry06ndfxk8c40yyrf0whk1wlq7p0n6bd3b"))))
> +          (arguments
> +            `(#:cargo-inputs
> +              (("rust-chrono" ,rust-chrono-0.4))
> +              #:tests? #f)) ; There are no tests.
> +      (build-system cargo-build-system)
> +      (home-page "https://github.com/jsbmg/snafu")
> +      (synopsis "Status text for dwm window manager")

Fully capitalize DWM.

> +      (description
> +"@code{snafu} provides status text for dwm's builtin bar on Linux.  It

Remove "on Linux", extraneous information on GNU Guix.

> +shows battery status, battery capacity, current WIFI connection, and

The proper "acronym" capitalization is WiFi.

Could you send a revised patch?

Thanks,

Maxim
diff mbox series

Patch

diff --git a/gnu/packages/suckless.scm b/gnu/packages/suckless.scm
index 5aa37657b9..e05ae022df 100644
--- a/gnu/packages/suckless.scm
+++ b/gnu/packages/suckless.scm
@@ -12,6 +12,7 @@ 
 ;;; Copyright © 2021 Alexandru-Sergiu Marton <brown121407@posteo.ro>
 ;;; Copyright © 2021 Nikolay Korotkiy <sikmir@disroot.org>
 ;;; Copyright © 2022 Jai Vetrivelan <jaivetrivelan@gmail.com>
+;;; Copyright © 2022 jgart <jgart@dismail.de>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -32,6 +33,7 @@  (define-module (gnu packages suckless)
   #:use-module (gnu packages)
   #:use-module (gnu packages base)
   #:use-module (gnu packages compression)
+  #:use-module (gnu packages crates-io)
   #:use-module (gnu packages cups)
   #:use-module (gnu packages fonts)
   #:use-module (gnu packages fontutils)
@@ -46,6 +48,7 @@  (define-module (gnu packages suckless)
   #:use-module (gnu packages pkg-config)
   #:use-module (gnu packages webkit)
   #:use-module (gnu packages xorg)
+  #:use-module (guix build-system cargo)
   #:use-module (guix build-system glib-or-gtk)
   #:use-module (guix build-system gnu)
   #:use-module (guix download)
@@ -189,6 +192,35 @@  (define-public slstatus
 @end itemize")
       (license license:isc))))
 
+(define-public snafu
+  (let ((commit "da0a5eea31e35aef75c698d1c01f559858c17b0d")
+        (revision "0"))
+    (package
+      (name "snafu")
+      (version commit)
+      (source
+       (origin
+         (method git-fetch)
+         (uri
+          (git-reference
+           (url "https://github.com/jsbmg/snafu")
+           (commit commit)))
+         (file-name (git-file-name name version))
+         (sha256
+          (base32 "1wi857rdqmg4731wzgry06ndfxk8c40yyrf0whk1wlq7p0n6bd3b"))))
+          (arguments
+            `(#:cargo-inputs
+              (("rust-chrono" ,rust-chrono-0.4))
+              #:tests? #f)) ; There are no tests.
+      (build-system cargo-build-system)
+      (home-page "https://github.com/jsbmg/snafu")
+      (synopsis "Status text for dwm window manager")
+      (description
+"@code{snafu} provides status text for dwm's builtin bar on Linux.  It
+shows battery status, battery capacity, current WIFI connection, and
+the time in a nice format.")
+      (license license:isc))))
+
 (define-public blind
   (package
     (name "blind")