From patchwork Sat Jun 11 16:59:38 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Josselin Poiret X-Patchwork-Id: 2899 Return-Path: X-Original-To: patchwork@mira.cbaines.net Delivered-To: patchwork@mira.cbaines.net Received: by mira.cbaines.net (Postfix, from userid 113) id 2ACA027BBEA; Sat, 11 Jun 2022 18:00:38 +0100 (BST) X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on mira.cbaines.net X-Spam-Level: X-Spam-Status: No, score=-0.7 required=5.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,FROM_SUSPICIOUS_NTLD,MAILING_LIST_MULTI,PDS_OTHER_BAD_TLD, SPF_HELO_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.6 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mira.cbaines.net (Postfix) with ESMTPS id E414B27BBE9 for ; Sat, 11 Jun 2022 18:00:37 +0100 (BST) Received: from localhost ([::1]:43256 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1o04TV-0001a2-3P for patchwork@mira.cbaines.net; Sat, 11 Jun 2022 13:00:37 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:43998) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1o04Sx-0001Zp-0Z for guix-patches@gnu.org; Sat, 11 Jun 2022 13:00:03 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:59925) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1o04Sw-0006Zn-No for guix-patches@gnu.org; Sat, 11 Jun 2022 13:00:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1o04Sw-0001N2-LR for guix-patches@gnu.org; Sat, 11 Jun 2022 13:00:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#55911] [PATCH v2] channels: Print backtrace when generating package cache fails. Resent-From: Josselin Poiret Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sat, 11 Jun 2022 17:00:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 55911 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Josselin Poiret Cc: 55911@debbugs.gnu.org Received: via spool by 55911-submit@debbugs.gnu.org id=B55911.16549667845214 (code B ref 55911); Sat, 11 Jun 2022 17:00:02 +0000 Received: (at 55911) by debbugs.gnu.org; 11 Jun 2022 16:59:44 +0000 Received: from localhost ([127.0.0.1]:53822 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o04Sd-0001M2-Ua for submit@debbugs.gnu.org; Sat, 11 Jun 2022 12:59:44 -0400 Received: from jpoiret.xyz ([206.189.101.64]:36732) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o04Sb-0001Lr-JE for 55911@debbugs.gnu.org; Sat, 11 Jun 2022 12:59:42 -0400 Received: from authenticated-user (jpoiret.xyz [206.189.101.64]) by jpoiret.xyz (Postfix) with ESMTPA id 12C38184C00; Sat, 11 Jun 2022 16:59:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=jpoiret.xyz; s=dkim; t=1654966780; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Ql/D4qtkaWzVGcsfTHIzfcPdbSTudEQzs33tSEqM/p8=; b=EF5RTiunRTKDp+G2dcRiJxQqgXrAPRSwm9JE3lsix2VOJ21Vam0gEOMvaaWPgxarwycZgJ iUZt8gkFk9cSUwWMSgwvROFCLo8XxluxtGgGNIgAQHOactR8q4VcFlG3711vDFl5Qy/Gjd 4kTEkYSODS7evPMbbs4hDn9ZVZaVSyxONkPnxc30kuLsegKnS6gT/hKdUkNRERXHlnVr6Y XNUo0R6SWGt6IJJslsxabEMAhaoWwPmovhUc8Pvad+sekYbwBRWIEumhjzPD/08XgShXzA Z0DOv9ZGhJTteabz4G4KUrFcveTBV7h1Q+Pn5AeaiCh0xDCRPFR8qh6X8ARuEQ== Date: Sat, 11 Jun 2022 18:59:38 +0200 Message-Id: <20220611165938.25093-1-dev@jpoiret.xyz> In-Reply-To: <20220611163031.23673-1-dev@jpoiret.xyz> References: <20220611163031.23673-1-dev@jpoiret.xyz> MIME-Version: 1.0 Authentication-Results: jpoiret.xyz; auth=pass smtp.auth=jpoiret@jpoiret.xyz smtp.mailfrom=dev@jpoiret.xyz X-Spamd-Bar: / X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+patchwork=mira.cbaines.net@gnu.org Sender: "Guix-patches" Reply-to: Josselin Poiret X-ACL-Warn: , Josselin Poiret via Guix-patches X-Patchwork-Original-From: Josselin Poiret via Guix-patches via From: Josselin Poiret X-getmail-retrieved-from-mailbox: Patches * guix/channels.scm (package-cache-file): Add a throw handler around the generate-package-cache call, and print backtrace in it. --- IRC promptly pointed out that Guix has required Guile ver>=2 since way before guix repl and guix pull were ever a thing, thus drop the Guile 1 compatibility code. Enjoy this v2 Best, Josselin guix/channels.scm | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/guix/channels.scm b/guix/channels.scm index 20f347d34f..fde425327d 100644 --- a/guix/channels.scm +++ b/guix/channels.scm @@ -911,7 +911,14 @@ (define build (format (current-error-port) "Generating package cache for '~a'...~%" #$profile) - (generate-package-cache #$output)) + ;; This script runs through (primitive-load), which by default + ;; doesn't print backtraces when it encounters an exception, + ;; so manually do it. Use with-throw-handler because it is + ;; supported by all Guile versions. + (with-throw-handler #t + (lambda () (generate-package-cache #$output)) + (lambda (key . args) + (backtrace)))) (mkdir #$output)))) (gexp->derivation-in-inferior "guix-package-cache" build