| Message ID | 20220517014845.10441-2-luishenriquegh2701@gmail.com |
|---|---|
| State | Accepted |
| Headers | show |
| Series | [bug#55466,v2,1/2] gnu: emacs-racer: Update to 1e63e98. | expand |
| Context | Check | Description |
|---|---|---|
| cbaines/comparison | success | View comparision |
| cbaines/git branch | success | View Git branch |
| cbaines/applying patch | success | View Laminar job |
| cbaines/issue | success | View issue |
Hello, Luis Henrique Gomes Higino <luishenriquegh2701@gmail.com> writes: > (package > (name "emacs-explain-pause-mode") > - (version (git-version "0.1" revision commit)) > + (version (git-version "0.2" revision commit)) I removed this ninja version bump. The main file still references "0.1". Regards,
Hi Nicolas, thanks for your feedback and for enhancing my patches before applying them! I just have one question: Nicolas Goaziou <mail@nicolasgoaziou.fr> writes: > Hello, > > Luis Henrique Gomes Higino <luishenriquegh2701@gmail.com> > writes: > >> (package >> (name "emacs-explain-pause-mode") >> - (version (git-version "0.1" revision commit)) >> + (version (git-version "0.2" revision commit)) > > I removed this ninja version bump. The main file still > references "0.1". > > Regards, That's funny, because in the README [0] it says the development version is 0.2, that's why I bumped it. Which should we use? 0: https://github.com/lastquestion/explain-pause-mode/blob/master/README.md#explain-pause-mode Regards,
Luis Henrique Gomes Higino <luishenriquegh2701@gmail.com> writes: > That's funny, because in the README [0] it says the development > version is 0.2, that's why I bumped it. Which should we use? We usually refer to the Version keyword in main file when there is no tag. Note that (git-version "0.2" revision commit) is actually a greater version than "0.2", so it could be confusing when "0.2" is eventually released.
Nicolas Goaziou <mail@nicolasgoaziou.fr> writes: > Luis Henrique Gomes Higino <luishenriquegh2701@gmail.com> > writes: > >> That's funny, because in the README [0] it says the development >> version is 0.2, that's why I bumped it. Which should we use? > > We usually refer to the Version keyword in main file when there > is no > tag. Note that (git-version "0.2" revision commit) is actually a > greater > version than "0.2", so it could be confusing when "0.2" is > eventually > released. Makes sense, thanks again Nicolas! Regards,
diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm index c8a19e5e9e..6dfb1ea3a1 100644 --- a/gnu/packages/emacs-xyz.scm +++ b/gnu/packages/emacs-xyz.scm @@ -4709,7 +4709,7 @@ (define-public emacs-explain-pause-mode (revision "0")) (package (name "emacs-explain-pause-mode") - (version (git-version "0.1" revision commit)) + (version (git-version "0.2" revision commit)) (source (origin (method git-fetch) @@ -4724,6 +4724,13 @@ (define-public emacs-explain-pause-mode (list emacs-buttercup)) (arguments '(#:tests? #t + #:phases + (modify-phases %standard-phases + ;; This causes the byte-compilation before unit-tests to fail + (add-after 'unpack 'remove-error-on-warn + (lambda _ + (substitute* "Makefile" + (("--eval '\\(setq byte-compile-error-on-warn t\\)'") ""))))) ;; Don't run case-tests as they will fail to create sockets because ;; the path is too long #:test-command '("make" "byte-compile" "unit-tests")
From: luishgh <51053603+luishgh@users.noreply.github.com> * gnu/packages/emacs-xyz.scm (emacs-explain-pause-mode): Fix failing tests. --- gnu/packages/emacs-xyz.scm | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-)