From patchwork Sun May 15 04:36:33 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Maxim Cournoyer X-Patchwork-Id: 39277 Return-Path: X-Original-To: patchwork@mira.cbaines.net Delivered-To: patchwork@mira.cbaines.net Received: by mira.cbaines.net (Postfix, from userid 113) id 334A927BBEA; Sun, 15 May 2022 05:48:54 +0100 (BST) X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on mira.cbaines.net X-Spam-Level: X-Spam-Status: No, score=-2.7 required=5.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FROM,MAILING_LIST_MULTI, SPF_HELO_PASS autolearn=unavailable autolearn_force=no version=3.4.6 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mira.cbaines.net (Postfix) with ESMTPS id F0A0027BBE9 for ; Sun, 15 May 2022 05:48:53 +0100 (BST) Received: from localhost ([::1]:49026 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nq6BZ-0003Xw-4V for patchwork@mira.cbaines.net; Sun, 15 May 2022 00:48:53 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:42056) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nq6Al-0002x7-BR for guix-patches@gnu.org; Sun, 15 May 2022 00:48:04 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:54062) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nq6Ak-0004e9-PR for guix-patches@gnu.org; Sun, 15 May 2022 00:48:03 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1nq6Ak-000323-Mv for guix-patches@gnu.org; Sun, 15 May 2022 00:48:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#55424] [PATCH 006/602] diagnostics: Fix typo about 0-indexed COL in location. Resent-From: Maxim Cournoyer Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sun, 15 May 2022 04:48:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 55424 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 55424@debbugs.gnu.org Cc: Maxim Cournoyer Received: via spool by 55424-submit@debbugs.gnu.org id=B55424.165259002411150 (code B ref 55424); Sun, 15 May 2022 04:48:02 +0000 Received: (at 55424) by debbugs.gnu.org; 15 May 2022 04:47:04 +0000 Received: from localhost ([127.0.0.1]:47868 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nq69n-0002td-SC for submit@debbugs.gnu.org; Sun, 15 May 2022 00:47:04 -0400 Received: from mail-qt1-f179.google.com ([209.85.160.179]:36794) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nq69l-0002sJ-LI for 55424@debbugs.gnu.org; Sun, 15 May 2022 00:47:01 -0400 Received: by mail-qt1-f179.google.com with SMTP id v14so8915005qtc.3 for <55424@debbugs.gnu.org>; Sat, 14 May 2022 21:47:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=yCi/Qk9hl6b16xy8siHvn+eZN3tbeXHMXIQcKUyE8gc=; b=ewwG7eJlS0R+r5odsTmvDA8B6xyWzEiaQp0U7oAwiaGyIogvj1LswTr0As+HVwsVTg RjGAdJwkMy994cWDMhpmVAtAWFUfU7Toh38Z2L6uWymSqhXGeReNdj/K2QLCrYpXsnLI xbJUGjDpn3fyfXsn7q05k4IkRkeVw6INnNtscWRkNmdOA4nnTUaSJEfyKOJXDBN5JPpT VyaXYGifJZALBiN9onV8dERcVTmzxgcW2+/FEVDn08jTfCPPdXkC04hptcOEoheqSKQm Jqwg4CAEta0GcyViTaL1vqUJ3xbfmhxTSyKU4/+pt5x94xHUdWJXzCCC9UwJA1mz91L8 uR5w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=yCi/Qk9hl6b16xy8siHvn+eZN3tbeXHMXIQcKUyE8gc=; b=Gnek/51S4iUX2kngQ2gS0Yg8gLZvV8oRkK8Fe/jDtdFl5oTjCfRHSkouLLeLpwgk4C wvRjpXfOoQnpfLmiGDaVXI9MFWbzBr2uEiWFDI+6Jv7GbyTvs72izlp2SZIAEN8lCGoI MFHT0tQXYN6fiI2RhGy21iWYUIPLVwl37fkrjtqpY9T8+2fbbcbi571dr7OB/Qv/30n5 aPS0/oRRLQldkDnQwBpVVSELLFO2M5qV+gmdm849mjwVj+Q8udRg7dvhAk7QuUC6g5Nw HAaYzO+Rkq69Cr3WBzArpRT3ZKF463K79PDIWE0pTsWYgfRrne2+XdhhlBMSxQDdu7gz 8tcQ== X-Gm-Message-State: AOAM532/3AgFgX+VVNFYpBtvdhol31cJuvYnu8P4EdLPUt0RT/rQBsXh 1Je7Z3UlBLZ/Pl0mOjrtUJvXJMqog/bAmQ== X-Google-Smtp-Source: ABdhPJz1GgYl7C6kekKEUoC0fqANNlm4Gfn05g624xWRFnyNXw24MCYz6n2DdGxw1iMXAGcxqRdbYg== X-Received: by 2002:a05:622a:13ca:b0:2f3:b1ac:48f5 with SMTP id p10-20020a05622a13ca00b002f3b1ac48f5mr11157298qtk.125.1652590016095; Sat, 14 May 2022 21:46:56 -0700 (PDT) Received: from localhost.localdomain (dsl-149-239.b2b2c.ca. [66.158.149.239]) by smtp.gmail.com with ESMTPSA id 2-20020ac82082000000b002f39b99f672sm4287690qtd.12.2022.05.14.21.46.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 14 May 2022 21:46:55 -0700 (PDT) From: Maxim Cournoyer Date: Sun, 15 May 2022 00:36:33 -0400 Message-Id: <20220515044629.6843-6-maxim.cournoyer@gmail.com> X-Mailer: git-send-email 2.36.0 In-Reply-To: <20220515044629.6843-1-maxim.cournoyer@gmail.com> References: <20220515044629.6843-1-maxim.cournoyer@gmail.com> MIME-Version: 1.0 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+patchwork=mira.cbaines.net@gnu.org Sender: "Guix-patches" X-getmail-retrieved-from-mailbox: Patches * guix/diagnostics.scm (source-properties->location): The location column is 0-indexed, not 1-indexed (the same as in source-properties, so the code is accurate). --- guix/diagnostics.scm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/guix/diagnostics.scm b/guix/diagnostics.scm index bf1ced8140..9f0d558f2f 100644 --- a/guix/diagnostics.scm +++ b/guix/diagnostics.scm @@ -232,7 +232,7 @@ (define (source-properties->location loc) by Guile's `source-properties', `frame-source', `current-source-location', etc." ;; In accordance with the GCS, start line and column numbers at 1. Note - ;; that unlike LINE and `port-column', COL is actually 1-indexed here... + ;; that unlike LINE and `port-column', COL is actually 0-indexed here... (match loc ((('line . line) ('column . col) ('filename . file)) ;common case (and file line col