| Message ID | 20220428171109.217461-2-paul@apatience.com |
|---|---|
| State | Accepted |
| Headers | show |
| Series | gnu: sundials: Fix various issues and update to 6.2.0. | expand |
| Context | Check | Description |
|---|---|---|
| cbaines/comparison | success | View comparision |
| cbaines/git branch | success | View Git branch |
| cbaines/applying patch | success | View Laminar job |
| cbaines/issue | success | View issue |
| cbaines/comparison | success | View comparision |
| cbaines/git branch | success | View Git branch |
| cbaines/applying patch | success | View Laminar job |
| cbaines/issue | success | View issue |
Paul A. Patience schreef op do 28-04-2022 om 17:11 [+0000]:
> + (list hdf5-parallel-openmpi)) ; petsclayouthdf5.h includes H5Ipublic.h.
This can be solved without propagation, see
<https://issues.guix.gnu.org/54780#18>
and <https://issues.guix.gnu.org/54780#19>.
Greetings,
Maxime.
On 2022-04-30 05:02:55-04:00, Maxime Devos wrote: > Paul A. Patience schreef op do 28-04-2022 om 17:11 [+0000]: >> + (list hdf5-parallel-openmpi)) ; petsclayouthdf5.h includes H5Ipublic.h. > > This can be solved without propagation, see > <https://issues.guix.gnu.org/54780#18> > and <https://issues.guix.gnu.org/54780#19>. I fixed this in v3 for petsc-openmpi, but note that one of the issues fixed in the sundials-openmpi package (patch 2/4) is moving some dependencies from inputs to propagated inputs to fix header inclusions. However, those inputs would be more fragile to fix manually than petsc-openmpi, because there are more headers to deal with than in petsc-openmpi, and so they should probably be fixed only when the absolute-inclusions patch is merged. There are probably many other instances of this; I know that at least dealii has propagated inputs just because of header inclusions. If the absolute-inclusions patch is merged soon, I could update this patch series to use that, but otherwise it could be fixed in a future update to sundials (which seems to happen often). Best regards, Paul
diff --git a/gnu/packages/maths.scm b/gnu/packages/maths.scm index fcd9c5482f..593bb4651c 100644 --- a/gnu/packages/maths.scm +++ b/gnu/packages/maths.scm @@ -3139,14 +3139,15 @@ (define-public petsc-openmpi (name "petsc-openmpi") (inputs (modify-inputs (package-inputs petsc) - (prepend hdf5-parallel-openmpi - hypre-openmpi + (prepend hypre-openmpi metis mumps-openmpi openmpi scalapack pt-scotch32 `(,pt-scotch32 "metis")))) + (propagated-inputs + (list hdf5-parallel-openmpi)) ; petsclayouthdf5.h includes H5Ipublic.h. (arguments (substitute-keyword-arguments (package-arguments petsc) ((#:configure-flags cf)