From patchwork Fri Apr 8 13:22:43 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Simon Tournier X-Patchwork-Id: 38399 Return-Path: X-Original-To: patchwork@mira.cbaines.net Delivered-To: patchwork@mira.cbaines.net Received: by mira.cbaines.net (Postfix, from userid 113) id E20CD27BBEA; Fri, 8 Apr 2022 14:26:27 +0100 (BST) X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on mira.cbaines.net X-Spam-Level: X-Spam-Status: No, score=-2.7 required=5.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FROM,MAILING_LIST_MULTI, SPF_HELO_PASS autolearn=unavailable autolearn_force=no version=3.4.6 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mira.cbaines.net (Postfix) with ESMTPS id 5FE8F27BBE9 for ; Fri, 8 Apr 2022 14:26:27 +0100 (BST) Received: from localhost ([::1]:33076 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ncod8-0005bt-F5 for patchwork@mira.cbaines.net; Fri, 08 Apr 2022 09:26:26 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:57112) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ncoap-0002Mb-6P for guix-patches@gnu.org; Fri, 08 Apr 2022 09:24:04 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:40391) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1ncoao-0001Ps-UT for guix-patches@gnu.org; Fri, 08 Apr 2022 09:24:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1ncoao-0007sA-RU for guix-patches@gnu.org; Fri, 08 Apr 2022 09:24:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#53882] [PATCH v2 03/25] import: opam: Factor out source import. Resent-From: zimoun Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Fri, 08 Apr 2022 13:24:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 53882 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 53882@debbugs.gnu.org Cc: Julien Lepiller Received: via spool by 53882-submit@debbugs.gnu.org id=B53882.164942421729991 (code B ref 53882); Fri, 08 Apr 2022 13:24:02 +0000 Received: (at 53882) by debbugs.gnu.org; 8 Apr 2022 13:23:37 +0000 Received: from localhost ([127.0.0.1]:34228 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ncoaO-0007nR-Qn for submit@debbugs.gnu.org; Fri, 08 Apr 2022 09:23:37 -0400 Received: from mail-wm1-f49.google.com ([209.85.128.49]:44813) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ncoaK-0007lq-OH for 53882@debbugs.gnu.org; Fri, 08 Apr 2022 09:23:33 -0400 Received: by mail-wm1-f49.google.com with SMTP id v20-20020a05600c15d400b0038e9a88aee7so2390202wmf.3 for <53882@debbugs.gnu.org>; Fri, 08 Apr 2022 06:23:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=BUJtkYFdetVaPu6l8TfFFtPl0IRzAI6UAoMdeWnnqFI=; b=GvH3IAxhlMATlgi5aHlpmd0ZIHOM/BUgMiiN4wiMfdJaKHKxGT4JB0+MFwPdiBII2j 2oblEa0waF8HH1z5apw+IPlEUQyWuiOjA64W57yPlftP4LgAsbVzaywr+h/L6n2cCkmM 0cWRYIPR9JK/5RDBRiafEjxjBKop3+GikPrsF2RC0vHWQz2IkxN5kiJqJzbRtJjY+dC/ q+TIdzFC9xjFJ+Enp5Lywi7B6y7IiRCyWNigbv1sxpG0GjBcdyfDs3SKcq8O3alYAIob numzx38HbL3ndnTtj7G2WYFF2pvKO+dqAX81t1boUQlztWEAcGOH1lRLs012a0cYef7H dAtA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=BUJtkYFdetVaPu6l8TfFFtPl0IRzAI6UAoMdeWnnqFI=; b=FDPjFs4OfEKze5Y8ZuUTnyYPGv5b+nteMpb7VdZlsbu/7S05ChHwlFVDcEjRX76Vd3 yPWscSWPOrFwRRHK/D4Nxf/hYGXfK7NezCIDzR5b894ykt7FL7QPv2EJ9arZCFja6Tx2 tlVLSCxPclbZP/w1RESVaZpg+TxOD1ef+xsHdGxNjuRg7M9+IOH0TLUvso3b3sewygbK OZHfM2Nb+Wgh2Go5emTDHEoEt1856DmLZvpKJ+MsQaothlnhs2/fmLs8CWjBqybCS9AJ Of05qmKV2hqUPEn2XhJjA8YiP0g/e+oBXyuE9Iu94CdySFqUWfyhIk3ceRK+F28bh5dE trOA== X-Gm-Message-State: AOAM530c4cnhmW3Kc+QT/7hJPKsIxMwGngGUkNXdko3D7ma1U61IKzyV LxmPaleW/BprZ+HAtXR/NdQhE0VOHHU= X-Google-Smtp-Source: ABdhPJyokck7FkX40ojzOKikwyETUG0EuB+DQjwkxTI8t8mgv6juS1A94wKKVBPIC4EScvTUfkLwlQ== X-Received: by 2002:a05:600c:d8:b0:38e:785a:2fc7 with SMTP id u24-20020a05600c00d800b0038e785a2fc7mr17019251wmm.59.1649424207151; Fri, 08 Apr 2022 06:23:27 -0700 (PDT) Received: from localhost.localdomain ([193.48.40.241]) by smtp.gmail.com with ESMTPSA id z3-20020a1cf403000000b0037d1f4a2201sm10108954wma.21.2022.04.08.06.23.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 08 Apr 2022 06:23:26 -0700 (PDT) From: zimoun Date: Fri, 8 Apr 2022 15:22:43 +0200 Message-Id: <20220408132305.3301350-3-zimon.toutoune@gmail.com> X-Mailer: git-send-email 2.34.0 In-Reply-To: <20220408132305.3301350-1-zimon.toutoune@gmail.com> References: <20220408132305.3301350-1-zimon.toutoune@gmail.com> MIME-Version: 1.0 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+patchwork=mira.cbaines.net@gnu.org Sender: "Guix-patches" X-getmail-retrieved-from-mailbox: Patches From: Julien Lepiller This also ensures a package can be imported even when it does not specify a URL. * guix/import/opam.scm (opam->guix-source): New procedure. (opam->guix-package): Use it. --- guix/import/opam.scm | 81 +++++++++++++++++++++++--------------------- 1 file changed, 43 insertions(+), 38 deletions(-) diff --git a/guix/import/opam.scm b/guix/import/opam.scm index f51d17dea4..b4b5a6eaad 100644 --- a/guix/import/opam.scm +++ b/guix/import/opam.scm @@ -324,6 +324,20 @@ (define* (opam-fetch name #:optional (repositories-specs '("opam"))) (filter-map get-opam-repository repositories-specs)) (warning (G_ "opam: package '~a' not found~%") name))) +(define (opam->guix-source url-dict) + (let ((source-url (and url-dict + (or (metadata-ref url-dict "src") + (metadata-ref url-dict "archive"))))) + (if source-url + (call-with-temporary-output-file + (lambda (temp port) + (and (url-fetch source-url temp) + `(origin + (method url-fetch) + (uri ,source-url) + (sha256 (base32 ,(guix-hash-url temp))))))) + 'no-source-information))) + (define* (opam->guix-package name #:key (repo 'opam) version) "Import OPAM package NAME from REPOSITORY (a directory name) or, if REPOSITORY is #f, from the official OPAM repository. Return a 'package' sexp @@ -332,9 +346,7 @@ (define* (opam->guix-package name #:key (repo 'opam) version) (opam-file (opam-fetch name with-opam)) (version (assoc-ref opam-file "version")) (opam-content (assoc-ref opam-file "metadata")) - (url-dict (metadata-ref opam-content "url")) - (source-url (or (metadata-ref url-dict "src") - (metadata-ref url-dict "archive"))) + (source (opam->guix-source (metadata-ref opam-content "url"))) (requirements (metadata-ref opam-content "depends")) (names (dependency-list->names requirements)) (dependencies (filter-dependencies names)) @@ -348,41 +360,34 @@ (define* (opam->guix-package name #:key (repo 'opam) version) (not (member name '("dune" "jbuilder")))) native-dependencies)))) (let ((use-dune? (member "dune" names))) - (call-with-temporary-output-file - (lambda (temp port) - (and (url-fetch source-url temp) - (values - `(package - (name ,(ocaml-name->guix-name name)) - (version ,version) - (source - (origin - (method url-fetch) - (uri ,source-url) - (sha256 (base32 ,(guix-hash-url temp))))) - (build-system ,(if use-dune? - 'dune-build-system - 'ocaml-build-system)) - ,@(if (null? inputs) - '() - `((propagated-inputs (list ,@inputs)))) - ,@(if (null? native-inputs) - '() - `((native-inputs (list ,@native-inputs)))) - ,@(if (equal? name (guix-name->opam-name (ocaml-name->guix-name name))) - '() - `((properties - ,(list 'quasiquote `((upstream-name . ,name)))))) - (home-page ,(metadata-ref opam-content "homepage")) - (synopsis ,(metadata-ref opam-content "synopsis")) - (description ,(beautify-description - (metadata-ref opam-content "description"))) - (license ,(spdx-string->license - (metadata-ref opam-content "license")))) - (filter - (lambda (name) - (not (member name '("dune" "jbuilder")))) - dependencies)))))))) + (values + `(package + (name ,(ocaml-name->guix-name name)) + (version ,version) + (source ,source) + (build-system ,(if use-dune? + 'dune-build-system + 'ocaml-build-system)) + ,@(if (null? inputs) + '() + `((propagated-inputs (list ,@inputs)))) + ,@(if (null? native-inputs) + '() + `((native-inputs (list ,@native-inputs)))) + ,@(if (equal? name (guix-name->opam-name (ocaml-name->guix-name name))) + '() + `((properties + ,(list 'quasiquote `((upstream-name . ,name)))))) + (home-page ,(metadata-ref opam-content "homepage")) + (synopsis ,(metadata-ref opam-content "synopsis")) + (description ,(beautify-description + (metadata-ref opam-content "description"))) + (license ,(spdx-string->license + (metadata-ref opam-content "license")))) + (filter + (lambda (name) + (not (member name '("dune" "jbuilder")))) + dependencies))))) (define* (opam-recursive-import package-name #:key repo) (recursive-import package-name