From patchwork Fri Apr 1 15:01:46 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: =?utf-8?q?Ludovic_Court=C3=A8s?= X-Patchwork-Id: 38268 Return-Path: X-Original-To: patchwork@mira.cbaines.net Delivered-To: patchwork@mira.cbaines.net Received: by mira.cbaines.net (Postfix, from userid 113) id 4919D27BBEA; Fri, 1 Apr 2022 16:08:06 +0100 (BST) X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on mira.cbaines.net X-Spam-Level: X-Spam-Status: No, score=-2.7 required=5.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,MAILING_LIST_MULTI,SPF_HELO_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.6 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mira.cbaines.net (Postfix) with ESMTPS id 104DD27BBE9 for ; Fri, 1 Apr 2022 16:08:06 +0100 (BST) Received: from localhost ([::1]:58378 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1naIsf-0000TG-6A for patchwork@mira.cbaines.net; Fri, 01 Apr 2022 11:08:05 -0400 Received: from eggs.gnu.org ([209.51.188.92]:45524) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1naInm-0000kV-O7 for guix-patches@gnu.org; Fri, 01 Apr 2022 11:03:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:49169) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1naInm-00063K-FS for guix-patches@gnu.org; Fri, 01 Apr 2022 11:03:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1naInm-0002rW-D8 for guix-patches@gnu.org; Fri, 01 Apr 2022 11:03:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#54668] [PATCH 3/3] diagnostics: Turn diagnostic locations into hyperlinks. Resent-From: Ludovic =?utf-8?q?Court=C3=A8s?= Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Fri, 01 Apr 2022 15:03:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 54668 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 54668@debbugs.gnu.org Cc: Ludovic =?utf-8?q?Court=C3=A8s?= Received: via spool by 54668-submit@debbugs.gnu.org id=B54668.164882532410898 (code B ref 54668); Fri, 01 Apr 2022 15:03:02 +0000 Received: (at 54668) by debbugs.gnu.org; 1 Apr 2022 15:02:04 +0000 Received: from localhost ([127.0.0.1]:43057 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1naImq-0002pd-GT for submit@debbugs.gnu.org; Fri, 01 Apr 2022 11:02:04 -0400 Received: from eggs.gnu.org ([209.51.188.92]:57580) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1naImo-0002od-Ky for 54668@debbugs.gnu.org; Fri, 01 Apr 2022 11:02:02 -0400 Received: from [2001:470:142:3::e] (port=54948 helo=fencepost.gnu.org) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1naImj-0005uM-C9; Fri, 01 Apr 2022 11:01:57 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:References:In-Reply-To:Date:Subject:To: From; bh=t2nOHOuCrjPcN/1u0JP7Nhz51Y+XNnAyLNAScfRluvE=; b=FunJ22EqKb2zb6a07TdV dyY9vFbL8S1w+lI9R5GI6dLEJYDcclvxp2mB+ckTOffmf1ewqWGVUJ8B7lSCuj1FCpxj4TgxJ0JT+ pKcIoLhKdSBiJjD1M3GN6B5561ogxNCZYhFOnQRr5kUnJm23jlTfNunmYDuXB7NheJgolRvJvFumI WBYGsr8XPnUd1tCMlc/AXALJV3EiY6h3AnuYS8Suri+XuSFmM0qNmy8h6iejrdfXLqzAsBwac7W8H Fg5F1xfGlNxZ9siJcNDcg3oshSPQv7C2GRti3Pt8FZx7a9WJZLF58N66BtGlY8Hh3Iakvf1rKKqr1 CtnHgjV2yD/dJg==; Received: from [2001:660:6102:320:e120:2c8f:8909:cdfe] (port=38740 helo=gnu.org) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1naImi-0005LG-VW; Fri, 01 Apr 2022 11:01:57 -0400 From: Ludovic =?utf-8?q?Court=C3=A8s?= Date: Fri, 1 Apr 2022 17:01:46 +0200 Message-Id: <20220401150146.32529-3-ludo@gnu.org> X-Mailer: git-send-email 2.34.0 In-Reply-To: <20220401150146.32529-1-ludo@gnu.org> References: <20220401150146.32529-1-ludo@gnu.org> MIME-Version: 1.0 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+patchwork=mira.cbaines.net@gnu.org Sender: "Guix-patches" X-getmail-retrieved-from-mailbox: Patches * guix/diagnostics.scm (print-diagnostic-prefix): Use 'location->hyperlink' when 'supports-hyperlinks?' returns true. --- guix/diagnostics.scm | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/guix/diagnostics.scm b/guix/diagnostics.scm index 2b8cee1ccb..bf1ced8140 100644 --- a/guix/diagnostics.scm +++ b/guix/diagnostics.scm @@ -204,7 +204,10 @@ (define prefix-color (gettext prefix %gettext-domain)))) (if location (format (guix-warning-port) "~a: ~a" - (location-color (location->string location)) + (location-color + (if (supports-hyperlinks? (guix-warning-port)) + (location->hyperlink location) + (location->string location))) (prefix-color prefix)) (format (guix-warning-port) "~:[~*~;guix ~a: ~]~a" (program-name) (program-name)