| Message ID | 20220322224614.5605-1-yewscion@gmail.com |
|---|---|
| State | Accepted |
| Headers | show |
| Series | [bug#54529] Added orca-lang package | expand |
Hello all, Just want to confirm if this is waiting on me for anything. Trying to stay on top of the issues I'm opening, as I'm planning to open more soon and don't want to pollute the queue with a bunch of forgotten issues. Is there anything else that needs done from my end concerning the above patch? Thanks for Your time! -- Christopher Rodriguez
Christopher Rodriguez <yewscion@gmail.com> writes: > [[PGP Signed Part:Undecided]] > Hello all, > > Just want to confirm if this is waiting on me for anything. Trying to stay on > top of the issues I'm opening, as I'm planning to open more soon and don't want > to pollute the queue with a bunch of forgotten issues. > > Is there anything else that needs done from my end concerning the above patch? > > Thanks for Your time! I've been overwhelmed with other things, but I did try the patch out and it did work great. Then I got overwhelmed again. ;P I think I made a suggestion about the moving the binary name after install bit. Did you / could you give that a try?
Christine Lemmer-Webber <cwebber@dustycloud.org> writes: > Christopher Rodriguez <yewscion@gmail.com> writes: > >> [[PGP Signed Part:Undecided]] >> Hello all, >> >> Just want to confirm if this is waiting on me for anything. Trying to stay on >> top of the issues I'm opening, as I'm planning to open more soon and don't want >> to pollute the queue with a bunch of forgotten issues. >> >> Is there anything else that needs done from my end concerning the above patch? >> >> Thanks for Your time! > > I've been overwhelmed with other things, but I did try the patch out and > it did work great. Then I got overwhelmed again. ;P > > I think I made a suggestion about the moving the binary name after > install bit. Did you / could you give that a try? Hi Christine! I did give it a try, and it worked! I actually decided to do it after the build step, before the install. The above patch should have the updated version, though I do notice now (upon reading through it again) that it includes a rather large section I had commented out during debugging. I'll remove that and send a revised patch tonight; With the package name issue out of the way I believe this /should/ be ready to merge. -- Christopher Rodriguez
Hello! Checking in on this again. If you give an updated version of the patch, it can be merged I think. With the commented out part, I'm uncertain whether or not it was commented out because it's no longer needed or because it was but you were debugging, based on what you've said so that's the main concern I have. Could you also use git format-patch for the next version you send? That'll make it easy to apply! Thanks! Sorry for the delays on this review cycle! It's busy here. - Christine Christopher Rodriguez <yewscion@gmail.com> writes: > [[PGP Signed Part:Undecided]] > > Christine Lemmer-Webber <cwebber@dustycloud.org> writes: > >> Christopher Rodriguez <yewscion@gmail.com> writes: >> >>> [[PGP Signed Part:Undecided]] >>> Hello all, >>> >>> Just want to confirm if this is waiting on me for anything. Trying to stay on >>> top of the issues I'm opening, as I'm planning to open more soon and don't want >>> to pollute the queue with a bunch of forgotten issues. >>> >>> Is there anything else that needs done from my end concerning the above patch? >>> >>> Thanks for Your time! >> >> I've been overwhelmed with other things, but I did try the patch out and >> it did work great. Then I got overwhelmed again. ;P >> >> I think I made a suggestion about the moving the binary name after >> install bit. Did you / could you give that a try? > > Hi Christine! > > I did give it a try, and it worked! I actually decided to do it after > the build step, before the install. > > The above patch should have the updated version, though I do notice now > (upon reading through it again) that it includes a rather large section > I had commented out during debugging. > > I'll remove that and send a revised patch tonight; With the package name issue > out of the way I believe this /should/ be ready to merge.
Christine Lemmer-Webber <cwebber@dustycloud.org> writes: > Hello! Checking in on this again. Hi Christine! > If you give an updated version of the patch, it can be merged I think. > With the commented out part, I'm uncertain whether or not it was > commented out because it's no longer needed or because it was but you > were debugging, based on what you've said so that's the main concern I > have. I will rebase the patch on a new pull of guix from git, clean it up, and send it here within the next hour or so. That way, I'll be sure that it still works with all of the changes since then and now. > Could you also use git format-patch for the next version you send? > That'll make it easy to apply! Between my last comment and now I've become used to the `git send-email` style workflow. Is that what You are asking for? If not, let me know and I will send a patch in the preferred format ASAP. > Thanks! Sorry for the delays on this review cycle! It's busy here. No worries! Frankly, looking at the number and depth of the commits that GNU Guix gets on a daily basis, I'm very impressed with the speed with which our maintainers work! Thank You all for Your efforts; they are very appreciated! > - Christine
Christopher Rodriguez <yewscion@gmail.com> writes: > [[PGP Signed Part:Undecided]] > > Christine Lemmer-Webber <cwebber@dustycloud.org> writes: > >> Hello! Checking in on this again. > > Hi Christine! > >> If you give an updated version of the patch, it can be merged I think. >> With the commented out part, I'm uncertain whether or not it was >> commented out because it's no longer needed or because it was but you >> were debugging, based on what you've said so that's the main concern I >> have. > > I will rebase the patch on a new pull of guix from git, clean it up, and > send it here within the next hour or so. That way, I'll be sure that it > still works with all of the changes since then and now. Awesome! >> Could you also use git format-patch for the next version you send? >> That'll make it easy to apply! > > Between my last comment and now I've become used to the `git send-email` > style workflow. Is that what You are asking for? If not, let me know and > I will send a patch in the preferred format ASAP. Yep, that's what i mean :) >> Thanks! Sorry for the delays on this review cycle! It's busy here. > > No worries! Frankly, looking at the number and depth of the commits that > GNU Guix gets on a daily basis, I'm very impressed with the speed with > which our maintainers work! Thank You all for Your efforts; they are > very appreciated! > >> - Christine I'm not a maintainer, and not nearly often enough a reviewer (or contributor), but I agree :)
diff --git a/gnu/packages/music.scm b/gnu/packages/music.scm index 9c8203aa80..32ab263f84 100644 --- a/gnu/packages/music.scm +++ b/gnu/packages/music.scm @@ -6879,3 +6879,63 @@ (define-public musikcube streaming audio server.") (home-page "https://musikcube.com/") (license license:bsd-3))) +(define-public orca-lang + (let ((commit "5ba56ca67baae3db140f8b7a2b2fc46bbac5602f") + (revision "4")) + (package + (name "orca-lang") + (version (git-version "git" revision commit)) + (source (origin + (method git-fetch) + (uri (git-reference + (url "https://git.sr.ht/~rabbits/orca") + (commit commit))) + (file-name (git-file-name name version)) + (sha256 + (base32 + "1mnhk68slc6g5y5348vj86pmnz90a385jxvm3463fic79k90gckd")))) + (build-system gnu-build-system) + (arguments + `(#:tests? + #f + #:phases + (modify-phases + %standard-phases + (delete 'configure) + (delete 'check) + (delete 'patch-shebangs) + (delete 'validate-documentation-location) + (delete 'delete-info-dir-file) + (delete 'patch-dot-desktop-files) + (delete 'reset-gzip-timestamps) + (replace 'build + (lambda* (#:key inputs outputs #:allow-other-keys) + (setenv "CC" "gcc") + (invoke "make" "release"))) + (replace 'install + (lambda* (#:key outputs #:allow-other-keys) + (let* ((out + (assoc-ref outputs "out")) + (dest-bin + (string-append out "/bin")) + (dest-lib + (string-append out "/share")) + (dest-exa + (string-append dest-lib "/examples")) + (dest-doc + (string-append dest-lib "/doc"))) + (install-file "./build/orca" dest-bin) + (copy-recursively "./examples" dest-exa) + (install-file "./README.md" dest-doc) + #t)))))) + (inputs `(("ncurses" ,ncurses) + ("portmidi" ,portmidi))) + (native-inputs `(("pkg-config" ,pkg-config))) + (synopsis "Musical Esoteric Programming Language") + (description + "Orca is an esoteric programming language and live editor designed to +quickly create procedural sequencers. Every letter of the alphabet is an +operation, lowercase letters execute on *bang*, and uppercase letters execute +each frame.") + (home-page "https://wiki.xxiivv.com/site/uxn.html") + (license license:agpl3))))