diff mbox series

[bug#54460,v2] gnu: sbcl-printv: Update to e717a7f.

Message ID 20220319074735.27780-1-jgart@dismail.de
State Accepted
Headers show
Series [bug#54460,v2] gnu: sbcl-printv: Update to e717a7f. | expand

Checks

Context Check Description
cbaines/comparison success View comparision
cbaines/git branch success View Git branch
cbaines/applying patch success View Laminar job
cbaines/issue success View issue

Commit Message

jgart March 19, 2022, 7:47 a.m. UTC 
* gnu/packages/lisp-xyz.scm (sbcl-printv): Update to e717a7f.
[inputs]: Add missing figlet input.
[arguments]: Patch figlet executable.

Hi,

Here is v2.

I discovered that sbcl-printv calls figlet so I patched figlet.

all best,

jgart

---
 gnu/packages/lisp-xyz.scm | 16 +++++++++++++---
 1 file changed, 13 insertions(+), 3 deletions(-)

Comments

M March 19, 2022, 9:58 a.m. UTC | #1 
jgart via Guix-patches via schreef op za 19-03-2022 om 03:47 [-0400]:
> +         (modify-phases %standard-phases
> +           (add-after 'unpack 'patch-figlet-executable
> +             (lambda* (#:key inputs #:allow-other-keys)
> +               (substitute* "printv.lisp"
> +                 (("\"figlet") (string-append "\"" (which "figlet")))))))))

'which' looks in 'native-inputs', not 'inputs', so when cross-
compilation this is probably broken.  I suggest
(search-input-file inputs "bin/figlet") instead.

Greetings,
Maxime.
Guillaume Le Vaillant March 21, 2022, 9 a.m. UTC | #2 
Patch pushed as a47b4da09945610080ed9f436e8717a3a4c02664 with Maxime's
suggestion.
Thanks.
diff mbox series

Patch

diff --git a/gnu/packages/lisp-xyz.scm b/gnu/packages/lisp-xyz.scm
index 0c99518e82..21958528bc 100644
--- a/gnu/packages/lisp-xyz.scm
+++ b/gnu/packages/lisp-xyz.scm
@@ -69,6 +69,7 @@  (define-module (gnu packages lisp-xyz)
   #:use-module (gnu packages compression)
   #:use-module (gnu packages databases)
   #:use-module (gnu packages enchant)
+  #:use-module (gnu packages figlet)
   #:use-module (gnu packages file)
   #:use-module (gnu packages fonts)
   #:use-module (gnu packages fontutils)
@@ -5039,8 +5040,8 @@  (define-public ecl-log4cl
   (sbcl-package->ecl-package sbcl-log4cl))
 
 (define-public sbcl-printv
-  (let ((commit "646d31978dbbb460fffb160fd65bb2be9a5a434e")
-        (revision "1"))
+  (let ((commit "e717a7fe076dae861a96117b2f9af29db8d2294d")
+        (revision "2"))
     (package
       (name "sbcl-printv")
       (version (git-version "0.1.0" revision commit))
@@ -5052,8 +5053,17 @@  (define-public sbcl-printv
                (commit commit)))
          (file-name (git-file-name "printv" version))
          (sha256
-          (base32 "08jvy82abm7qi3wrxh6gvmwg9gy0zzhg4cfqajdwrggbah8mj5a6"))))
+          (base32 "07agyzkwp3w2r4d2anrmr8h00yngpr5dq9mjd3m4kzhn1jcmilfb"))))
       (build-system asdf-build-system/sbcl)
+      (inputs
+        (list figlet))
+      (arguments
+       `(#:phases
+         (modify-phases %standard-phases
+           (add-after 'unpack 'patch-figlet-executable
+             (lambda* (#:key inputs #:allow-other-keys)
+               (substitute* "printv.lisp"
+                 (("\"figlet") (string-append "\"" (which "figlet")))))))))
       (home-page "https://github.com/danlentz/printv")
       (synopsis "Common Lisp tracing and debug-logging macro")
       (description