diff mbox series

[bug#54134] services: xorg: Remove xf86-input-synaptics from %default-xorg-modules.

Message ID 20220223234249.8107-1-seerlite@nixnet.email
State Accepted
Headers show
Series [bug#54134] services: xorg: Remove xf86-input-synaptics from %default-xorg-modules. | expand

Checks

Context Check Description
cbaines/comparison success View comparision
cbaines/git branch success View Git branch
cbaines/applying patch success View Laminar job
cbaines/issue success View issue

Commit Message

SeerLite Feb. 23, 2022, 11:42 p.m. UTC 
Fixes <https://issues.guix.gnu.org/35450>.

This driver isn't intended to be installed by default as it takes
precedence over the recommended xf86-input-libinput.

* gnu/services/xorg.scm (%default-xorg-modules): Remove
  xf86-input-synaptics.
---
 gnu/services/xorg.scm | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

Comments

Mathieu Othacehe March 23, 2022, 10:59 a.m. UTC | #1 
Hey,

> Fixes <https://issues.guix.gnu.org/35450>.
>
> This driver isn't intended to be installed by default as it takes
> precedence over the recommended xf86-input-libinput.

Tested in a VM, seems fine to me. Tobias, Alex, Attila any objection?

Thanks,

Mathieu
Attila Lendvai March 23, 2022, 6:24 p.m. UTC | #2 
> Tested in a VM, seems fine to me. Tobias, Alex, Attila any objection?

no objections from me.

i still have this in my current config, although commented out by now:

;; TODO delete this eventually, i'm using wayland now
;; (xorg-configuration
;;  (xorg-configuration
;;   (keyboard-layout keyboard-layout)
;;   ;; for touchpad settings, we need to disable the now abandoned
;;   ;; synaptics driver: https://issues.guix.gnu.org/33189#5
;;   (modules (filter (lambda (mod)
;;                      (not (eq? mod xf86-input-synaptics)))
;;                    %default-xorg-modules))))

--
• attila lendvai
• PGP: 963F 5D5F 45C7 DFCD 0A39
--
“It is deplorable that many people think that the best way to improve the world is to forbid something. However, they're morally more advanced than the people who think the best way to improve the world is to kill somebody.”
	— John McCarthy (1927–2011), father of Lisp
Mathieu Othacehe March 25, 2022, 5:43 p.m. UTC | #3 
Pushed, thanks!

Mathieu
diff mbox series

Patch

diff --git a/gnu/services/xorg.scm b/gnu/services/xorg.scm
index d6dfb07425..0cbd9aa53b 100644
--- a/gnu/services/xorg.scm
+++ b/gnu/services/xorg.scm
@@ -145,8 +145,7 @@  (define %default-xorg-modules
 
         xf86-input-evdev
         xf86-input-keyboard
-        xf86-input-mouse
-        xf86-input-synaptics))
+        xf86-input-mouse))
 
 (define %default-xorg-fonts
   ;; Default list of fonts available to the X server.