diff mbox series

[bug#53959] installer: Continue even if Connman cannot phone home.

Message ID 20220212143832.emgl7r3mdqfljgpe@pelzflorian.localdomain
State Accepted
Headers show
Series [bug#53959] installer: Continue even if Connman cannot phone home. | expand

Checks

Context Check Description
cbaines/comparison success View comparision
cbaines/git branch success View Git branch
cbaines/applying patch success View Laminar job
cbaines/issue success View issue

Commit Message

pelzflorian (Florian Pelz) Feb. 12, 2022, 2:38 p.m. UTC 
Connman's online check is unreliable for me.

* gnu/installer/connman.scm (connman-online?): Accept if
connman state is ready instead of online.
---
 gnu/installer/connman.scm | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)


base-commit: 5996aab354831d942b10253bc70217a4f2e6a247

Comments

pelzflorian (Florian Pelz) Feb. 26, 2022, 3:13 p.m. UTC | #1 
On Sat, Feb 12, 2022 at 03:38:32PM +0100, Florian Pelz wrote:
>  (define (connman-online?)
>    (let ((state (connman-state)))
> -    (eq? state 'online)))
> +    (member state '(ready online))))


Pushed to master as cc11905568065409fe46487174e1cf404291bda1
using memq instead of member.

It will take effect once the guix package is updated.

Regards,
Florian
diff mbox series

Patch

diff --git a/gnu/installer/connman.scm b/gnu/installer/connman.scm
index 2f33b58453..6095d99947 100644
--- a/gnu/installer/connman.scm
+++ b/gnu/installer/connman.scm
@@ -287,7 +287,7 @@  (define (connman-disconnect service)
 
 (define (connman-online?)
   (let ((state (connman-state)))
-    (eq? state 'online)))
+    (member state '(ready online))))
 
 (define (connman-connect-with-auth service password-proc)
   "Connect to the given SERVICE with the password returned by calling