Message ID | 20220204045300.1985-1-ian@eonn.xyz |
---|---|
State | New |
Headers | show |
Series | [bug#53777] add python-posix-ipc | expand |
Context | Check | Description |
---|---|---|
cbaines/comparison | success | View comparision |
cbaines/git branch | success | View Git branch |
cbaines/applying patch | success | View Laminar job |
cbaines/issue | success | View issue |
Hi, Ian schrieb am Freitag der 04. Februar 2022 um 04:53 GMT: > Adding python-posix-ipc to gnu/packages/python-xyz.scm > > --- > gnu/packages/python-xyz.scm | 32 ++++++++++++++++++++++++++++++++ > 1 file changed, 32 insertions(+) > > diff --git a/gnu/packages/python-xyz.scm b/gnu/packages/python-xyz.scm > index 46419e8ace..53d5588564 100644 > --- a/gnu/packages/python-xyz.scm > +++ b/gnu/packages/python-xyz.scm > @@ -116,6 +116,7 @@ > ;;; Copyright © 2021 Greg Hogan <code@greghogan.com> > ;;; Copyright © 2022 John Kehayias <john.kehayias@protonmail.com> > ;;; Copyright © 2022 Aleksandr Vityazev <avityazev@posteo.org> > +;;; Copyright © 2022 Ian Ressa <ian@eonn.xyz> > ;;; > ;;; This file is part of GNU Guix. > ;;; > @@ -28926,3 +28927,34 @@ (define-public python-types-dataclasses > "This packages provides a collection of library stubs for Python, with > static types.") > (license license:asl2.0))) > + > +(define-public python-posix-ipc > + (package > + (name "python-posix-ipc") > + (version "1.0.5") > + (source (origin > + (method url-fetch) > + (uri (pypi-uri "posix_ipc" version)) > + (sha256 > + (base32 "15wbxf67y17g04i3f3vjw9zjbvlvqqk9q1x0ya1y7apl5k7b3pbc")))) > + (build-system python-build-system) > + (arguments > + `(#:modules ((guix build python-build-system) > + ((guix build gnu-build-system) #:prefix gnu:) > + (guix build utils)) Nothing from (guix build gnu-build-system) seems to be used. I think you can drop the ‘#:modules’ arguments all together. > + #:phases > + (modify-phases %standard-phases > + (add-after 'unpack 'support-cross-compilation > + (lambda _ > + (substitute* "prober.py" > + (("cc") ,(cc-for-target))) > + #t))))) Phases no longer have to return #f. > + (home-page "http://semanchuk.com/philip/posix_ipc/") The page supports HTTPS too, so it should be used instead of plain HTTP. > + (synopsis > + "POSIX IPC primitives (semaphores, shared memory and message > +queues) for Python") The things in parenthesis are also mentioned in the description, so I think you can drop them to make the synopsis a bit shorter. > + (description > + "The Python extension module posix_ipc gives Python access to > +POSIX inter-process semaphores, shared memory and message queues on systems > +that support the POSIX Realtime Extensions a.k.a. POSIX 1003.1b-1993.") > + (license license:bsd-3))) > -- > 2.34.0 The rest LGTM!
Hello Ian, Did you have a chance to address Xinglu’s comments below? Thanks in advance! Ludo’. Xinglu Chen <public@yoctocell.xyz> skribis: > Hi, > > Ian schrieb am Freitag der 04. Februar 2022 um 04:53 GMT: > >> Adding python-posix-ipc to gnu/packages/python-xyz.scm >> >> --- >> gnu/packages/python-xyz.scm | 32 ++++++++++++++++++++++++++++++++ >> 1 file changed, 32 insertions(+) >> >> diff --git a/gnu/packages/python-xyz.scm b/gnu/packages/python-xyz.scm >> index 46419e8ace..53d5588564 100644 >> --- a/gnu/packages/python-xyz.scm >> +++ b/gnu/packages/python-xyz.scm >> @@ -116,6 +116,7 @@ >> ;;; Copyright © 2021 Greg Hogan <code@greghogan.com> >> ;;; Copyright © 2022 John Kehayias <john.kehayias@protonmail.com> >> ;;; Copyright © 2022 Aleksandr Vityazev <avityazev@posteo.org> >> +;;; Copyright © 2022 Ian Ressa <ian@eonn.xyz> >> ;;; >> ;;; This file is part of GNU Guix. >> ;;; >> @@ -28926,3 +28927,34 @@ (define-public python-types-dataclasses >> "This packages provides a collection of library stubs for Python, with >> static types.") >> (license license:asl2.0))) >> + >> +(define-public python-posix-ipc >> + (package >> + (name "python-posix-ipc") >> + (version "1.0.5") >> + (source (origin >> + (method url-fetch) >> + (uri (pypi-uri "posix_ipc" version)) >> + (sha256 >> + (base32 "15wbxf67y17g04i3f3vjw9zjbvlvqqk9q1x0ya1y7apl5k7b3pbc")))) >> + (build-system python-build-system) >> + (arguments >> + `(#:modules ((guix build python-build-system) >> + ((guix build gnu-build-system) #:prefix gnu:) >> + (guix build utils)) > > Nothing from (guix build gnu-build-system) seems to be used. I think > you can drop the ‘#:modules’ arguments all together. > >> + #:phases >> + (modify-phases %standard-phases >> + (add-after 'unpack 'support-cross-compilation >> + (lambda _ >> + (substitute* "prober.py" >> + (("cc") ,(cc-for-target))) >> + #t))))) > > Phases no longer have to return #f. > > >> + (home-page "http://semanchuk.com/philip/posix_ipc/") > > The page supports HTTPS too, so it should be used instead of plain HTTP. > >> + (synopsis >> + "POSIX IPC primitives (semaphores, shared memory and message >> +queues) for Python") > > The things in parenthesis are also mentioned in the description, so I > think you can drop them to make the synopsis a bit shorter. > >> + (description >> + "The Python extension module posix_ipc gives Python access to >> +POSIX inter-process semaphores, shared memory and message queues on systems >> +that support the POSIX Realtime Extensions a.k.a. POSIX 1003.1b-1993.") >> + (license license:bsd-3))) >> -- >> 2.34.0 > > The rest LGTM!
On 2022-02-04, Ian Ressa wrote:
> Adding python-posix-ipc to gnu/packages/python-xyz.scm
python-posix-ipc was added in:
b12da85668c40be322204e1ca04fb70b4d709411 gnu: Add python-posix-ipc.
Marking as done.
live well,
vagrant
diff --git a/gnu/packages/python-xyz.scm b/gnu/packages/python-xyz.scm index 46419e8ace..53d5588564 100644 --- a/gnu/packages/python-xyz.scm +++ b/gnu/packages/python-xyz.scm @@ -116,6 +116,7 @@ ;;; Copyright © 2021 Greg Hogan <code@greghogan.com> ;;; Copyright © 2022 John Kehayias <john.kehayias@protonmail.com> ;;; Copyright © 2022 Aleksandr Vityazev <avityazev@posteo.org> +;;; Copyright © 2022 Ian Ressa <ian@eonn.xyz> ;;; ;;; This file is part of GNU Guix. ;;; @@ -28926,3 +28927,34 @@ (define-public python-types-dataclasses "This packages provides a collection of library stubs for Python, with static types.") (license license:asl2.0))) + +(define-public python-posix-ipc + (package + (name "python-posix-ipc") + (version "1.0.5") + (source (origin + (method url-fetch) + (uri (pypi-uri "posix_ipc" version)) + (sha256 + (base32 "15wbxf67y17g04i3f3vjw9zjbvlvqqk9q1x0ya1y7apl5k7b3pbc")))) + (build-system python-build-system) + (arguments + `(#:modules ((guix build python-build-system) + ((guix build gnu-build-system) #:prefix gnu:) + (guix build utils)) + #:phases + (modify-phases %standard-phases + (add-after 'unpack 'support-cross-compilation + (lambda _ + (substitute* "prober.py" + (("cc") ,(cc-for-target))) + #t))))) + (home-page "http://semanchuk.com/philip/posix_ipc/") + (synopsis + "POSIX IPC primitives (semaphores, shared memory and message +queues) for Python") + (description + "The Python extension module posix_ipc gives Python access to +POSIX inter-process semaphores, shared memory and message queues on systems +that support the POSIX Realtime Extensions a.k.a. POSIX 1003.1b-1993.") + (license license:bsd-3)))