| Message ID | 20220131145407.4679-1-maxim.cournoyer@gmail.com |
|---|---|
| State | Accepted |
| Headers | show |
| Series | [bug#53660] services/sound: Add a udev extension for the pulseaudio service type. | expand |
| Context | Check | Description |
|---|---|---|
| cbaines/comparison | success | View comparision |
| cbaines/git branch | success | View Git branch |
| cbaines/applying patch | success | View Laminar job |
| cbaines/issue | success | View issue |
Am Montag, dem 31.01.2022 um 09:54 -0500 schrieb Maxim Cournoyer: > PulseAudio provides udev rules used to adjust the configuration of > certain > hardware (e.g., sound cards); ensure they get used. > > * gnu/services/sound.scm (pulseaudio-service-type): Extend the > udev-service-type with the pulseaudio package. > --- > gnu/services/sound.scm | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/gnu/services/sound.scm b/gnu/services/sound.scm > index 1217223a0c..7beca35ffe 100644 > --- a/gnu/services/sound.scm > +++ b/gnu/services/sound.scm > @@ -159,7 +159,9 @@ (define pulseaudio-service-type > (extensions > (list (service-extension session-environment-service-type > pulseaudio-environment) > - (service-extension etc-service-type pulseaudio-etc))) > + (service-extension etc-service-type pulseaudio-etc) > + (service-extension udev-service-type (lambda _ > + (list > pulseaudio))))) You should use const, otherwise SGTM.
Hello, Liliana Marie Prikler <liliana.prikler@gmail.com> writes: > Am Montag, dem 31.01.2022 um 09:54 -0500 schrieb Maxim Cournoyer: >> PulseAudio provides udev rules used to adjust the configuration of >> certain >> hardware (e.g., sound cards); ensure they get used. >> >> * gnu/services/sound.scm (pulseaudio-service-type): Extend the >> udev-service-type with the pulseaudio package. >> --- >> gnu/services/sound.scm | 4 +++- >> 1 file changed, 3 insertions(+), 1 deletion(-) >> >> diff --git a/gnu/services/sound.scm b/gnu/services/sound.scm >> index 1217223a0c..7beca35ffe 100644 >> --- a/gnu/services/sound.scm >> +++ b/gnu/services/sound.scm >> @@ -159,7 +159,9 @@ (define pulseaudio-service-type >> (extensions >> (list (service-extension session-environment-service-type >> pulseaudio-environment) >> - (service-extension etc-service-type pulseaudio-etc))) >> + (service-extension etc-service-type pulseaudio-etc) >> + (service-extension udev-service-type (lambda _ >> + (list >> pulseaudio))))) > You should use const, otherwise SGTM. Good catch! Adjusted and pushed as fff4daa5c2bfbf42c7ad2519f500bd254ce880a8. Thank you, Maxim
diff --git a/gnu/services/sound.scm b/gnu/services/sound.scm index 1217223a0c..7beca35ffe 100644 --- a/gnu/services/sound.scm +++ b/gnu/services/sound.scm @@ -159,7 +159,9 @@ (define pulseaudio-service-type (extensions (list (service-extension session-environment-service-type pulseaudio-environment) - (service-extension etc-service-type pulseaudio-etc))) + (service-extension etc-service-type pulseaudio-etc) + (service-extension udev-service-type (lambda _ + (list pulseaudio))))) (default-value (pulseaudio-configuration)) (description "Configure PulseAudio sound support.")))