[bug#53311] gnu: kdenlive: Update to 21.12.1.

* gnu/packages/kde.scm (kdenlive): Update to 21.12.1.
---
 gnu/packages/kde.scm | 149 +++++++++++++++++++++----------------------
 1 file changed, 74 insertions(+), 75 deletions(-)


base-commit: 36f4745dc10e5d0e8b2a62cd2c8439629debae4f

Hi,

Vinicius Monego schreef op zo 16-01-2022 om 23:57 [+0000]:
> +    (synopsis "Non-linear video editor")
> +    (description "Kdenlive is an acronym for KDE Non-Linear Video Editor.
>  
>  Non-linear video editing is much more powerful than beginner's (linear)
>  editors, hence it requires a bit more organization before starting.  However,
>  it is not reserved to specialists and can be used for small personal
>  projects.")
> -      (license license:gpl2+))))
> +    (license license:gpl2+)))

Looking at ./data/resourceproviders/freesound.json and
./src/onlineresources/providermodel.cpp, kdenlive sometimes accesses
the network, possibly using TLS.  Because the Qt stack uses OpenSSL,
SSL_CERT_DIR or SSL_CERT_FILE would need to be added to
native-search-paths to make "guix shell --pure kdenlive nss-certs" work
(untested).

That seems to be a bug in the original package definition though.

Greetings,
Maxime.

Hi,

Vinicius Monego schreef op zo 16-01-2022 om 23:57 [+0000]:
> -                 (wrap-program (string-append out "/bin/kdenlive")
> -                   `("PATH" ":" prefix
> -                     ,(list (string-append ffmpeg "/bin")))
> -                   [...]
> [...]
> +               (wrap-program (string-append out "/bin/kdenlive")
> +                 `("PATH" ":" prefix
> +                   ,(list (string-append ffmpeg "/bin")))
> +                 [...]
> 
> 

'data/scripts/checkvosk.py' (called from
'src/dialogs/kdenlivesettingsdialog.cpp') has a call to 'python -m pip
install', can it be neutralised?

There are a few python scripts, are we missing 'python' in inputs?

'ffmpeg' is invoked from a few Python scripts and from C++ code, using
ffmpegpath.  So FWIW, the absolute path to 'ffmpeg' can be baked in
with a few substitute* and by adding a line to the following code
in src/core.cpp:

    if (isAppImage) {
        QString appPath = qApp->applicationDirPath();
        KdenliveSettings::setFfmpegpath(QDir::cleanPath(appPath + QStringLiteral("/ffmpeg")));
        KdenliveSettings::setFfplaypath(QDir::cleanPath(appPath + QStringLiteral("/ffplay")));
        KdenliveSettings::setFfprobepath(QDir::cleanPath(appPath + QStringLiteral("/ffprobe")));
        KdenliveSettings::setRendererpath(QDir::cleanPath(appPath + QStringLiteral("/melt")));
        m_mainWindow->init(QDir::cleanPath(appPath + QStringLiteral("/../share/mlt/profiles")));
    } else {
        // Open connection with Mlt
        m_mainWindow->init(MltPath);
        // setFfmpegpath and the like can be set here!
    }

YMMW whether this is an improvement or not.

Greetings,
Maxime.

Hello,

Vinicius Monego <monego@posteo.net> writes:

> * gnu/packages/kde.scm (kdenlive): Update to 21.12.1.

LGTM!

Regards,

Em seg, 2022-01-17 às 12:27 +0000, Maxime Devos escreveu:
> Hi,
> 
> Vinicius Monego schreef op zo 16-01-2022 om 23:57 [+0000]:
> > -                 (wrap-program (string-append out "/bin/kdenlive")
> > -                   `("PATH" ":" prefix
> > -                     ,(list (string-append ffmpeg "/bin")))
> > -                   [...]
> > [...]
> > +               (wrap-program (string-append out "/bin/kdenlive")
> > +                 `("PATH" ":" prefix
> > +                   ,(list (string-append ffmpeg "/bin")))
> > +                 [...]
> > 
> > 
> 
> 'data/scripts/checkvosk.py' (called from
> 'src/dialogs/kdenlivesettingsdialog.cpp') has a call to 'python -m
> pip
> install', can it be neutralised?
> 
> There are a few python scripts, are we missing 'python' in inputs?
> 

The python scripts are related to Vosk. The feature can be accessed
from Settings => Configure Kdenlive => Speech to Text. It contains a
warning and a button "Install missing dependencies", and nothing
happens when it's clicked. Nothing relevant in the logs. This feature
can't be enabled as is, so the files won't do anything.

> 'ffmpeg' is invoked from a few Python scripts and from C++ code,
> using
> ffmpegpath.  So FWIW, the absolute path to 'ffmpeg' can be baked in
> with a few substitute* and by adding a line to the following code
> in src/core.cpp:
> 
>     if (isAppImage) {
>         QString appPath = qApp->applicationDirPath();
>         KdenliveSettings::setFfmpegpath(QDir::cleanPath(appPath +
> QStringLiteral("/ffmpeg")));
>         KdenliveSettings::setFfplaypath(QDir::cleanPath(appPath +
> QStringLiteral("/ffplay")));
>         KdenliveSettings::setFfprobepath(QDir::cleanPath(appPath +
> QStringLiteral("/ffprobe")));
>         KdenliveSettings::setRendererpath(QDir::cleanPath(appPath +
> QStringLiteral("/melt")));
>         m_mainWindow->init(QDir::cleanPath(appPath +
> QStringLiteral("/../share/mlt/profiles")));
>     } else {
>         // Open connection with Mlt
>         m_mainWindow->init(MltPath);
>         // setFfmpegpath and the like can be set here!
>     }
> 
> YMMW whether this is an improvement or not.

I'm not sure where kdenlive calls ffmpeg, but rendering a project works
via 'melt', with the correct path being displayed in the logs.

I tested this build again and it's segfaulting when I try drag an
effect into the video, which doesn't happen in 21.08.3.

Seems that this package needs some work before it's production ready. I
will keep this issue open while I investigate.

> 
> Greetings,
> Maxime.

Hi Vinicius,

Could you take a look and push this one?

TIA! :-)

Ludo’.

Nicolas Goaziou <mail@nicolasgoaziou.fr> skribis:

> Hello,
>
> Vinicius Monego <monego@posteo.net> writes:
>
>> * gnu/packages/kde.scm (kdenlive): Update to 21.12.1.
>
> LGTM!
>
> Regards,

Hi Ludo,

I pushed an update to 21.12.3 a while ago which fixes the issues I
reported in this thread. I left this open because of Maxime's
suggestions about SSL_CERT_DIR and Vosk, I wanted to hear more opinions
on it. If the package is fine as is, it's safe to close this issue.

Em ter, 2022-04-05 às 18:22 +0200, Ludovic Courtès escreveu:
> Hi Vinicius,
> 
> Could you take a look and push this one?
> 
> TIA! :-)
> 
> Ludo’.
> 
> Nicolas Goaziou <mail@nicolasgoaziou.fr> skribis:
> 
> > Hello,
> > 
> > Vinicius Monego <monego@posteo.net> writes:
> > 
> > > * gnu/packages/kde.scm (kdenlive): Update to 21.12.1.
> > 
> > LGTM!
> > 
> > Regards,

Hi,

Vinicius Monego <monego@posteo.net> skribis:

> I pushed an update to 21.12.3 a while ago which fixes the issues I
> reported in this thread. I left this open because of Maxime's
> suggestions about SSL_CERT_DIR and Vosk, I wanted to hear more opinions
> on it. If the package is fine as is, it's safe to close this issue.

Oops, sorry for the confusion.  For clarity, I think it’s best to close
it and to open a separate issue if there’s one.

Thanks!

Ludo’.

Em qua, 2022-04-06 às 10:14 +0200, Ludovic Courtès escreveu:
> Hi,
> 
> Vinicius Monego <monego@posteo.net> skribis:
> 
> > I pushed an update to 21.12.3 a while ago which fixes the issues I
> > reported in this thread. I left this open because of Maxime's
> > suggestions about SSL_CERT_DIR and Vosk, I wanted to hear more
> > opinions
> > on it. If the package is fine as is, it's safe to close this issue.
> 
> Oops, sorry for the confusion.  For clarity, I think it’s best to
> close
> it and to open a separate issue if there’s one.
> 
> Thanks!
> 
> Ludo’.
> 

OK, closing this one now.

Vinicius