From patchwork Sat Jan 15 13:49:59 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Josselin Poiret X-Patchwork-Id: 36368 Return-Path: X-Original-To: patchwork@mira.cbaines.net Delivered-To: patchwork@mira.cbaines.net Received: by mira.cbaines.net (Postfix, from userid 113) id AE01B27BBEA; Sat, 15 Jan 2022 13:52:01 +0000 (GMT) X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on mira.cbaines.net X-Spam-Level: X-Spam-Status: No, score=-0.7 required=5.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,FROM_SUSPICIOUS_NTLD,MAILING_LIST_MULTI,PDS_OTHER_BAD_TLD, RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.6 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mira.cbaines.net (Postfix) with ESMTPS id 81AF627BBE9 for ; Sat, 15 Jan 2022 13:52:01 +0000 (GMT) Received: from localhost ([::1]:38424 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1n8jTM-0005Jo-MP for patchwork@mira.cbaines.net; Sat, 15 Jan 2022 08:52:00 -0500 Received: from eggs.gnu.org ([209.51.188.92]:37772) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1n8jSS-0005E9-FC for guix-patches@gnu.org; Sat, 15 Jan 2022 08:51:04 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:46621) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1n8jSS-0004F3-59 for guix-patches@gnu.org; Sat, 15 Jan 2022 08:51:04 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1n8jSS-0001qx-4q for guix-patches@gnu.org; Sat, 15 Jan 2022 08:51:04 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#53063] [PATCH v2 wip-harden-installer 06/18] installer: Remove specific logging code. Resent-From: Josselin Poiret Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sat, 15 Jan 2022 13:51:04 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 53063 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Mathieu Othacehe Cc: 53063@debbugs.gnu.org, ludo@gnu.org, Josselin Poiret Received: via spool by 53063-submit@debbugs.gnu.org id=B53063.16422546406998 (code B ref 53063); Sat, 15 Jan 2022 13:51:04 +0000 Received: (at 53063) by debbugs.gnu.org; 15 Jan 2022 13:50:40 +0000 Received: from localhost ([127.0.0.1]:39502 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n8jS3-0001oO-QC for submit@debbugs.gnu.org; Sat, 15 Jan 2022 08:50:40 -0500 Received: from jpoiret.xyz ([206.189.101.64]:48812) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n8jRt-0001md-6L for 53063@debbugs.gnu.org; Sat, 15 Jan 2022 08:50:29 -0500 Received: from authenticated-user (jpoiret.xyz [206.189.101.64]) by jpoiret.xyz (Postfix) with ESMTPA id 3C4EC184F8D; Sat, 15 Jan 2022 13:50:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=jpoiret.xyz; s=dkim; t=1642254628; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=z2vI4D6Fy8gvcaN540bXzGA36skxT+wNDOijw0fnnQs=; b=Unb0wPE8d5s6KJZbMJtf7M33FlM+9Xn2SA+yfj1P7eeMRAXeFuesb2k9MzU6clHkK7xqD+ /v6e8GP4KE4B/5Q5ms4fSHmNsAcx+4aIje1BUXmPY+5RYujOWncTDeD+pNKRbH8l8HHAzf nSsjo4YRlJq3PSY5wCumEc1pN+xT0fMzBYZvlrrEDm+Vdpll6Vvg5h+ktdNNMfoyycd/T6 FMyaNWaONFsFjwnooaoSXqCWP6T4IXWfU/ueo9BKXCRJqBPYCyEL6kYNMpIOXlxuhNDRiP ZfxMYh/xsHdoGqgx4PqkME1VuIsWdQFMURuZ+5wOCk5ddg2y3PaFC7jk3aJLBw== Date: Sat, 15 Jan 2022 14:49:59 +0100 Message-Id: <20220115135011.5817-7-dev@jpoiret.xyz> In-Reply-To: <20220115135011.5817-1-dev@jpoiret.xyz> References: <8735lz4xsv.fsf@gnu.org> <20220115135011.5817-1-dev@jpoiret.xyz> MIME-Version: 1.0 X-Spamd-Bar: / Authentication-Results: jpoiret.xyz; auth=pass smtp.auth=jpoiret@jpoiret.xyz smtp.mailfrom=dev@jpoiret.xyz X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+patchwork=mira.cbaines.net@gnu.org Sender: "Guix-patches" Reply-to: Josselin Poiret X-ACL-Warn: , Josselin Poiret via Guix-patches X-Patchwork-Original-From: Josselin Poiret via Guix-patches via From: Josselin Poiret X-getmail-retrieved-from-mailbox: Patches * gnu/installer/final.scm (install-system): Remove command logging to syslog, as this is taken care of by the new facilities. --- gnu/installer/final.scm | 12 +----------- 1 file changed, 1 insertion(+), 11 deletions(-) diff --git a/gnu/installer/final.scm b/gnu/installer/final.scm index 7d5eca4c7e..63e5073ff4 100644 --- a/gnu/installer/final.scm +++ b/gnu/installer/final.scm @@ -211,17 +211,7 @@ (define (assert-exit x) (setenv "PATH" path) - ;; If there are any connected clients, assume that we are running - ;; installation tests. In that case, dump the standard and error - ;; outputs to syslog. - (set! ret - (if (not (null? (current-clients))) - (with-output-to-file "/dev/console" - (lambda () - (with-error-to-file "/dev/console" - (lambda () - (run-command install-command))))) - (run-command install-command)))) + (set! ret (run-command install-command))) (lambda () ;; Restart guix-daemon so that it does no keep the MNT namespace ;; alive.