diff mbox series

[bug#53154] services: laminar: Set LAMINAR_BIND_RPC environment variable.

Message ID 20220110055812.19842-1-arunisaac@systemreboot.net
State Accepted
Headers show
Series [bug#53154] services: laminar: Set LAMINAR_BIND_RPC environment variable. | expand

Checks

Context Check Description
cbaines/comparison success View comparision
cbaines/git branch success View Git branch
cbaines/applying patch success View Laminar job
cbaines/issue success View issue

Commit Message

Arun Isaac Jan. 10, 2022, 5:58 a.m. UTC 
Earlier, the bind-rpc field of <laminar-configuration> was not used at
all. This was a bug.

* gnu/services/ci.scm (laminar-shepherd-service): Use bind-rpc to set
LAMINAR_BIND_RPC environment variable.
---
 gnu/services/ci.scm | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

Comments

Arun Isaac Jan. 10, 2022, 6:01 a.m. UTC | #1 
Hi Chris,

I have CCed you on this issue, since you wrote the laminar service and
might be able to review this patch easily.

Thank you!
Christopher Baines Jan. 10, 2022, 8:57 a.m. UTC | #2 
Arun Isaac <arunisaac@systemreboot.net> writes:

> Hi Chris,
>
> I have CCed you on this issue, since you wrote the laminar service and
> might be able to review this patch easily.
>
> Thank you!

It looks like a good change to me, please push!

Chris
Arun Isaac Jan. 11, 2022, 6:56 a.m. UTC | #3 
Pushed, thanks!
diff mbox series

Patch

diff --git a/gnu/services/ci.scm b/gnu/services/ci.scm
index 0c3566bcaf..172f85fe8e 100644
--- a/gnu/services/ci.scm
+++ b/gnu/services/ci.scm
@@ -1,6 +1,6 @@ 
 ;;; GNU Guix --- Functional package management for GNU
 ;;; Copyright © 2018, 2019, 2020, 2021 Christopher Baines <mail@cbaines.net>
-;;; Copyright © 2021 Arun Isaac <arunisaac@systemreboot.net>
+;;; Copyright © 2021, 2022 Arun Isaac <arunisaac@systemreboot.net>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -84,6 +84,8 @@  (define laminar-shepherd-service
                                         #$home-directory)
                         ,(string-append "LAMINAR_BIND_HTTP="
                                         #$bind-http)
+                        ,(string-append "LAMINAR_BIND_RPC="
+                                        #$bind-rpc)
                         ,(string-append "LAMINAR_TITLE="
                                         #$title)
                         ,(string-append "LAMINAR_KEEP_RUNDIRS="