| Message ID | 20220105224600.9227-1-jgart@dismail.de |
|---|---|
| State | Accepted |
| Headers | show |
| Series | [bug#53039] build-system/python: Change let* to let. | expand |
| Context | Check | Description |
|---|---|---|
| cbaines/comparison | success | View comparision |
| cbaines/git branch | success | View Git branch |
| cbaines/applying patch | success | View Laminar job |
| cbaines/issue | success | View issue |
| cbaines/comparison | success | View comparision |
| cbaines/git branch | success | View Git branch |
| cbaines/applying patch | success | View Laminar job |
| cbaines/issue | success | View issue |
| cbaines/comparison | success | View comparision |
| cbaines/git branch | success | View Git branch |
| cbaines/applying patch | success | View Laminar job |
| cbaines/issue | success | View issue |
retitle [PATCH core-updates-frozen] build-system-python: Change let* to let. thanks >[python-build-system.scm] > - (let* ((out (python-output outputs)) > - (python (assoc-ref inputs "python"))) > + (let ((out (python-output outputs)) > + (python (assoc-ref inputs "python"))) According to "guix refresh -l python-six", this would rebuild a lot (at least 3122), so this would need to be done on core-updates. Seems ok otherwise.
Hi, jgart <jgart@dismail.de> writes: > * guix/build/python-build-system.scm (site-packages): Change let* to let for > readability and since let* is unused. > --- > guix/build/python-build-system.scm | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/guix/build/python-build-system.scm b/guix/build/python-build-system.scm > index 08871f60cd..a9b1c74f63 100644 > --- a/guix/build/python-build-system.scm > +++ b/guix/build/python-build-system.scm > @@ -11,6 +11,7 @@ > ;;; Copyright © 2020 Efraim Flashner <efraim@flashner.co.il> > ;;; Copyright © 2021 Lars-Dominik Braun <lars@6xq.net> > ;;; Copyright © 2021 Maxime Devos <maximedevos@telenet.be> > +;;; Copyright © 2022 jgart <jgart@dismail.de> > ;;; > ;;; This file is part of GNU Guix. > ;;; > @@ -176,8 +177,8 @@ (define (python-output outputs) > > (define (site-packages inputs outputs) > "Return the path of the current output's Python site-package." > - (let* ((out (python-output outputs)) > - (python (assoc-ref inputs "python"))) > + (let ((out (python-output outputs)) > + (python (assoc-ref inputs "python"))) > (string-append out "/lib/python" (python-version python) "/site-packages"))) > > (define (add-installed-pythonpath inputs outputs) As Maxime mentioned, that should go to core-updates. It's nice to use the --subject-prefix option of 'git format-patch' to change it to "[PATCH core-updates]", so that we don't apply these mistakenly to master and cause world rebuilds :-) Another note; only changes of minimally 10 lines are copyrightable, so you do not need to add a copyright attribution for trivial changes such as this one. I've made the change to core-updates and committed as 47fac5dc59; closing. Thank you! Maxim
On Wed, 18 May 2022 09:06:58 -0400 Maxim Cournoyer <maxim.cournoyer@gmail.com> wrote:
> I've made the change to core-updates and committed as 47fac5dc59; closing.
Hi Maxim,
Thank you for doing that. Sorry, I couldn't get to it. I've been in the
onboarding process of starting a new job and moving to a new city and
have been really busy.
Hope to get some free time soon to continue contributing to Guix :)
all best,
jgart
diff --git a/guix/build/python-build-system.scm b/guix/build/python-build-system.scm index 08871f60cd..a9b1c74f63 100644 --- a/guix/build/python-build-system.scm +++ b/guix/build/python-build-system.scm @@ -11,6 +11,7 @@ ;;; Copyright © 2020 Efraim Flashner <efraim@flashner.co.il> ;;; Copyright © 2021 Lars-Dominik Braun <lars@6xq.net> ;;; Copyright © 2021 Maxime Devos <maximedevos@telenet.be> +;;; Copyright © 2022 jgart <jgart@dismail.de> ;;; ;;; This file is part of GNU Guix. ;;; @@ -176,8 +177,8 @@ (define (python-output outputs) (define (site-packages inputs outputs) "Return the path of the current output's Python site-package." - (let* ((out (python-output outputs)) - (python (assoc-ref inputs "python"))) + (let ((out (python-output outputs)) + (python (assoc-ref inputs "python"))) (string-append out "/lib/python" (python-version python) "/site-packages"))) (define (add-installed-pythonpath inputs outputs)