[bug#52596,guix-artwork] website: Relabel stable/latest to release/current.

Sorry for not having pushed yet.  (Actually I had somehow assumed you
had commit access ...).

On Sun, Dec 19, 2021 at 10:21:29AM +0100, zimoun wrote:
> Well, maybe ’standard / latest’?  Or something else than latest as
> development, current, or whatever else.

Actually yes.

I would like to push the attached patch
"website: Relabel stable/latest to standard/latest."
which is your patch but:

- Typo is fixed and G_ is used correctly.

- With latest remaining latest.  I don't think there is much
  difference, so better not invalidate existing translations.  Also
  latest is arguably more accurate than current.

- The sum of your changes grants copyright IMHO, so I added copyright
  headers for you for all changed files.
  Note that Luis Felipe opted for
  ;;; Public domain 2021 Luis Felipe López Acevedo
  instead of
  ;;; Copyright © 2021 Simon Tournier <zimon.toutoune@gmail.com>
  so I better ask first which you prefer.

- Also changing Help/GNU Guix Manual (stable)
  to Help/GNU Guix Manual 1.3.0 as you proposed.

OK?

Regards,
Florian
From: zimoun <zimon.toutoune@gmail.com>
Date: Sat, 18 Dec 2021 11:40:38 +0100
Subject: [PATCH] website: Relabel stable/latest to standard/latest.

* website/apps/base/templates/components.scm (navbar): Relabel.
* website/apps/base/templates/help.scm (help-t): Relabel.
* website/apps/download/templates/download-latest.scm (download-latest-t):
Relabel.

Signed-off-by: Florian Pelz <pelzflorian@pelzflorian.de>
---
 website/apps/base/templates/components.scm          | 12 +++++++-----
 website/apps/base/templates/help.scm                |  7 ++++---
 website/apps/download/templates/download-latest.scm | 10 ++++++----
 3 files changed, 17 insertions(+), 12 deletions(-)


base-commit: 336f7905428a858e32ea8064317a6cc03fa64afe

Hi Florian,

On Fri, 24 Dec 2021 at 18:34, "pelzflorian (Florian Pelz)" <pelzflorian@pelzflorian.de> wrote:

> Sorry for not having pushed yet.  (Actually I had somehow assumed you
> had commit access ...).

Sorry for the delay.  Indeed, I do not have commit access. :-)

> On Sun, Dec 19, 2021 at 10:21:29AM +0100, zimoun wrote:
>> Well, maybe ’standard / latest’?  Or something else than latest as
>> development, current, or whatever else.
>
> Actually yes.

Thanks for the follow up.


> I would like to push the attached patch
> "website: Relabel stable/latest to standard/latest."

LGTM, thanks for the various fixes.


> - The sum of your changes grants copyright IMHO, so I added copyright
>   headers for you for all changed files.
>   Note that Luis Felipe opted for
>   ;;; Public domain 2021 Luis Felipe López Acevedo
>   instead of
>   ;;; Copyright © 2021 Simon Tournier <zimon.toutoune@gmail.com>
>   so I better ask first which you prefer.

All is fine.  Since I considered it was trivial changes, I appeared to
me not necessary for the Copyright line. :-)  Thanks for taking care of
all that.


> - Also changing Help/GNU Guix Manual (stable)
>   to Help/GNU Guix Manual 1.3.0 as you proposed.

With fresh eyes, maybe “Guix Manual” is enough here.


> From: zimoun <zimon.toutoune@gmail.com>
> Date: Sat, 18 Dec 2021 11:40:38 +0100
> Subject: [PATCH] website: Relabel stable/latest to standard/latest.
>
> * website/apps/base/templates/components.scm (navbar): Relabel.
> * website/apps/base/templates/help.scm (help-t): Relabel.
> * website/apps/download/templates/download-latest.scm (download-latest-t):
> Relabel.
>
> Signed-off-by: Florian Pelz <pelzflorian@pelzflorian.de>
> ---
>  website/apps/base/templates/components.scm          | 12 +++++++-----
>  website/apps/base/templates/help.scm                |  7 ++++---
>  website/apps/download/templates/download-latest.scm | 10 ++++++----
>  3 files changed, 17 insertions(+), 12 deletions(-)

LGTM.


Cheers,
simon

On Wed, Dec 29, 2021 at 05:40:45PM +0100, zimoun wrote:
> On Fri, 24 Dec 2021 at 18:34, "pelzflorian (Florian Pelz)" <pelzflorian@pelzflorian.de> wrote:
> > - Also changing Help/GNU Guix Manual (stable)
> >   to Help/GNU Guix Manual 1.3.0 as you proposed.
> 
> With fresh eyes, maybe “Guix Manual” is enough here.

I have pushed as-is (commit 2f5793cf543edc6fee4fe1351b9b30dfce116dea),
because the Help/All page calls it GNU Guix Manual 1.3.0 too.

Also I think it is good now.  The 1.3.0 makes clear the difference to
latest.  The only downside to naming it 1.3.0 that I see is that the
guix.gnu.org/manual URL will change away from 1.3.0 on the next
release.

Thank you Simon!

Regards,
Florian

On Wed, Dec 29, 2021 at 08:42:57PM +0100, pelzflorian (Florian Pelz) wrote:
> On Wed, Dec 29, 2021 at 05:40:45PM +0100, zimoun wrote:
> > On Fri, 24 Dec 2021 at 18:34, "pelzflorian (Florian Pelz)" <pelzflorian@pelzflorian.de> wrote:
> > > - Also changing Help/GNU Guix Manual (stable)
> > >   to Help/GNU Guix Manual 1.3.0 as you proposed.
> > 
> > With fresh eyes, maybe “Guix Manual” is enough here.
> 
> I have pushed as-is (commit 2f5793cf543edc6fee4fe1351b9b30dfce116dea),
> because the Help/All page calls it GNU Guix Manual 1.3.0 too.
> 
> Also I think it is good now.  The 1.3.0 makes clear the difference to
> latest.  The only downside to naming it 1.3.0 that I see is that the
> guix.gnu.org/manual URL will change away from 1.3.0 on the next
> release.

Maybe we can paremeterize the responsible code so that it's updated
automatically?

Hi Florian,

On Wed, 29 Dec 2021 at 20:42, "pelzflorian (Florian Pelz)" <pelzflorian@pelzflorian.de> wrote:
> On Wed, Dec 29, 2021 at 05:40:45PM +0100, zimoun wrote:
>> On Fri, 24 Dec 2021 at 18:34, "pelzflorian (Florian Pelz)" <pelzflorian@pelzflorian.de> wrote:
>> > - Also changing Help/GNU Guix Manual (stable)
>> >   to Help/GNU Guix Manual 1.3.0 as you proposed.
>> 
>> With fresh eyes, maybe “Guix Manual” is enough here.
>
> I have pushed as-is (commit 2f5793cf543edc6fee4fe1351b9b30dfce116dea),
> because the Help/All page calls it GNU Guix Manual 1.3.0 too.

Cool!

Well, I think “GNU Guix Manual“ is superfluous in the Help
navbar. “Manual“ seems enough, IMHO.  Similarly for “Guix Reference
Card”, I would be weird that this reference card points to something
else.  For instance, it is only “Cookbook“ and not “GNU Guix Cookbook”,
in the Help navbar.

Then, the webpage “mentioning GNU Guix …” is fine.


> Also I think it is good now.  The 1.3.0 makes clear the difference to
> latest.  The only downside to naming it 1.3.0 that I see is that the
> guix.gnu.org/manual URL will change away from 1.3.0 on the next
> release.

Personally, I prefer light and straight navigation bar than one with too
many redundant information.  But all tastes are around. ;-)


Cheers,
simon

On Wed, Dec 29, 2021 at 03:07:10PM -0500, Leo Famulari wrote:
> On Wed, Dec 29, 2021 at 08:42:57PM +0100, pelzflorian (Florian Pelz) wrote:
> > The only downside to naming it 1.3.0 that I see is that the
> > guix.gnu.org/manual URL will change away from 1.3.0 on the next
> > release.
> Maybe we can paremeterize the responsible code so that it's updated
> automatically?

Leo, we could create https://guix.gnu.org/manual/1.3.0/ and make the
navbar’s Help/GNU Guix Manual 1.3.0 point to
https://guix.gnu.org/manual/1.3.0/ so the meaning of the URL will not
change in the future.  This is what I meant; I had expressed myself
badly so I’m unsure now if you really mean that.

It is all unnecessary, I think; IMHO we do not even need both
https://guix.gnu.org/manual/ and https://guix.gnu.org/manual/devel/,
except when users manually change /etc/config.scm without guix pull.
Or do foreign distro users need the old manual to install?  But why?


The label Help/GNU Guix Manual 1.3.0 already uses

(define latest-guix-version
  (make-parameter "1.3.0"))

so the label will automatically become Help/GNU Guix Manual 1.4.0 or
whatever the next release will be called.

Regards,
Florian

Hi Florian,

I am still seeing the old version, even after refreshing.  All is it ok?


Cheers,
simon

On Thu, Dec 30, 2021 at 04:49:21PM +0100, zimoun wrote:
> Hi Florian,
> 
> I am still seeing the old version, even after refreshing.  All is it ok?
> 
> 
> Cheers,
> simon

I don’t know about builds on berlin.  A local build of the de_DE
website was successful.

Regards,
Florian