From patchwork Thu Nov 25 23:35:55 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Simon Tournier X-Patchwork-Id: 34817 Return-Path: X-Original-To: patchwork@mira.cbaines.net Delivered-To: patchwork@mira.cbaines.net Received: by mira.cbaines.net (Postfix, from userid 113) id AE24F27BBEA; Thu, 25 Nov 2021 23:37:12 +0000 (GMT) X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on mira.cbaines.net X-Spam-Level: X-Spam-Status: No, score=-3.7 required=5.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FROM,MAILING_LIST_MULTI, RCVD_IN_MSPIKE_H2,SPF_HELO_PASS autolearn=unavailable autolearn_force=no version=3.4.6 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mira.cbaines.net (Postfix) with ESMTPS id 74D3527BBE9 for ; Thu, 25 Nov 2021 23:37:12 +0000 (GMT) Received: from localhost ([::1]:45578 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mqOIh-0000EK-K9 for patchwork@mira.cbaines.net; Thu, 25 Nov 2021 18:37:11 -0500 Received: from eggs.gnu.org ([209.51.188.92]:38752) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mqOIY-0000DO-1Y for guix-patches@gnu.org; Thu, 25 Nov 2021 18:37:02 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:46706) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mqOIX-0005m7-Ot for guix-patches@gnu.org; Thu, 25 Nov 2021 18:37:01 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mqOIX-0000xG-MG for guix-patches@gnu.org; Thu, 25 Nov 2021 18:37:01 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#52117] [PATCH 2/6] build: julia-build-system: Correctly disable parallel tests. Resent-From: zimoun Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Thu, 25 Nov 2021 23:37:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 52117 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 52117@debbugs.gnu.org Cc: zimoun Received: via spool by 52117-submit@debbugs.gnu.org id=B52117.16378833823559 (code B ref 52117); Thu, 25 Nov 2021 23:37:01 +0000 Received: (at 52117) by debbugs.gnu.org; 25 Nov 2021 23:36:22 +0000 Received: from localhost ([127.0.0.1]:58239 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mqOHu-0000vL-2u for submit@debbugs.gnu.org; Thu, 25 Nov 2021 18:36:22 -0500 Received: from mail-wm1-f54.google.com ([209.85.128.54]:34536) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mqOHs-0000v4-RA for 52117@debbugs.gnu.org; Thu, 25 Nov 2021 18:36:21 -0500 Received: by mail-wm1-f54.google.com with SMTP id m25-20020a7bcb99000000b0033aa12cdd33so1655703wmi.1 for <52117@debbugs.gnu.org>; Thu, 25 Nov 2021 15:36:20 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=hcqDPUt6SBIgtBx4Q54hMpUhppPQQ3NV8+ARhSF1IB0=; b=oefkv1QOS+44IqBJAezF+A62xzHsYgJr/3Vbf0TJIlkgVWTG93ycqdqLxocK9ZjYpT 694hxEUkXO0AA2K3sflu/jifIqfnYwV2udy9Nf/dT/NfjpMKz4tHSfp8Kq3wYtJg43P8 rTxNfuiscjF8+QwdobTSB8hUoPG1KTo09nuNLVeqN0nq6fpQ7h+PfDAaPnNsfvXajGep WMdtKuHIWDnbbnUHH4Ph3Z6Yf/xhTSs5CXZN8fUuW2pOBoKnYstwrdOrCBrL85pM2Afb JbZcOG/4oWXpvHVqVxd9tUJXrWoGxDCRXgX0DHZ5chGBRIFPTI1SdJEm2t9WrYvBXSyB Y6ug== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=hcqDPUt6SBIgtBx4Q54hMpUhppPQQ3NV8+ARhSF1IB0=; b=C3cPnAllCUOr/I7aUtfAiOUFiCZhbZ5P7IS37c5O1XH6wGRx3lE8VaKpBZUSQXwfTZ XMfP3/tAMCJHNmoW/k+zpVQMIzZ6W/v04JDeD/0UCi/wvA7V0HK9ca72I3hTGruZgn0F E73gYgBHvyCG72AWCDd+dOuiYT2pYokJiYYItX0HHcRKXvCKIHdIaOncMdLs/YaD5W5I rlIZDb9WqIoRyqtMLG0pEXbaZLp3OdwRnrb6Ocs/kRS+/Sli7xCUTTXcohJYmhYwn094 hfkjuwy/d9qZNRSAqq4IZLCdIihPLWCIEFhRKVCUslvmEkpz68B2s7HPGfkTLraR89k8 V3QQ== X-Gm-Message-State: AOAM532TVeAo3pmEguX2nRFdKYIGn6K6JxkNYh0o2ikmPmRFFM89BBYb 5gCKUhW3J51Uzi7xkdHVdPpPe6PW80g= X-Google-Smtp-Source: ABdhPJyFwOarYRtsjYLwFGaAgtXuiDX8YxecWwhoL4VmWS4//E5xTQ0uV2F2L1GkTmtEs4PNJUT8mw== X-Received: by 2002:a05:600c:190b:: with SMTP id j11mr11557977wmq.112.1637883375208; Thu, 25 Nov 2021 15:36:15 -0800 (PST) Received: from localhost.localdomain ([193.48.40.110]) by smtp.gmail.com with ESMTPSA id m1sm4337171wme.39.2021.11.25.15.36.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 25 Nov 2021 15:36:14 -0800 (PST) From: zimoun Date: Fri, 26 Nov 2021 00:35:55 +0100 Message-Id: <20211125233559.34575-2-zimon.toutoune@gmail.com> X-Mailer: git-send-email 2.32.0 In-Reply-To: <20211125233559.34575-1-zimon.toutoune@gmail.com> References: <20211125233559.34575-1-zimon.toutoune@gmail.com> MIME-Version: 1.0 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+patchwork=mira.cbaines.net@gnu.org Sender: "Guix-patches" X-getmail-retrieved-from-mailbox: Patches Even providing '--procs=1' launches 2 workers which breaks some testsuite of packages; therefore set '#:parallel-tests?' to '#false' was ineffective. * guix/build/julia-build-system.scm (check): Fix unexpected behaviour from 'julia' command line option. --- guix/build/julia-build-system.scm | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/guix/build/julia-build-system.scm b/guix/build/julia-build-system.scm index f0dc419c17..af478fd4a3 100644 --- a/guix/build/julia-build-system.scm +++ b/guix/build/julia-build-system.scm @@ -112,7 +112,10 @@ (define* (check #:key tests? source inputs outputs julia-package-name (builddir (string-append out "/share/julia/")) (jobs (if parallel-tests? (number->string (parallel-job-count)) - "1"))) + "1")) + (nprocs (if parallel-tests? + (string-append "--procs=" jobs) + ""))) ;; With a patch, SOURCE_DATE_EPOCH is honored (setenv "SOURCE_DATE_EPOCH" "1") (setenv "JULIA_DEPOT_PATH" builddir) @@ -122,8 +125,7 @@ (define* (check #:key tests? source inputs outputs julia-package-name ""))) (setenv "JULIA_CPU_THREADS" jobs) (setenv "HOME" "/tmp") - (invoke "julia" "--depwarn=yes" - (string-append "--procs=" jobs) + (invoke "julia" "--depwarn=yes" nprocs (string-append builddir "loadpath/" package "/test/runtests.jl")))) #t)