diff mbox series

[bug#51783,core-updates-frozen] gnu: Complete renaming openexr to openexr-2.

Message ID 20211112064010.17943-1-mail@brendan.scot
State Accepted
Headers show
Series [bug#51783,core-updates-frozen] gnu: Complete renaming openexr to openexr-2. | expand

Checks

Context Check Description
cbaines/applying patch fail View Laminar job
cbaines/issue success View issue

Commit Message

Brendan Tildesley Nov. 12, 2021, 6:40 a.m. UTC
* gnu/packages/kde.scm (krita):[configure-flags]: d71336b2e3 missed one
reference of openexr that should have become openexr-2, breaking krita's
build. Rename it.
---
 gnu/packages/kde.scm | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Ludovic Courtès Nov. 18, 2021, 2:30 p.m. UTC | #1
Hi,

Brendan Tildesley <mail@brendan.scot> skribis:

> * gnu/packages/kde.scm (krita):[configure-flags]: d71336b2e3 missed one
> reference of openexr that should have become openexr-2, breaking krita's
> build. Rename it.
> ---
>  gnu/packages/kde.scm | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/gnu/packages/kde.scm b/gnu/packages/kde.scm
> index 2b843f163a..b74ea81b61 100644
> --- a/gnu/packages/kde.scm
> +++ b/gnu/packages/kde.scm
> @@ -471,7 +471,7 @@ (define-public krita
>       `(#:tests? #f
>         #:configure-flags
>         ,#~(list "-DBUILD_TESTING=OFF"
> -                (string-append "-DCMAKE_CXX_FLAGS=-I" #$openexr
> +                (string-append "-DCMAKE_CXX_FLAGS=-I" #$openexr-2
>                                 "/include/OpenEXR"))))

Hmm what branch are you looking at?  On today’s ‘core-updates-frozen’,
it looks like this:

       #:configure-flags
       (list "-DBUILD_TESTING=OFF"
             (string-append "-DCMAKE_CXX_FLAGS=-I"
                            (assoc-ref %build-inputs "openexr")
                            "/include/OpenEXR"))

Use of gexps would be welcome but it hasn’t landed on
‘core-updates-frozen’ AFAICS.

Ludo’.
Brendan Tildesley Nov. 20, 2021, 11:06 a.m. UTC | #2
> On 11/18/2021 3:30 PM Ludovic Courtès <ludo@gnu.org> wrote:

> Hmm what branch are you looking at?  On today’s ‘core-updates-frozen’,
> it looks like this:
> 
Sorry, I changed this in my own branch and mistook it for upstream without checking.
I think I had to do it because %build-inputs isn't defined anymore with qt-build-system
so krita fails currently.

closed
diff mbox series

Patch

diff --git a/gnu/packages/kde.scm b/gnu/packages/kde.scm
index 2b843f163a..b74ea81b61 100644
--- a/gnu/packages/kde.scm
+++ b/gnu/packages/kde.scm
@@ -471,7 +471,7 @@  (define-public krita
      `(#:tests? #f
        #:configure-flags
        ,#~(list "-DBUILD_TESTING=OFF"
-                (string-append "-DCMAKE_CXX_FLAGS=-I" #$openexr
+                (string-append "-DCMAKE_CXX_FLAGS=-I" #$openexr-2
                                "/include/OpenEXR"))))
     (native-inputs
      `(("curl" ,curl)