From patchwork Fri Nov 5 21:07:09 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Tobias Geerinckx-Rice X-Patchwork-Id: 34266 Return-Path: X-Original-To: patchwork@mira.cbaines.net Delivered-To: patchwork@mira.cbaines.net Received: by mira.cbaines.net (Postfix, from userid 113) id 1EACF27BBE3; Fri, 5 Nov 2021 21:07:14 +0000 (GMT) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on mira.cbaines.net X-Spam-Level: X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED, MAILING_LIST_MULTI,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,T_DKIM_INVALID, URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.2 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mira.cbaines.net (Postfix) with ESMTPS id C76AC27BBE1 for ; Fri, 5 Nov 2021 21:07:12 +0000 (GMT) Received: from localhost ([::1]:59144 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mj6QZ-0001pq-VN for patchwork@mira.cbaines.net; Fri, 05 Nov 2021 17:07:11 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:43446) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mj6QQ-0001pK-VJ for guix-patches@gnu.org; Fri, 05 Nov 2021 17:07:03 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:35924) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mj6QQ-00065y-Mx for guix-patches@gnu.org; Fri, 05 Nov 2021 17:07:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mj6QQ-0001e6-Hz for guix-patches@gnu.org; Fri, 05 Nov 2021 17:07:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#51619] [PATCH] gnu: linux-libre: Support the Coreboot framebuffer. Resent-From: Tobias Geerinckx-Rice Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Fri, 05 Nov 2021 21:07:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 51619 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 51619@debbugs.gnu.org Cc: leo@famulari.name X-Debbugs-Original-To: guix-patches@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.16361464156312 (code B ref -1); Fri, 05 Nov 2021 21:07:02 +0000 Received: (at submit) by debbugs.gnu.org; 5 Nov 2021 21:06:55 +0000 Received: from localhost ([127.0.0.1]:47470 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mj6QI-0001dj-FS for submit@debbugs.gnu.org; Fri, 05 Nov 2021 17:06:54 -0400 Received: from lists.gnu.org ([209.51.188.17]:60794) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mj6QG-0001dc-SE for submit@debbugs.gnu.org; Fri, 05 Nov 2021 17:06:53 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:43364) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mj6QG-0001p0-L0 for guix-patches@gnu.org; Fri, 05 Nov 2021 17:06:52 -0400 Received: from tobias.gr ([2a02:c205:2020:6054::1]:45350) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mj6QD-0005Lf-Dd for guix-patches@gnu.org; Fri, 05 Nov 2021 17:06:52 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; s=2018; bh=sUtz93IGYsWfs 7JhqU7LWvsL7Ddhle3Nwur+ec+W2Os=; h=date:subject:cc:to:from; d=tobias.gr; b=jik93A2GdXQ4HO6eoSBcIKACglm6iQ76X2sD1uNv3ocUFJFQ+bt6r2L 8efHqmkwBW1X2HbEt1kOGjUB6uhNJx7grfvM9KcP+P2CJ0iY0HoXg3mSCfClH9uNHA8QYA ikvYt3gmk56df858vIyM9C8zdVs+6MquVyPmAjv0RBOQlxMllLhPO4oQqq93+cFXympkTF 7EVuFQUle0rh+6xFhP2Pbm4+GnMXshzye6Zhxeo9EnX5uFtibV7MuS31ACMAWSolyjFLCR 2KveeaZRRvhBajyes5Rp8UvULV9DIQ6in3Zt4Ad8luXrPpDFG/QfZFyHUpIqv/R59+Vx8+ T10Jnlw== Received: by submission.tobias.gr (OpenSMTPD) with ESMTPSA id 1b155e2a (TLSv1.3:AEAD-AES256-GCM-SHA384:256:NO); Fri, 5 Nov 2021 21:06:42 +0000 (UTC) Date: Fri, 5 Nov 2021 22:07:09 +0100 Message-Id: <20211105210709.7985-1-me@tobias.gr> X-Mailer: git-send-email 2.33.1 MIME-Version: 1.0 Received-SPF: pass client-ip=2a02:c205:2020:6054::1; envelope-from=me@tobias.gr; helo=tobias.gr X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+patchwork=mira.cbaines.net@gnu.org Sender: "Guix-patches" Reply-to: Tobias Geerinckx-Rice X-ACL-Warn: , Tobias Geerinckx-Rice via Guix-patches X-Patchwork-Original-From: Tobias Geerinckx-Rice via Guix-patches via From: Tobias Geerinckx-Rice X-getmail-retrieved-from-mailbox: Patches * gnu/packages/aux-files/linux-libre/5.10-i686.conf, gnu/packages/aux-files/linux-libre/5.10-x86_64.conf, gnu/packages/aux-files/linux-libre/5.14-i686.conf, gnu/packages/aux-files/linux-libre/5.14-x86_64.conf: Mark simple framebuffers as generic system ones and enable ‘Google’ firmware drivers to enable Coreboot table support and its dependent framebuffer driver. --- Guix, This option is very important on Corebooted and presumably Librebooted machines. I strongly suspect that its absence has left ajarara in #guix unable to fix a Guix System that fails to boot. I don't believe that enabling it has any drawbacks for us. Without it, the kernel has no access to the framebuffer (the contents of the screen) from the moment it is booted by GRUB until the often modular, full-featured DRM graphics driver (e.g., i915) is loaded. This normally just means that your GRUB background remains on screen for a second or two after booting — which may actually be a visual improvement over flashing text output or flickering. However, things start hitting the fan if something goes wrong before the DRM driver can be loaded. The kernel has no control over the screen and the system appears to freeze without an error message. ‘Say Y.’ Kind regards, T G-R PS: I will not be enabling these for older or non-x86 kernels as I'm not as comfy with their internals. gnu/packages/aux-files/linux-libre/5.10-i686.conf | 10 ++++++++-- gnu/packages/aux-files/linux-libre/5.10-x86_64.conf | 10 ++++++++-- gnu/packages/aux-files/linux-libre/5.14-i686.conf | 12 +++++++++--- gnu/packages/aux-files/linux-libre/5.14-x86_64.conf | 12 +++++++++--- 4 files changed, 34 insertions(+), 10 deletions(-) diff --git a/gnu/packages/aux-files/linux-libre/5.10-i686.conf b/gnu/packages/aux-files/linux-libre/5.10-i686.conf index cb1fdc37ad..f9c033c5e9 100644 --- a/gnu/packages/aux-files/linux-libre/5.10-i686.conf +++ b/gnu/packages/aux-files/linux-libre/5.10-i686.conf @@ -650,7 +650,7 @@ CONFIG_ALIX=y CONFIG_NET5501=y CONFIG_GEOS=y CONFIG_AMD_NB=y -# CONFIG_X86_SYSFB is not set +CONFIG_X86_SYSFB=y # end of Bus options (PCI etc.) # @@ -674,7 +674,13 @@ CONFIG_ISCSI_IBFT_FIND=y CONFIG_ISCSI_IBFT=m CONFIG_FW_CFG_SYSFS=m # CONFIG_FW_CFG_SYSFS_CMDLINE is not set -# CONFIG_GOOGLE_FIRMWARE is not set +CONFIG_GOOGLE_FIRMWARE=y +# CONFIG_GOOGLE_SMI is not set +CONFIG_GOOGLE_COREBOOT_TABLE=y +# CONFIG_GOOGLE_MEMCONSOLE_X86_LEGACY is not set +CONFIG_GOOGLE_FRAMEBUFFER_COREBOOT=y +# CONFIG_GOOGLE_MEMCONSOLE_COREBOOT is not set +# CONFIG_GOOGLE_VPD is not set # # EFI (Extensible Firmware Interface) Support diff --git a/gnu/packages/aux-files/linux-libre/5.10-x86_64.conf b/gnu/packages/aux-files/linux-libre/5.10-x86_64.conf index cd61860af9..accc084796 100644 --- a/gnu/packages/aux-files/linux-libre/5.10-x86_64.conf +++ b/gnu/packages/aux-files/linux-libre/5.10-x86_64.conf @@ -643,7 +643,7 @@ CONFIG_MMCONF_FAM10H=y # CONFIG_ISA_BUS is not set CONFIG_ISA_DMA_API=y CONFIG_AMD_NB=y -# CONFIG_X86_SYSFB is not set +CONFIG_X86_SYSFB=y # end of Bus options (PCI etc.) # @@ -670,7 +670,13 @@ CONFIG_ISCSI_IBFT_FIND=y CONFIG_ISCSI_IBFT=m CONFIG_FW_CFG_SYSFS=m # CONFIG_FW_CFG_SYSFS_CMDLINE is not set -# CONFIG_GOOGLE_FIRMWARE is not set +CONFIG_GOOGLE_FIRMWARE=y +# CONFIG_GOOGLE_SMI is not set +CONFIG_GOOGLE_COREBOOT_TABLE=y +# CONFIG_GOOGLE_MEMCONSOLE_X86_LEGACY is not set +CONFIG_GOOGLE_FRAMEBUFFER_COREBOOT=y +# CONFIG_GOOGLE_MEMCONSOLE_COREBOOT is not set +# CONFIG_GOOGLE_VPD is not set # # EFI (Extensible Firmware Interface) Support diff --git a/gnu/packages/aux-files/linux-libre/5.14-i686.conf b/gnu/packages/aux-files/linux-libre/5.14-i686.conf index bcca80c348..946992c734 100644 --- a/gnu/packages/aux-files/linux-libre/5.14-i686.conf +++ b/gnu/packages/aux-files/linux-libre/5.14-i686.conf @@ -663,7 +663,7 @@ CONFIG_ALIX=y CONFIG_NET5501=y CONFIG_GEOS=y CONFIG_AMD_NB=y -# CONFIG_X86_SYSFB is not set +CONFIG_X86_SYSFB=y # end of Bus options (PCI etc.) # @@ -687,7 +687,13 @@ CONFIG_ISCSI_IBFT_FIND=y CONFIG_ISCSI_IBFT=m CONFIG_FW_CFG_SYSFS=m # CONFIG_FW_CFG_SYSFS_CMDLINE is not set -# CONFIG_GOOGLE_FIRMWARE is not set +CONFIG_GOOGLE_FIRMWARE=y +# CONFIG_GOOGLE_SMI is not set +CONFIG_GOOGLE_COREBOOT_TABLE=y +# CONFIG_GOOGLE_MEMCONSOLE_X86_LEGACY is not set +CONFIG_GOOGLE_FRAMEBUFFER_COREBOOT=y +# CONFIG_GOOGLE_MEMCONSOLE_COREBOOT is not set +# CONFIG_GOOGLE_VPD is not set # # EFI (Extensible Firmware Interface) Support @@ -6551,7 +6557,7 @@ CONFIG_DRM_ANALOGIX_DP=m # CONFIG_DRM_ETNAVIV is not set CONFIG_DRM_CIRRUS_QEMU=m CONFIG_DRM_GM12U320=m -CONFIG_DRM_SIMPLEDRM=m +# CONFIG_DRM_SIMPLEDRM is not set CONFIG_TINYDRM_HX8357D=m CONFIG_TINYDRM_ILI9225=m CONFIG_TINYDRM_ILI9341=m diff --git a/gnu/packages/aux-files/linux-libre/5.14-x86_64.conf b/gnu/packages/aux-files/linux-libre/5.14-x86_64.conf index 844420becd..5a0192b991 100644 --- a/gnu/packages/aux-files/linux-libre/5.14-x86_64.conf +++ b/gnu/packages/aux-files/linux-libre/5.14-x86_64.conf @@ -655,7 +655,7 @@ CONFIG_MMCONF_FAM10H=y # CONFIG_ISA_BUS is not set CONFIG_ISA_DMA_API=y CONFIG_AMD_NB=y -# CONFIG_X86_SYSFB is not set +CONFIG_X86_SYSFB=y # end of Bus options (PCI etc.) # @@ -682,7 +682,13 @@ CONFIG_ISCSI_IBFT_FIND=y CONFIG_ISCSI_IBFT=m CONFIG_FW_CFG_SYSFS=m # CONFIG_FW_CFG_SYSFS_CMDLINE is not set -# CONFIG_GOOGLE_FIRMWARE is not set +CONFIG_GOOGLE_FIRMWARE=y +# CONFIG_GOOGLE_SMI is not set +CONFIG_GOOGLE_COREBOOT_TABLE=y +# CONFIG_GOOGLE_MEMCONSOLE_X86_LEGACY is not set +CONFIG_GOOGLE_FRAMEBUFFER_COREBOOT=y +# CONFIG_GOOGLE_MEMCONSOLE_COREBOOT is not set +# CONFIG_GOOGLE_VPD is not set # # EFI (Extensible Firmware Interface) Support @@ -6511,7 +6517,7 @@ CONFIG_DRM_ANALOGIX_DP=m # CONFIG_DRM_ETNAVIV is not set CONFIG_DRM_CIRRUS_QEMU=m CONFIG_DRM_GM12U320=m -CONFIG_DRM_SIMPLEDRM=m +# CONFIG_DRM_SIMPLEDRM is not set CONFIG_TINYDRM_HX8357D=m CONFIG_TINYDRM_ILI9225=m CONFIG_TINYDRM_ILI9341=m