diff mbox series

[bug#51566,v2] guix: import: Add more licenses and extend their detection.

Message ID 20211102105728.18771-1-attila@lendvai.name
State Accepted
Headers show
Series [bug#51566,v2] guix: import: Add more licenses and extend their detection. | expand

Checks

Context Check Description
cbaines/comparison success View comparision
cbaines/git branch success View Git branch
cbaines/applying patch success View Laminar job
cbaines/issue success View issue

Commit Message

Attila Lendvai Nov. 2, 2021, 10:57 a.m. UTC 
Add a comment that mentions "MIT" so that people who grep for MIT end up there.

* guix/import/utils.scm (spdx-string->license): Identify more
licenses (CC-BY-4.0, Freetype, HPND).
---

i have deleted the problematic JSON license.

i have also opened an issue at the problematic project:
https://issues.apache.org/jira/browse/ARROW-14550

 guix/import/utils.scm | 3 +++
 guix/licenses.scm     | 2 ++
 2 files changed, 5 insertions(+)

Comments

Ludovic Courtès Nov. 12, 2021, 10:35 p.m. UTC | #1 
Hi,

Attila Lendvai <attila@lendvai.name> skribis:

> Add a comment that mentions "MIT" so that people who grep for MIT end up there.
>
> * guix/import/utils.scm (spdx-string->license): Identify more
> licenses (CC-BY-4.0, Freetype, HPND).

I tweaked the commit log and applied.

> i have deleted the problematic JSON license.

You did well!

> i have also opened an issue at the problematic project:
> https://issues.apache.org/jira/browse/ARROW-14550

Perfect.

Thank you,
Ludo’.
diff mbox series

Patch

diff --git a/guix/import/utils.scm b/guix/import/utils.scm
index a180742ca3..dc89386ddb 100644
--- a/guix/import/utils.scm
+++ b/guix/import/utils.scm
@@ -152,6 +152,7 @@  (define (spdx-string->license str)
     ("CC0-1.0"                     'license:cc0)
     ("CC-BY-2.0"                   'license:cc-by2.0)
     ("CC-BY-3.0"                   'license:cc-by3.0)
+    ("CC-BY-4.0"                   'license:cc-by4.0)
     ("CC-BY-SA-2.0"                'license:cc-by-sa2.0)
     ("CC-BY-SA-3.0"                'license:cc-by-sa3.0)
     ("CC-BY-SA-4.0"                'license:cc-by-sa4.0)
@@ -163,6 +164,7 @@  (define (spdx-string->license str)
     ("EPL-1.0"                     'license:epl1.0)
     ("MIT"                         'license:expat)
     ("FTL"                         'license:freetype)
+    ("Freetype"                    'license:freetype)
     ("GFDL-1.1"                    'license:fdl1.1+)
     ("GFDL-1.2"                    'license:fdl1.2+)
     ("GFDL-1.3"                    'license:fdl1.3+)
@@ -179,6 +181,7 @@  (define (spdx-string->license str)
     ("GPL-3.0-only"                'license:gpl3)
     ("GPL-3.0+"                    'license:gpl3+)
     ("GPL-3.0-or-later"            'license:gpl3+)
+    ("HPND"                        'license:hpnd)
     ("ISC"                         'license:isc)
     ("IJG"                         'license:ijg)
     ("Imlib2"                      'license:imlib2)
diff --git a/guix/licenses.scm b/guix/licenses.scm
index c071aae4a9..82ca44f42e 100644
--- a/guix/licenses.scm
+++ b/guix/licenses.scm
@@ -308,6 +308,8 @@  (define eupl1.2
            "https://directory.fsf.org/wiki/License:EUPL-1.2"
            "https://www.gnu.org/licenses/license-list#EUPL-1.2"))
 
+;; Some people call it the MIT license. For clarification see:
+;; https://www.gnu.org/licenses/license-list.html#Expat
 (define expat
   (license "Expat"
            "http://directory.fsf.org/wiki/License:Expat"