| Message ID | 20211009152820.294764-6-monego@posteo.net |
|---|---|
| State | Accepted |
| Headers | show |
| Series | [bug#51085,v2,1/7] gnu: Add libkeyfinder. | expand |
| Context | Check | Description |
|---|---|---|
| cbaines/comparison | success | View comparision |
| cbaines/git branch | success | View Git branch |
| cbaines/applying patch | success | View Laminar job |
| cbaines/issue | success | View issue |
| cbaines/comparison | success | View comparision |
| cbaines/git branch | success | View Git branch |
| cbaines/applying patch | success | View Laminar job |
| cbaines/issue | success | View issue |
| cbaines/comparison | success | View comparision |
| cbaines/git branch | success | View Git branch |
| cbaines/applying patch | success | View Laminar job |
| cbaines/issue | success | View issue |
| cbaines/comparison | success | View comparision |
| cbaines/git branch | success | View Git branch |
| cbaines/applying patch | success | View Laminar job |
| cbaines/issue | success | View issue |
| cbaines/comparison | success | View comparision |
| cbaines/git branch | success | View Git branch |
| cbaines/comparison | success | View comparision |
| cbaines/git branch | success | View Git branch |
| cbaines/applying patch | success | View Laminar job |
| cbaines/issue | success | View issue |
| cbaines/applying patch | success | View Laminar job |
| cbaines/issue | success | View issue |
Thanks for these patches! I've hoped for a Mixxx Guix package for a long time. The patches look good to me overall, but I have a couple questions: On Sat, Oct 09, 2021 at 03:28:19PM +0000, Vinicius Monego wrote: > * gnu/packages/audio.scm (mp3guessenc): New variable. > + (list (string-append "PREFIX=" (assoc-ref %outputs "out")) > + (string-append "SUFFIX=")) What is SUFFIX? That string doesn't appear in the mp3guessenc source code.
Em seg, 2021-10-11 às 17:55 -0400, Leo Famulari escreveu: > Thanks for these patches! I've hoped for a Mixxx Guix package for a > long > time. > > The patches look good to me overall, but I have a couple questions: > > On Sat, Oct 09, 2021 at 03:28:19PM +0000, Vinicius Monego wrote: > > * gnu/packages/audio.scm (mp3guessenc): New variable. > > > + (list (string-append "PREFIX=" (assoc-ref %outputs "out")) > > + (string-append "SUFFIX=")) > > What is SUFFIX? That string doesn't appear in the mp3guessenc source > code. Oh I copied that part from another package and didn't adjust. SUFFIX can be removed.
diff --git a/gnu/packages/audio.scm b/gnu/packages/audio.scm index 6c0318db9d..47c37643f6 100644 --- a/gnu/packages/audio.scm +++ b/gnu/packages/audio.scm @@ -4060,6 +4060,34 @@ machine-readable ASCII format.") (home-page "https://github.com/svend/cuetools") (license license:gpl2+))) +(define-public mp3guessenc + (package + (name "mp3guessenc") + (version "0.27.5") + (source + (origin + (method url-fetch) + (uri (string-append "mirror://sourceforge/mp3guessenc/mp3guessenc-" + (version-major+minor version) "/mp3guessenc-" + version ".tar.gz")) + (sha256 + (base32 "1fa3sbwwn4p2v1749lzy040bfy1xfd574mf2frwgg9ikgk3vlb3c")))) + (build-system gnu-build-system) + (arguments + `(#:tests? #f ; no tests + #:make-flags + (list (string-append "PREFIX=" (assoc-ref %outputs "out")) + (string-append "SUFFIX=")) + #:phases + (modify-phases %standard-phases + (delete 'configure)))) ; no configure phase + (home-page "https://mp3guessenc.sourceforge.io") + (synopsis "Detect the encoder used for a mpeg layer III") + (description "This command line utility was born to detect the encoder +used for a mpeg layer III file but now it can do more and scan any mpeg +audio file (any layer) and print a lot of useful information.") + (license license:lgpl2.1+))) + (define-public shntool (package (name "shntool")