From patchwork Thu Sep 23 17:59:50 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tobias Geerinckx-Rice X-Patchwork-Id: 33262 Return-Path: X-Original-To: patchwork@mira.cbaines.net Delivered-To: patchwork@mira.cbaines.net Received: by mira.cbaines.net (Postfix, from userid 113) id BADB927BBE3; Thu, 23 Sep 2021 19:00:36 +0100 (BST) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on mira.cbaines.net X-Spam-Level: X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED, MAILING_LIST_MULTI,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,T_DKIM_INVALID, URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.2 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mira.cbaines.net (Postfix) with ESMTPS id CA7E927BBE1 for ; Thu, 23 Sep 2021 19:00:35 +0100 (BST) Received: from localhost ([::1]:60804 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mTT1O-0000Z1-N3 for patchwork@mira.cbaines.net; Thu, 23 Sep 2021 14:00:34 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:52954) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mTT0t-0000Xm-06 for guix-patches@gnu.org; Thu, 23 Sep 2021 14:00:03 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:44254) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mTT0s-0005Cu-NH for guix-patches@gnu.org; Thu, 23 Sep 2021 14:00:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mTT0s-0000kf-FP for guix-patches@gnu.org; Thu, 23 Sep 2021 14:00:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#50768] [PATCH] installer: Reorder file system type listbox. Resent-From: Tobias Geerinckx-Rice Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Thu, 23 Sep 2021 18:00:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 50768 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 50768@debbugs.gnu.org X-Debbugs-Original-To: guix-patches@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.16324199962845 (code B ref -1); Thu, 23 Sep 2021 18:00:02 +0000 Received: (at submit) by debbugs.gnu.org; 23 Sep 2021 17:59:56 +0000 Received: from localhost ([127.0.0.1]:55800 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mTT0m-0000jo-1u for submit@debbugs.gnu.org; Thu, 23 Sep 2021 13:59:56 -0400 Received: from lists.gnu.org ([209.51.188.17]:35642) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mTT0l-0000ja-5N for submit@debbugs.gnu.org; Thu, 23 Sep 2021 13:59:55 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:52908) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mTT0k-0000Ja-QZ for guix-patches@gnu.org; Thu, 23 Sep 2021 13:59:54 -0400 Received: from tobias.gr ([2a02:c205:2020:6054::1]:59872) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mTT0i-0004yq-DL for guix-patches@gnu.org; Thu, 23 Sep 2021 13:59:54 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; s=2018; bh=hIAGlE4TSiBnP mp/kxhod9qhzDMjHGtF0K3mu74bUaI=; h=date:subject:to:from; d=tobias.gr; b=EK77ClHPMi2iBCP6gPxbMMSGO+a/o2o0iReBa1xapxFViu9oq6Zb/4vKiwCWWEx0sOHx ndZ2WiU0Qce7BYlrX8rjP2M371QnxN/zEb33Y2oI8W5FdOvvTOX9UnwLKfBMunazxnDqua yxwmXgYVWlVk7d/ecKs+p++Z+xQvQivHCuiU6PHJOfD1wEuuQCLiYqlGyVUuL5Q8+oGcCo RsMlOiXbx28mfUI4bJ1DC49vBgkq85vpX1pPsqzwgSnoabCtKxCS5kpL/PV2LR6sp/v3K1 4xsLhlS9BH3fVR9DQZcqN8y/YVdxbjHPfxGA7UNJPt9zEU1LSIcJZBt+paD1/X+w== Received: by submission.tobias.gr (OpenSMTPD) with ESMTPSA id cb73e9e9 (TLSv1.3:AEAD-AES256-GCM-SHA384:256:NO) for ; Thu, 23 Sep 2021 17:59:45 +0000 (UTC) Date: Thu, 23 Sep 2021 19:59:50 +0200 Message-Id: <20210923175950.13586-1-me@tobias.gr> X-Mailer: git-send-email 2.33.0 MIME-Version: 1.0 Received-SPF: pass client-ip=2a02:c205:2020:6054::1; envelope-from=me@tobias.gr; helo=tobias.gr X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+patchwork=mira.cbaines.net@gnu.org Sender: "Guix-patches" Reply-to: Tobias Geerinckx-Rice X-ACL-Warn: , Tobias Geerinckx-Rice via Guix-patches X-Patchwork-Original-From: Tobias Geerinckx-Rice via Guix-patches via From: Tobias Geerinckx-Rice X-getmail-retrieved-from-mailbox: Patches Recommending ext4 over btrfs is probably ill-advised nowadays. See the regular bug reports about running out of /gnu/store directory entries, for which the documented fix then breaks booting with GRUB. Instead, just list regular file systems alphabetically. We can bikeshed bcachefs later ;-) Move second-class file systems like NTFS to their own section at the end of the list. * gnu/packages/package-management.scm (run-fs-type-page): Reorder the LISTBOX-ITEMS. --- gnu/installer/newt/partition.scm | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/gnu/installer/newt/partition.scm b/gnu/installer/newt/partition.scm index ea524eb4c3..70c11ed8ad 100644 --- a/gnu/installer/newt/partition.scm +++ b/gnu/installer/newt/partition.scm @@ -119,31 +119,35 @@ Be careful, all data on the disk will be lost.") '(extended))))) (run-listbox-selection-page #:info-text (G_ "Please select a partition type.") #:title (G_ "Partition type") #:listbox-items items #:listbox-item->text symbol->string #:sort-listbox-items? #f #:button-text (G_ "Exit") #:button-callback-procedure button-exit-action))) (define (run-fs-type-page) "Run a page asking the user to select a file-system type." (run-listbox-selection-page #:info-text (G_ "Please select the file-system type for this partition.") #:title (G_ "File-system type") - #:listbox-items '(ext4 btrfs fat16 fat32 jfs ntfs xfs swap) + #:listbox-items '(btrfs ext4 jfs xfs + swap + ;; These lack basic Unix features. Their only use + ;; on GNU is for interoperation, e.g., with UEFI. + fat32 fat16 ntfs) #:listbox-item->text user-fs-type-name #:sort-listbox-items? #f #:button-text (G_ "Exit") #:button-callback-procedure button-exit-action)) (define (inform-can-create-partition? user-partition) "Return #t if it is possible to create USER-PARTITION. This is determined by calling CAN-CREATE-PARTITION? procedure. If an exception is raised, catch it an inform the user with an appropriate error-page and return #f." (guard (c ((max-primary-exceeded? c) (run-error-page (G_ "Primary partitions count exceeded.") (G_ "Creation error")) #f) ((extended-creation-error? c)