diff mbox series

[bug#50114] gnu: mc: Bump up to 4.8.27

Message ID 20210820224814.18887194@zn3
State Accepted
Headers show
Series [bug#50114] gnu: mc: Bump up to 4.8.27 | expand

Checks

Context Check Description
cbaines/applying patch fail View Laminar job
cbaines/issue success View issue

Commit Message

Sergei Trofimovich Aug. 20, 2021, 9:48 p.m. UTC 
On Fri, 20 Aug 2021 11:29:18 +0200
zimoun <zimon.toutoune@gmail.com> wrote:

> ... Usually, the header is:
>   gnu: mc: Update to 4.8.27.

Updated in v2-0001-gnu-mc-Update-to-4.8.27.patch (attached).

> On Wed, 18 Aug 2021 at 23:42, Sergei Trofimovich <slyich@gmail.com> wrote:
> > While at it added 'release-monitoing-url property to allow
> > 'generic-html updater to fetch latest version from correct location.
> > Otherwise the only available updater is 'gnu-ftp (which forces downgrade
> > to ancient 4.6.1 release).
> >
> > * gnu/packages/mc.scm (mc): Update to 4.8.27. Explicitly set
> > release-monitoing-url to up to date location.
> > ---
> >  gnu/packages/mc.scm | 8 +++++---
> >  1 file changed, 5 insertions(+), 3 deletions(-)
> >
> > diff --git a/gnu/packages/mc.scm b/gnu/packages/mc.scm
> > index b9dea3b446..e19bc02e7a 100644
> > --- a/gnu/packages/mc.scm
> > +++ b/gnu/packages/mc.scm
> > @@ -38,14 +38,14 @@
> >  (define-public mc
> >    (package
> >      (name "mc")
> > -    (version "4.8.26")
> > +    (version "4.8.27")
> >      (source
> >       (origin
> >        (method url-fetch)
> > -      (uri (string-append "https://ftp.midnight-commander.org/mc-"
> > +      (uri (string-append "http://ftp.midnight-commander.org/mc-"
> >                            version ".tar.xz"))  
> 
> I get with HTTPS:
> 
> --8<---------------cut here---------------start------------->8---
> Starting download of /tmp/guix-file.hccu6E
> From https://ftp.midnight-commander.org/mc-4.8.27.tar.xz...
> X.509 server certificate for 'ftp.midnight-commander.org' does not match: C=US,postalCode=97331,ST=Oregon,L=Corvallis,street=121 Valley Library,O=Oregon State University,OU=CASS,CN=*.osuosl.org
> --8<---------------cut here---------------end--------------->8---
> 
> Maybe, is it fixable?

I was on the fence of this: either use http://, but a link from home page
which redirects to osuosl mirror, or use direct osuosl mirror link that
provides https://. Switced to https:// osuosl link in
v2-0001-gnu-mc-Update-to-4.8.27.patch

Comments

Brice Waegeneire Aug. 26, 2021, 7:29 p.m. UTC | #1 
Hello Sergei,

Thank you for the patch. The new source domain is referenced by upstream in
doc/MIRRORS.txt¹.

Pushed as d1d9206180763f8291c82b1a6240b3640bd4f238.

¹ https://github.com/MidnightCommander/mc/blob/0aaf74777d65ac2539b73c14d2e4e2baecb13451/doc/MIRRORS.txt#L7

Cheers,
- Brice
diff mbox series

Patch

From 18b3de9bb72e31e40938332eccf13e86f4f5cd00 Mon Sep 17 00:00:00 2001
From: Sergei Trofimovich <slyich@gmail.com>
Date: Wed, 18 Aug 2021 23:39:20 +0100
Subject: [PATCH v2] gnu: mc: Update to 4.8.27.

Switched to direct mirror URI to match SSL certificate issuer
(home page does not provide a download link over secure protocols).

While at it added 'release-monitoing-url property to allow
'generic-html updater to fetch latest version from correct location.
Otherwise the only available updater is 'gnu-ftp (which forces downgrade
to ancient 4.6.1 release).

* gnu/packages/mc.scm (mc): Update to 4.8.27. Explicitly set
release-monitoing-url to up to date location.
---
 gnu/packages/mc.scm | 8 +++++---
 1 file changed, 5 insertions(+), 3 deletions(-)

diff --git a/gnu/packages/mc.scm b/gnu/packages/mc.scm
index b9dea3b446..e07191e344 100644
--- a/gnu/packages/mc.scm
+++ b/gnu/packages/mc.scm
@@ -38,14 +38,14 @@ 
 (define-public mc
   (package
     (name "mc")
-    (version "4.8.26")
+    (version "4.8.27")
     (source
      (origin
       (method url-fetch)
-      (uri (string-append "https://ftp.midnight-commander.org/mc-"
+      (uri (string-append "https://ftp.osuosl.org/pub/midnightcommander/mc-"
                           version ".tar.xz"))
       (sha256
-       (base32 "09vc2vf6k12a8k5gdss6hcskwfcbyalrkhn65nidkwlm0p2svpn6"))))
+       (base32 "1x2g5ahgzg951y4ldbsgkv8icni2mgh3p2wsds0j16gsbwi5kgii"))))
     (build-system gnu-build-system)
     (native-inputs `(("perl" ,perl)
                      ("pkg-config" ,pkg-config)))
@@ -97,6 +97,8 @@ 
                (("usr/bin") "/"))
              #t)))))
     (home-page "https://www.midnight-commander.org")
+    (properties
+      `((release-monitoring-url . "https://ftp.osuosl.org/pub/midnightcommander/")))
     (synopsis "Graphical file manager")
     (description
      "GNU Midnight Commander is a command-line file manager laid out in a
-- 
2.33.0