From patchwork Wed Aug 18 17:37:39 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Sarah Morgensen X-Patchwork-Id: 32175 Return-Path: X-Original-To: patchwork@mira.cbaines.net Delivered-To: patchwork@mira.cbaines.net Received: by mira.cbaines.net (Postfix, from userid 113) id 3F20327BC78; Wed, 18 Aug 2021 18:38:16 +0100 (BST) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on mira.cbaines.net X-Spam-Level: X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED, MAILING_LIST_MULTI,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,T_DKIM_INVALID, URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.2 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mira.cbaines.net (Postfix) with ESMTPS id E5CA727BC6B for ; Wed, 18 Aug 2021 18:38:15 +0100 (BST) Received: from localhost ([::1]:60148 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mGPW2-00047I-VK for patchwork@mira.cbaines.net; Wed, 18 Aug 2021 13:38:14 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:34186) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mGPVq-00046B-Ma for guix-patches@gnu.org; Wed, 18 Aug 2021 13:38:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:45966) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mGPVq-000453-Fh for guix-patches@gnu.org; Wed, 18 Aug 2021 13:38:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mGPVq-0003Xo-EF for guix-patches@gnu.org; Wed, 18 Aug 2021 13:38:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#50111] [PATCH] cuirass: Allow filter-only searches. Resent-From: Sarah Morgensen Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Wed, 18 Aug 2021 17:38:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 50111 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 50111@debbugs.gnu.org X-Debbugs-Original-To: guix-patches@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.162930827913614 (code B ref -1); Wed, 18 Aug 2021 17:38:02 +0000 Received: (at submit) by debbugs.gnu.org; 18 Aug 2021 17:37:59 +0000 Received: from localhost ([127.0.0.1]:57512 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mGPVj-0003XS-GY for submit@debbugs.gnu.org; Wed, 18 Aug 2021 13:37:59 -0400 Received: from lists.gnu.org ([209.51.188.17]:47318) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mGPVe-0003XD-0r for submit@debbugs.gnu.org; Wed, 18 Aug 2021 13:37:54 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:34128) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mGPVd-0003rg-Mt for guix-patches@gnu.org; Wed, 18 Aug 2021 13:37:49 -0400 Received: from out1.migadu.com ([2001:41d0:2:863f::]:27574) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mGPVb-0003mO-3T for guix-patches@gnu.org; Wed, 18 Aug 2021 13:37:49 -0400 X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mgsn.dev; s=key1; t=1629308263; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=do35E1B/ZQ6hK3l+qp7d636s6JtqMOyB+aEoVQJNgyM=; b=GrgCfbrop73h+/CIQQAZCB3wSDJwYnX0Q/gK9eqNqRa+dttP1t8+EzM/uAbNRtuZu1ABXk Xvus+4zQ+KPdSSEHkDEhxp4i1jeIFKeE8FNlJVP9WZClJopI8gphFBcu4lVZ1wzEz9WU4F 38lMMvxpNU6RhUUw9ep6hsDEpsPOYLM= From: Sarah Morgensen Date: Wed, 18 Aug 2021 10:37:39 -0700 Message-Id: <20210818173740.17581-1-iskarian@mgsn.dev> MIME-Version: 1.0 X-Migadu-Flow: FLOW_OUT X-Migadu-Auth-User: iskarian@mgsn.dev Received-SPF: pass client-ip=2001:41d0:2:863f::; envelope-from=iskarian@mgsn.dev; helo=out1.migadu.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+patchwork=mira.cbaines.net@gnu.org Sender: "Guix-patches" X-getmail-retrieved-from-mailbox: Patches If there are non-query search filters and there is no query, assume a wildcard query. * src/cuirass/database.scm (query->bind-arguments): Add a wildcard query if there are other filters and no query. --- Hello Guix, I noticed that it's not possible to search on cuirass with only filters, and no query. So this patch allows a filter-only search, without a query. (After reading the code I realized I could use a SQL (!) wildcard "%", but that's not even noted on the Cuirass website.) I haven't tested this, of course, because I don't have a cuirass instance ;) -- Sarah src/cuirass/database.scm | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/cuirass/database.scm b/src/cuirass/database.scm index 0aa3f0b..2aa99a1 100644 --- a/src/cuirass/database.scm +++ b/src/cuirass/database.scm @@ -5,6 +5,7 @@ ;;; Copyright © 2018 Clément Lassieur ;;; Copyright © 2018 Tatiana Sholokhova ;;; Copyright © 2019, 2020 Ricardo Wurmus +;;; Copyright © 2021 Sarah Morgensen ;;; ;;; This file is part of Cuirass. ;;; @@ -1060,7 +1061,11 @@ DELETE FROM Checkouts WHERE evaluation=" eval-id ";"))) (if (assq key acc) acc (cons (cons key #f) acc))) - args '(#:spec #:system)))) + (if (or (assq-ref args #:query) + (null? (alist-delete #:query args))) + args + (cons '(#:query . "%") args)) + '(#:spec #:system)))) (define (db-get-build-products build-id) "Return the build products associated to the given BUILD-ID."