| Message ID | 20210720213417.5285-1-maximedevos@telenet.be |
|---|---|
| State | Accepted |
| Headers | show |
| Series | [bug#49659,v2\,core-updates,v2] gnu: guile: Fix failing tests on i686-linux. | expand |
| Context | Check | Description |
|---|---|---|
| cbaines/applying patch | fail | View Laminar job |
| cbaines/issue | success | View issue |
Hi, Maxime Devos <maximedevos@telenet.be> skribis: > i586-gnu might have the same issue. > > * gnu/packages/guile.scm (guile-3.0)[arguments]<#:configure-flags>: > Add "-fexcess-precision=standard" to CFLAGS when > (target-x86-32?) is true. > > Fixes: <https://issues.guix.gnu.org/49368>. I tweaked the commit log and pushed as fccc0275091af10a46471c68df525d19f446af9e. Looks like we should be able to move forward with this branch now, thank you! Ludo’.
Hey, > I tweaked the commit log and pushed as > fccc0275091af10a46471c68df525d19f446af9e. > > Looks like we should be able to move forward with this branch now, > thank you! Thanks for taking care of that Maxime & Ludo :). Should we create a core-updates-frozen branch that Cuirass would build for the "all" subset? I can take care of that if so. Mathieu
Hi, Mathieu Othacehe <othacehe@gnu.org> skribis: >> I tweaked the commit log and pushed as >> fccc0275091af10a46471c68df525d19f446af9e. >> >> Looks like we should be able to move forward with this branch now, >> thank you! > > Thanks for taking care of that Maxime & Ludo :). Should we create a > core-updates-frozen branch that Cuirass would build for the "all" > subset? I can take care of that if so. There are “two last things” to check IMO: 1. Make sure powerpc64le-linux is in a good state. Can we get it built? (We discussed adding a worker on the OSUOSL machine but I think we eventually dropped the ball.) 2. <https://issues.guix.gnu.org/49597> will trigger rebuilds. I was waiting before applying it so we get several people looking into it; Maxime had valid criticism, I’m interested in hearing from others too. :-) Once we’re OK on these two fronts, let’s branch ‘core-updates-frozen’ and unleash our package-fixing superpowers! Ludo’.
Ludovic Courtès schreef op vr 23-07-2021 om 11:07 [+0200]: > Hi, > > Mathieu Othacehe <othacehe@gnu.org> skribis: > > > > I tweaked the commit log and pushed as > > > fccc0275091af10a46471c68df525d19f446af9e. > > > > > > Looks like we should be able to move forward with this branch now, > > > thank you! > > > > Thanks for taking care of that Maxime & Ludo :). Should we create a > > core-updates-frozen branch that Cuirass would build for the "all" > > subset? I can take care of that if so. > > There are “two last things” to check IMO: [...] For --target=x86_64-w64-mingw32, the patch <https://issues.guix.gnu.org/49694> is required, to fix a build failure of x86_64-w64-mingw32-binutils. Greetings, Maxime.
Hello, Em sexta-feira, 23 de julho de 2021, às 06:07:45 -03, Ludovic Courtès escreveu: > Hi, > > Mathieu Othacehe <othacehe@gnu.org> skribis: > >> I tweaked the commit log and pushed as > >> fccc0275091af10a46471c68df525d19f446af9e. > >> > >> Looks like we should be able to move forward with this branch now, > >> thank you! > > > > Thanks for taking care of that Maxime & Ludo :). Should we create a > > core-updates-frozen branch that Cuirass would build for the "all" > > subset? I can take care of that if so. > > There are “two last things” to check IMO: > > 1. Make sure powerpc64le-linux is in a good state. Can we get it > built? (We discussed adding a worker on the OSUOSL machine but I > think we eventually dropped the ball.) > > 2. <https://issues.guix.gnu.org/49597> will trigger rebuilds. I was > waiting before applying it so we get several people looking into > it; Maxime had valid criticism, I’m interested in hearing from > others too. :-) > > Once we’re OK on these two fronts, let’s branch ‘core-updates-frozen’ > and unleash our package-fixing superpowers! Perhaps libdrm and Mesa could be updated before the freeze as suggested by John Kehayias¹? Or could/should that be done on a branch apart from core-updates? Not sure if that’s what Ricardo’s suggestion about creating a new branch means.
diff --git a/gnu/packages/guile.scm b/gnu/packages/guile.scm index d78c57e88c..86621e4ca0 100644 --- a/gnu/packages/guile.scm +++ b/gnu/packages/guile.scm @@ -16,6 +16,7 @@ ;;; Copyright © 2018 Eric Bavier <bavier@member.fsf.org> ;;; Copyright © 2019 Taylan Kammer <taylan.kammer@gmail.com> ;;; Copyright © 2020, 2021 Efraim Flashner <efraim@flashner.co.il> +;;; Copyright © 2021 Maxime Devos <maximedevos@telenet.be> ;;; ;;; This file is part of GNU Guix. ;;; @@ -316,11 +317,19 @@ without requiring the source code to be rewritten.") (arguments (substitute-keyword-arguments (package-arguments guile-2.2) ((#:configure-flags flags ''()) - (let ((flags `(cons "--enable-mini-gmp" ,flags))) - ;; XXX: JIT-enabled Guile crashes in obscure ways on GNU/Hurd. - (if (hurd-target?) - `(cons "--disable-jit" ,flags) - flags))) + ;; XXX: JIT-enabled Guile crashes in obscure ways on GNU/Hurd. + `(cons* ,@(if (hurd-target?) + '("--disable-jit") + '()) + ;; -fexcess-precision=standard is required when compiling for + ;; i686-linux, otherwise "numbers.test" will fail + ;; (see <https://issues.guix.gnu.org/49368> and + ;; <https://issues.guix.gnu.org/49659>). + ,@(if (target-x86-32?) + '("CFLAGS=-g -O2 -fexcess-precision=standard") + '()) + "--enable-mini-gmp" + ,flags)) ((#:phases phases) `(modify-phases ,phases (add-before 'check 'disable-stack-overflow-test