| Message ID | 20210720193129.24772-1-monego@posteo.net |
|---|---|
| State | Accepted |
| Headers | show |
| Series | [bug#49668,1/2] gnu: emacs-org-roam: Update to 2.0.0. | expand |
| Context | Check | Description |
|---|---|---|
| cbaines/applying patch | fail | View Laminar job |
| cbaines/issue | success | View issue |
Hi Vinicius, Vinicius Monego writes: > * gnu/packages/emacs-xyz.scm (emacs-org-roam): Update to 2.0.0. > [propagated-inputs]: Add emacs-magit. Given the v1 -> v2 migration requires a manual process, it might be a good idea to keep a v1 package for users that may want to stay on it for a little bit longer, what do you think? The author has kept a https://github.com/org-roam/org-roam-v1 repository for this effect. Otherwise I tested the update and it looks good to me! I was able to migrate successfully, but I don't have that many notes. Thanks, Pierre
Hi Pierre, Em ter, 2021-07-20 às 20:53 +0100, Pierre Langlois escreveu: > Given the v1 -> v2 migration requires a manual process, it might be a > good idea to keep a v1 package for users that may want to stay on it > for > a little bit longer, what do you think? The author has kept a > https://github.com/org-roam/org-roam-v1 repository for this effect. The description of that repository says "No longer actively maintained. " and the README recommends the migration. That is my main concern, introducing a package that we know for a fact that is unmaintained and don't have a schedule for removal. It feels more like a use case for a custom channel. Another option is to hold this update until 2.0.1 after v2 is more widely used, though Guix users who wish to migrate now would have to update manually in that case. I will wait for more feedback on this. Vinicius
Hi Vinicius, Vinicius Monego writes: > Hi Pierre, > > Em ter, 2021-07-20 às 20:53 +0100, Pierre Langlois escreveu: >> Given the v1 -> v2 migration requires a manual process, it might be a >> good idea to keep a v1 package for users that may want to stay on it >> for >> a little bit longer, what do you think? The author has kept a >> https://github.com/org-roam/org-roam-v1 repository for this effect. > > The description of that repository says "No longer actively maintained. > " and the README recommends the migration. That is my main concern, > introducing a package that we know for a fact that is unmaintained and > don't have a schedule for removal. It feels more like a use case for a > custom channel. That's a fair point, we might forget to ever remove the old v1 package :-). I don't have a strong opinion given I was able to migrate myself without any trouble, there was many posts in the community about the migration that made me feel we might want to be cautious. But thinking about it more now, emacs makes it easy to install packages manually, so if one really needs to stay on v1 for a bit, they can always do it outside of Guix. So you can consider my mind changed on this matter :-). Thanks, Pierre
Hello, Vinicius Monego <monego@posteo.net> writes: > * gnu/packages/emacs-xyz.scm (emacs-org-roam): Update to 2.0.0. > [propagated-inputs]: Add emacs-magit. Applied both patches. Thank you. Regards,
diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm index 41608d71e0..8b188a1d3e 100644 --- a/gnu/packages/emacs-xyz.scm +++ b/gnu/packages/emacs-xyz.scm @@ -27846,7 +27846,7 @@ snippets for Emacs.") (define-public emacs-org-roam (package (name "emacs-org-roam") - (version "1.2.4") + (version "2.0.0") (source (origin (method git-fetch) @@ -27855,7 +27855,7 @@ snippets for Emacs.") (commit (string-append "v" version)))) (file-name (git-file-name name version)) (sha256 - (base32 "10jrnjq65lpg1x8d7lqc537yai9m6pdnfbzwr87fcyv6f8yii8xn")))) + (base32 "0mslrdgd41czay3w7znz4qsv1h0p3zqfsq6bkyxmxfyd2w5z82zf")))) (build-system emacs-build-system) (arguments `(#:phases @@ -27878,6 +27878,7 @@ snippets for Emacs.") `(("emacs-dash" ,emacs-dash) ("emacs-emacsql-sqlite3" ,emacs-emacsql-sqlite3) ("emacs-f" ,emacs-f) + ("emacs-magit" ,emacs-magit) ("emacs-org" ,emacs-org) ("emacs-s" ,emacs-s))) (home-page "https://github.com/org-roam/org-roam/")