From patchwork Mon Jul 19 21:19:43 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Brice Waegeneire X-Patchwork-Id: 31512 Return-Path: X-Original-To: patchwork@mira.cbaines.net Delivered-To: patchwork@mira.cbaines.net Received: by mira.cbaines.net (Postfix, from userid 113) id BDBC627BC78; Mon, 19 Jul 2021 22:20:24 +0100 (BST) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on mira.cbaines.net X-Spam-Level: X-Spam-Status: No, score=-2.9 required=5.0 tests=BAYES_00,MAILING_LIST_MULTI, RCVD_IN_MSPIKE_H4,RCVD_IN_MSPIKE_WL,SPF_HELO_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.2 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mira.cbaines.net (Postfix) with ESMTPS id 7E80227BC6B for ; Mon, 19 Jul 2021 22:20:24 +0100 (BST) Received: from localhost ([::1]:43578 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1m5agZ-0000NX-KP for patchwork@mira.cbaines.net; Mon, 19 Jul 2021 17:20:23 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:59858) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1m5agE-0000NG-6m for guix-patches@gnu.org; Mon, 19 Jul 2021 17:20:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:48949) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1m5agD-0007Jq-V0 for guix-patches@gnu.org; Mon, 19 Jul 2021 17:20:01 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1m5agD-0007yh-Rm for guix-patches@gnu.org; Mon, 19 Jul 2021 17:20:01 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#49650] [PATCH] services: dovecot: Fix "/var/run/dovecot" owner. Resent-From: Brice Waegeneire Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Mon, 19 Jul 2021 21:20:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 49650 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 49650@debbugs.gnu.org X-Debbugs-Original-To: guix-patches@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.162672959230647 (code B ref -1); Mon, 19 Jul 2021 21:20:01 +0000 Received: (at submit) by debbugs.gnu.org; 19 Jul 2021 21:19:52 +0000 Received: from localhost ([127.0.0.1]:60495 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m5ag4-0007yD-4y for submit@debbugs.gnu.org; Mon, 19 Jul 2021 17:19:52 -0400 Received: from lists.gnu.org ([209.51.188.17]:59298) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m5ag3-0007y7-5T for submit@debbugs.gnu.org; Mon, 19 Jul 2021 17:19:51 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:59846) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1m5ag2-0000KX-VX for guix-patches@gnu.org; Mon, 19 Jul 2021 17:19:50 -0400 Received: from relay7-d.mail.gandi.net ([217.70.183.200]:53967) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1m5ag1-000786-5t for guix-patches@gnu.org; Mon, 19 Jul 2021 17:19:50 -0400 Received: (Authenticated sender: brice@waegenei.re) by relay7-d.mail.gandi.net (Postfix) with ESMTPSA id 3FBB420003 for ; Mon, 19 Jul 2021 21:19:45 +0000 (UTC) From: Brice Waegeneire Date: Mon, 19 Jul 2021 23:19:43 +0200 Message-Id: <20210719211943.23824-1-brice@waegenei.re> X-Mailer: git-send-email 2.32.0 MIME-Version: 1.0 Received-SPF: pass client-ip=217.70.183.200; envelope-from=brice@waegenei.re; helo=relay7-d.mail.gandi.net X-Spam_score_int: -25 X-Spam_score: -2.6 X-Spam_bar: -- X-Spam_report: (-2.6 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+patchwork=mira.cbaines.net@gnu.org Sender: "Guix-patches" X-getmail-retrieved-from-mailbox: Patches * gnu/services/mail.scm (%dovecot-activation)[mkdir-p/perms]: Change owner of "directory" not the static string "/var/run/dovecot". --- gnu/services/mail.scm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Following a discussion on IRC¹. There are several other bug in that service but those should only manifest when using non default configuration, for example using a user other that "dovecot" or a run time directory other than "/var/run/dovevot", etc... ¹ diff --git a/gnu/services/mail.scm b/gnu/services/mail.scm index 72dc123f41..805f4ec864 100644 --- a/gnu/services/mail.scm +++ b/gnu/services/mail.scm @@ -1515,7 +1515,7 @@ greyed out, instead of only later giving \"not selectable\" popup error. (use-modules (guix build utils)) (define (mkdir-p/perms directory owner perms) (mkdir-p directory) - (chown "/var/run/dovecot" (passwd:uid owner) (passwd:gid owner)) + (chown directory (passwd:uid owner) (passwd:gid owner)) (chmod directory perms)) (define (build-subject parameters) (string-concatenate