Message ID | 20210703092842.32189-2-leo.prikler@student.tugraz.at |
---|---|
State | Accepted |
Headers | show |
Series | [bug#49329,v2,1/5] gnu: python2-renpy: Drop unused Ren'py sources. | expand |
Context | Check | Description |
---|---|---|
cbaines/comparison | success | View comparision |
cbaines/git branch | success | View Git branch |
cbaines/applying patch | success | View Laminar job |
cbaines/issue | success | View issue |
Leo Prikler <leo.prikler@student.tugraz.at> writes: > * gnu/packages/game-development.scm (python2-renpy)[description]: Mention, > that it's only used for bootstrapping renpy. > --- > gnu/packages/game-development.scm | 6 ++++-- > 1 file changed, 4 insertions(+), 2 deletions(-) > > diff --git a/gnu/packages/game-development.scm b/gnu/packages/game-development.scm > index 22c44a585c..9b231ad333 100644 > --- a/gnu/packages/game-development.scm > +++ b/gnu/packages/game-development.scm > @@ -1250,8 +1250,10 @@ developed mainly for Ren'py.") > ("xdg-utils" ,xdg-utils))) > (home-page "https://www.renpy.org/") > (synopsis "Ren'py python module") > - (description "This package contains the shared libraries and Python > -modules of Ren'py.") > + (description "This package contains the shared libraries and Python modules > +of Ren'py. While functional, they are not meaningful on their own without > +the launcher and common Ren'py code provided by the @code{renpy} package and > +are only used to bootstrap it.") > (license license:expat))) > > (define-public renpy LGTM. If this isn't meant to be installed by users, should it be non-public or perhaps hidden?
Am Samstag, den 10.07.2021, 21:53 -0700 schrieb Chris Marusich: > Leo Prikler <leo.prikler@student.tugraz.at> writes: > > > * gnu/packages/game-development.scm (python2-renpy)[description]: > > Mention, > > that it's only used for bootstrapping renpy. > > --- > > gnu/packages/game-development.scm | 6 ++++-- > > 1 file changed, 4 insertions(+), 2 deletions(-) > > > > diff --git a/gnu/packages/game-development.scm b/gnu/packages/game- > > development.scm > > index 22c44a585c..9b231ad333 100644 > > --- a/gnu/packages/game-development.scm > > +++ b/gnu/packages/game-development.scm > > @@ -1250,8 +1250,10 @@ developed mainly for Ren'py.") > > ("xdg-utils" ,xdg-utils))) > > (home-page "https://www.renpy.org/") > > (synopsis "Ren'py python module") > > - (description "This package contains the shared libraries and > > Python > > -modules of Ren'py.") > > + (description "This package contains the shared libraries and > > Python modules > > +of Ren'py. While functional, they are not meaningful on their own > > without > > +the launcher and common Ren'py code provided by the @code{renpy} > > package and > > +are only used to bootstrap it.") > > (license license:expat))) > > > > (define-public renpy > > LGTM. If this isn't meant to be installed by users, should it be > non-public or perhaps hidden? Good point, but I don't think users will accidentally install it like they do with gcc. This description was written to address a point made by Ludovic in IRC concerning the package's lack of one. Having the package publicly exported also makes my own life easier when updating the recipe. Last, but not least, these are functional modules and could be used to develop code, that depends on Ren'py's internals, but none of the "common" renpy stuff (or the common renpy stuff could otherwise be extracted from the renpy package and changed to the developer's desires). Regards, Leo
Leo Prikler <leo.prikler@student.tugraz.at> writes: > Am Samstag, den 10.07.2021, 21:53 -0700 schrieb Chris Marusich: >> Leo Prikler <leo.prikler@student.tugraz.at> writes: >> >> > * gnu/packages/game-development.scm (python2-renpy)[description]: >> > Mention, >> > that it's only used for bootstrapping renpy. >> > --- >> > gnu/packages/game-development.scm | 6 ++++-- >> > 1 file changed, 4 insertions(+), 2 deletions(-) >> > >> > diff --git a/gnu/packages/game-development.scm b/gnu/packages/game- >> > development.scm >> > index 22c44a585c..9b231ad333 100644 >> > --- a/gnu/packages/game-development.scm >> > +++ b/gnu/packages/game-development.scm >> > @@ -1250,8 +1250,10 @@ developed mainly for Ren'py.") >> > ("xdg-utils" ,xdg-utils))) >> > (home-page "https://www.renpy.org/") >> > (synopsis "Ren'py python module") >> > - (description "This package contains the shared libraries and >> > Python >> > -modules of Ren'py.") >> > + (description "This package contains the shared libraries and >> > Python modules >> > +of Ren'py. While functional, they are not meaningful on their own >> > without >> > +the launcher and common Ren'py code provided by the @code{renpy} >> > package and >> > +are only used to bootstrap it.") >> > (license license:expat))) >> > >> > (define-public renpy >> >> LGTM. If this isn't meant to be installed by users, should it be >> non-public or perhaps hidden? > Good point, but I don't think users will accidentally install it like > they do with gcc. This description was written to address a point made > by Ludovic in IRC concerning the package's lack of one. Having the > package publicly exported also makes my own life easier when updating > the recipe. Last, but not least, these are functional modules and > could be used to develop code, that depends on Ren'py's internals, but > none of the "common" renpy stuff (or the common renpy stuff could > otherwise be extracted from the renpy package and changed to the > developer's desires). OK. I'm fine with that, then.
diff --git a/gnu/packages/game-development.scm b/gnu/packages/game-development.scm index 22c44a585c..9b231ad333 100644 --- a/gnu/packages/game-development.scm +++ b/gnu/packages/game-development.scm @@ -1250,8 +1250,10 @@ developed mainly for Ren'py.") ("xdg-utils" ,xdg-utils))) (home-page "https://www.renpy.org/") (synopsis "Ren'py python module") - (description "This package contains the shared libraries and Python -modules of Ren'py.") + (description "This package contains the shared libraries and Python modules +of Ren'py. While functional, they are not meaningful on their own without +the launcher and common Ren'py code provided by the @code{renpy} package and +are only used to bootstrap it.") (license license:expat))) (define-public renpy