From patchwork Thu May 13 13:06:21 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Martin Becze X-Patchwork-Id: 29278 Return-Path: X-Original-To: patchwork@mira.cbaines.net Delivered-To: patchwork@mira.cbaines.net Received: by mira.cbaines.net (Postfix, from userid 113) id C4CFA27BC81; Thu, 13 May 2021 14:10:13 +0100 (BST) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on mira.cbaines.net X-Spam-Level: X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED, MAILING_LIST_MULTI,RCVD_IN_MSPIKE_H4,RCVD_IN_MSPIKE_WL,SPF_HELO_PASS, T_DKIM_INVALID,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.2 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mira.cbaines.net (Postfix) with ESMTPS id 9837827BC78 for ; Thu, 13 May 2021 14:10:13 +0100 (BST) Received: from localhost ([::1]:52554 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lhB6S-0003EL-Ok for patchwork@mira.cbaines.net; Thu, 13 May 2021 09:10:12 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:40914) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lhB3P-00072a-JO for guix-patches@gnu.org; Thu, 13 May 2021 09:07:03 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:58330) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lhB3P-0002so-Av for guix-patches@gnu.org; Thu, 13 May 2021 09:07:03 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1lhB3P-0008RR-6j for guix-patches@gnu.org; Thu, 13 May 2021 09:07:03 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#48396] [PATCH 3/4] gnu: node-lts: Add phase 'delete-cluster-tests. Resent-From: Martin Becze Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Thu, 13 May 2021 13:07:03 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 48396 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 48396@debbugs.gnu.org Cc: Martin Becze Received: via spool by 48396-submit@debbugs.gnu.org id=B48396.162091120232401 (code B ref 48396); Thu, 13 May 2021 13:07:03 +0000 Received: (at 48396) by debbugs.gnu.org; 13 May 2021 13:06:42 +0000 Received: from localhost ([127.0.0.1]:41639 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lhB34-0008QR-Gs for submit@debbugs.gnu.org; Thu, 13 May 2021 09:06:42 -0400 Received: from mx1.riseup.net ([198.252.153.129]:58184) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lhB31-0008Pn-RD for 48396@debbugs.gnu.org; Thu, 13 May 2021 09:06:40 -0400 Received: from fews1.riseup.net (fews1-pn.riseup.net [10.0.1.83]) (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits)) (Client CN "*.riseup.net", Issuer "Sectigo RSA Domain Validation Secure Server CA" (not verified)) by mx1.riseup.net (Postfix) with ESMTPS id 4FgsP646RNzF2tf for <48396@debbugs.gnu.org>; Thu, 13 May 2021 06:06:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=riseup.net; s=squak; t=1620911194; bh=uzsTwUtSnc+a2jj+QZX/jR7OqNlK+3kVQsS59vyr8yY=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=gzq+Qfcu/m1fT2jeVSSVEZA6ykTzuN8JNf0K0eqR3ErD6yt+JAapBCQKJrbV7yZFW pshYtYcjw9/1pkxdjIY+OrQ3XUZb7fGguln0oIKLEvSOqjIrwBGgi+Ewl16YfH0q5r jSMyERii3iSzcwnhJzFxbZiJ3HeeCFqnW6UoJqgQ= X-Riseup-User-ID: F230CC270AB6305395C10DD3624C4ACE426C82673C7451DA83404C4A2C42E8BF Received: from [127.0.0.1] (localhost [127.0.0.1]) by fews1.riseup.net (Postfix) with ESMTPSA id 4FgsP54hj2z5vnv; Thu, 13 May 2021 06:06:33 -0700 (PDT) From: Martin Becze Date: Thu, 13 May 2021 08:06:21 -0500 Message-Id: <20210513130622.4288-3-mjbecze@riseup.net> In-Reply-To: <20210513130622.4288-1-mjbecze@riseup.net> References: <20210513130211.4057-1-mjbecze@riseup.net> <20210513130622.4288-1-mjbecze@riseup.net> MIME-Version: 1.0 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+patchwork=mira.cbaines.net@gnu.org Sender: "Guix-patches" X-getmail-retrieved-from-mailbox: Patches This adds a phases 'delete-cluster-tests which will be replaced by future versions of node. * gnu/packages/node.scm (node-lts): Add phase 'delete-cluster-tests. --- gnu/packages/node.scm | 15 ++++++++------- 1 file changed, 8 insertions(+), 7 deletions(-) diff --git a/gnu/packages/node.scm b/gnu/packages/node.scm index 17f435ca39..d7b46190e4 100644 --- a/gnu/packages/node.scm +++ b/gnu/packages/node.scm @@ -666,12 +666,6 @@ source files.") (("'/usr/bin/env'") (string-append "'" (which "env") "'"))) - ;; FIXME: These tests fail in the build container, but they don't - ;; seem to be indicative of real problems in practice. - (for-each delete-file - '("test/parallel/test-cluster-master-error.js" - "test/parallel/test-cluster-master-kill.js")) - ;; These require a DNS resolver. (for-each delete-file '("test/parallel/test-dns.js" @@ -713,7 +707,14 @@ source files.") "deps/llhttp/src/http.c") (copy-file (string-append llhttp "/include/llhttp.h") "deps/llhttp/include/llhttp.h")) - #t)))))) + #t)) + (add-after 'patch-files 'delete-cluster-tests + (lambda _ + ;; FIXME: These tests fail in the build container, but they don't + ;; seem to be indicative of real problems in practice. + (for-each delete-file + '("test/parallel/test-cluster-master-error.js" + "test/parallel/test-cluster-master-kill.js")))))))) (inputs `(("c-ares" ,c-ares/fixed) ("icu4c" ,icu4c-68)